[JIRA] (JENKINS-50645) Post failure condition should be evaluated after other conditions

1 view
Skip to first unread message

bitwiseman@gmail.com (JIRA)

unread,
Apr 7, 2018, 3:11:02 AM4/7/18
to jenkinsc...@googlegroups.com
Liam Newman created an issue
 
Jenkins / Task JENKINS-50645
Post failure condition should be evaluated after other conditions
Issue Type: Task Task
Assignee: Andrew Bayer
Components: pipeline-model-definition-plugin
Created: 2018-04-07 07:10
Priority: Major Major
Reporter: Liam Newman

The post "failure" condition fires after the "always" condition (and I number of others), but before the "success" condition and "aborted" conditions.  This means that if there is a failure in the "always" condition steps, the "failure" condition steps will fire.  But if there is a failure in the "success" condition steps, the "failure" condition steps will not fire. 

This would make sense if the the "failure" condition only fired if the stage steps failed but never fired if one of the post condition steps failed.  But that is not the case.

 

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
Atlassian logo

bitwiseman@gmail.com (JIRA)

unread,
Apr 7, 2018, 5:22:02 AM4/7/18
to jenkinsc...@googlegroups.com

andrew.bayer@gmail.com (JIRA)

unread,
Apr 17, 2018, 5:09:02 PM4/17/18
to jenkinsc...@googlegroups.com

andrew.bayer@gmail.com (JIRA)

unread,
Apr 17, 2018, 5:09:03 PM4/17/18
to jenkinsc...@googlegroups.com

andrew.bayer@gmail.com (JIRA)

unread,
Apr 17, 2018, 5:09:03 PM4/17/18
to jenkinsc...@googlegroups.com
Andrew Bayer started work on Task JENKINS-50645
 
Change By: Andrew Bayer
Status: Open In Progress

scm_issue_link@java.net (JIRA)

unread,
Apr 24, 2018, 3:39:01 PM4/24/18
to jenkinsc...@googlegroups.com

Code changed in jenkins
User: Andrew Bayer
Path:
pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/model/conditions/Failure.groovy
pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/model/conditions/Success.groovy
pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/model/conditions/Unstable.groovy
pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/BuildConditionResponderTest.java
pipeline-model-definition/src/test/resources/postFailureAfterSuccess.groovy
pipeline-model-definition/src/test/resources/postFailureAfterUnstable.groovy
http://jenkins-ci.org/commit/pipeline-model-definition-plugin/7e0eaf4b300cd98b6754d940dbad19c5d51de5b2
Log:
[FIXED JENKINS-50645] Move failure to run after other status checks

This way failure will still evaluate even if the actual failure
doesn't occur until in the success or unstable blocks.

andrew.bayer@gmail.com (JIRA)

unread,
Apr 24, 2018, 3:40:03 PM4/24/18
to jenkinsc...@googlegroups.com
 

Merged, will be in 1.2.10.

Change By: Andrew Bayer
Status: In Review Resolved
Resolution: Fixed

bitwiseman@gmail.com (JIRA)

unread,
Oct 22, 2019, 11:25:00 PM10/22/19
to jenkinsc...@googlegroups.com
Liam Newman closed an issue as Fixed
 

Bulk closing resolved issues.

Change By: Liam Newman
Status: Resolved Closed
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages