[JIRA] (JENKINS-50561) Add @Symbol to "throttle builds" job properties

0 views
Skip to first unread message

r.fuereder@xortex.com (JIRA)

unread,
Apr 4, 2018, 2:29:02 AM4/4/18
to jenkinsc...@googlegroups.com
Reinhold Füreder created an issue
 
Jenkins / Improvement JENKINS-50561
Add @Symbol to "throttle builds" job properties
Issue Type: Improvement Improvement
Assignee: Unassigned
Components: workflow-job-plugin
Created: 2018-04-04 06:28
Priority: Minor Minor
Reporter: Reinhold Füreder

Currently the snippet generator suggests/generates:

properties([[$class: 'JobPropertyImpl', throttle: [count: 1, durationName: 'hour', userBoost: true]]])
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
Atlassian logo

o.v.nenashev@gmail.com (JIRA)

unread,
Apr 4, 2018, 2:58:03 AM4/4/18
to jenkinsc...@googlegroups.com
Oleg Nenashev assigned an issue to Stephen Connolly
Change By: Oleg Nenashev
Assignee: Stephen Connolly

o.v.nenashev@gmail.com (JIRA)

unread,
Apr 4, 2018, 2:58:03 AM4/4/18
to jenkinsc...@googlegroups.com
Oleg Nenashev updated an issue
Change By: Oleg Nenashev
Component/s: branch-api-plugin
Component/s: workflow-job-plugin

o.v.nenashev@gmail.com (JIRA)

unread,
Apr 4, 2018, 2:58:03 AM4/4/18
to jenkinsc...@googlegroups.com
Oleg Nenashev updated an issue
Change By: Oleg Nenashev
Labels: newbie-friendly

o.v.nenashev@gmail.com (JIRA)

unread,
Apr 4, 2018, 2:58:03 AM4/4/18
to jenkinsc...@googlegroups.com

andrew.bayer@gmail.com (JIRA)

unread,
Aug 8, 2018, 2:11:03 PM8/8/18
to jenkinsc...@googlegroups.com
Andrew Bayer assigned an issue to Andrew Bayer
 
Change By: Andrew Bayer
Assignee: Stephen Connolly Andrew Bayer
This message was sent by Atlassian JIRA (v7.10.1#710002-sha1:6efc396)

andrew.bayer@gmail.com (JIRA)

unread,
Aug 8, 2018, 2:11:03 PM8/8/18
to jenkinsc...@googlegroups.com
Andrew Bayer started work on Improvement JENKINS-50561
 
Change By: Andrew Bayer
Status: Open In Progress

andrew.bayer@gmail.com (JIRA)

unread,
Aug 8, 2018, 2:11:03 PM8/8/18
to jenkinsc...@googlegroups.com
Change By: Andrew Bayer
Status: In Progress Review

andrew.bayer@gmail.com (JIRA)

unread,
Aug 8, 2018, 2:11:03 PM8/8/18
to jenkinsc...@googlegroups.com
Andrew Bayer commented on Improvement JENKINS-50561
 
Re: Add @Symbol to "throttle builds" job properties

PR up at https://github.com/jenkinsci/branch-api-plugin/pull/127 adding the symbol rateLimitBuilds - I wanted to avoid having "throttle" in the symbol since it means something different here than it does over in Throttle Concurrent Builds.

kuisathaverat@gmail.com (JIRA)

unread,
Mar 11, 2019, 9:18:01 AM3/11/19
to jenkinsc...@googlegroups.com

I have hit this today, the Directive Generator generates the following code that it is wrong

  options {
    rateLimitBuilds([count: 60, durationName: 'hour', userBoost: false])
  }

it should be this one, notice that it missed adding the `throttle` part

  options {
    rateLimitBuilds(throttle: [count: 60, durationName: 'hour', userBoost: false])
  }
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

bitwiseman@gmail.com (JIRA)

unread,
May 29, 2019, 3:28:02 PM5/29/19
to jenkinsc...@googlegroups.com
Change By: Liam Newman
Status: In Review Resolved
Resolution: Fixed

bitwiseman@gmail.com (JIRA)

unread,
May 29, 2019, 3:29:02 PM5/29/19
to jenkinsc...@googlegroups.com
Liam Newman commented on Improvement JENKINS-50561
 
Re: Add @Symbol to "throttle builds" job properties

Ivan Fernandez Calvo
Please open a new issue. Should be an easy fix.

bitwiseman@gmail.com (JIRA)

unread,
May 29, 2019, 3:29:03 PM5/29/19
to jenkinsc...@googlegroups.com
Liam Newman updated an issue
 
Change By: Liam Newman
Comment: [~ifernandezcalvo]

Please open a new issue.  Should be an easy fix.

bitwiseman@gmail.com (JIRA)

unread,
May 29, 2019, 3:29:04 PM5/29/19
to jenkinsc...@googlegroups.com
Liam Newman reopened an issue
Change By: Liam Newman
Resolution: Fixed
Status: Resolved Reopened
Assignee: Andrew Bayer Liam Newman

bitwiseman@gmail.com (JIRA)

unread,
May 29, 2019, 3:31:01 PM5/29/19
to jenkinsc...@googlegroups.com

kuisathaverat@gmail.com (JIRA)

unread,
May 29, 2019, 3:33:01 PM5/29/19
to jenkinsc...@googlegroups.com

not at all

r.fuereder@xortex.com (JIRA)

unread,
Jul 4, 2019, 4:21:02 AM7/4/19
to jenkinsc...@googlegroups.com

(I can confirm that it is not working and just silently ignored )
Reply all
Reply to author
Forward
0 new messages