[JIRA] (JENKINS-50290) origin pr builds not treated as trusted

szivos.john@gmail.com (JIRA)

unread,

Mar 20, 2018, 10:47:02 AM3/20/18

to jenkinsc...@googlegroups.com

John Szivós created an issue

Jenkins /

JENKINS-50290

origin pr builds not treated as trusted

Issue Type:	Bug
Assignee:	Unassigned
Components:	bitbucket-branch-source-plugin
Created:	2018-03-20 14:46
Labels:	plugin jenkins
Priority:	Major
Reporter:	John Szivós

When building PRs from origin (not forks), their Jenkinsfile is not treated as trusted and loaded from the base branch instead:

Loading trusted files from base branch develop at 3ad383ee0eeffc92c9712dc8e3022c4b43a75c94 rather than 3e2b6e35cbf0fd2d4c029fcd23560f04b1976618

The problem was fixed in ~~JENKINS-40652~~ but after several "refactorings" the problem seems to have reoccurred.

Add Comment

This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)

kiessig.rene@gmx.de (JIRA)

unread,

Apr 19, 2018, 4:36:02 AM4/19/18

to jenkinsc...@googlegroups.com

René Kießig commented on

JENKINS-50290

Re: origin pr builds not treated as trusted

Any updates on this issue?

Add Comment

f.modler@gmx.net (JIRA)

unread,

May 28, 2018, 11:36:02 AM5/28/18

to jenkinsc...@googlegroups.com

Falko Modler commented on

JENKINS-50290

Re: origin pr builds not treated as trusted

This is pretty much a blocker for us.

If someone could point me in the right direction I'd take a stab at this. I am lost somewhere between BitbucketSCMSource.getTrustedRevision(SCMRevision, TaskListener) and OriginChangeRequestSCMHeadAuthority.checkTrusted(SCMSourceRequest, ChangeRequestSCMHead2)...

Add Comment

f.modler@gmx.net (JIRA)

unread,

May 28, 2018, 11:41:01 AM5/28/18

to jenkinsc...@googlegroups.com

Falko Modler edited a comment on

JENKINS-50290

Re: origin pr builds not treated as trusted

This is pretty much a blocker for us.

If someone ([~stephenconnolly] ?) could point me in the right direction I'd take a stab at this. I am lost somewhere between {{BitbucketSCMSource.getTrustedRevision(SCMRevision, TaskListener)}} and {{OriginChangeRequestSCMHeadAuthority.checkTrusted(SCMSourceRequest, ChangeRequestSCMHead2)}}...