[JIRA] (JENKINS-49731) p4-plugin viewFilter unusable

jenkins@x.keshi.org (JIRA)

unread,

Feb 25, 2018, 11:03:02 AM2/25/18

to jenkinsc...@googlegroups.com

Takeshi Yaegashi created an issue

Jenkins /

JENKINS-49731

p4-plugin viewFilter unusable

Issue Type:	Bug
Assignee:	Unassigned
Components:	p4-plugin
Created:	2018-02-25 16:02
Environment:	Jenkins 2.89.4 p4-plugin 1.8.5
Priority:	Major
Reporter:	Takeshi Yaegashi

Since 1.8.5, I'm getting IllegalArgumentException with viewFilter():

 
                                                                checkout perforce(credential: 'anything', filter: [viewFilter('//depot/any/path')], ...)

 
                                                                java.lang.IllegalArgumentException: Arguments to class org.jenkinsci.plugins.p4.filters.FilterPatternListImpl have to be explicitly named
	at org.jenkinsci.plugins.structs.describable.DescribableModel.instantiate(DescribableModel.java:276)
	at org.jenkinsci.plugins.structs.describable.UninstantiatedDescribable.instantiate(UninstantiatedDescribable.java:168)
	at org.jenkinsci.plugins.structs.describable.DescribableModel.coerce(DescribableModel.java:394)
	at org.jenkinsci.plugins.structs.describable.DescribableModel.coerceList(DescribableModel.java:485)
	at org.jenkinsci.plugins.structs.describable.DescribableModel.coerce(DescribableModel.java:387)
	at org.jenkinsci.plugins.structs.describable.DescribableModel.buildArguments(DescribableModel.java:340)
	at org.jenkinsci.plugins.structs.describable.DescribableModel.instantiate(DescribableModel.java:281)
Caused: java.lang.IllegalArgumentException: Could not instantiate {credential=anything, filter=[@viewFilter(<anonymous>=//depot/any/path)], ....[snip] 
                                                            

I suppose it's related to @Symbol annotation in class FilterPatternListImpl. This should be other than "viewFilter" in class FilterViewMaskImpl.

https://github.com/jenkinsci/p4-plugin/blob/master/src/main/java/org/jenkinsci/plugins/p4/filters/FilterPatternListImpl.java#L63

Add Comment

This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)

pallen@perforce.com (JIRA)

unread,

Aug 16, 2019, 10:50:01 AM8/16/19

to jenkinsc...@googlegroups.com

Paul Allen commented on

JENKINS-49731

Re: p4-plugin viewFilter unusable

Sorry for the delay (over a year). It's not possible for two implementations to have the same symbol. I can't remember why, but one of them got renamed. The DataBoundConstructor for viewFilter only takes one argument and it's possible that the older implementation got changed.

FilterViewMaskImpl uses @Symbol("viewFilter")

FilterPatternListImpl uses @Symbol("viewPattern")