[JIRA] (JENKINS-49235) Fingerprinting added in ssh-slaves causes memory-leak and performance issue with dynamic slaves

3 views
Skip to first unread message

andrewtaylor2@gmail.com (JIRA)

unread,
Aug 17, 2018, 5:28:02 AM8/17/18
to jenkinsc...@googlegroups.com
Andy Taylor commented on Bug JENKINS-49235
 
Re: Fingerprinting added in ssh-slaves causes memory-leak and performance issue with dynamic slaves

Some additional updates to this as discussions have been had in various PRs.

Devin Nusbaum created https://github.com/jenkinsci/credentials-plugin/pull/103 which improved upon my changes in https://github.com/jenkinsci/credentials-plugin/pull/97 and included all the requested changes in that PR. Would anyone be able to look at that and see if that ticks all the boxes to merge please?

Additionally I have just found out about https://issues.jenkins-ci.org/browse/JENKINS-50984 which led to a PR being merged against the ssh-slaves plugin to be able to selectively disable the tracking of credentials for slave launching: https://github.com/jenkinsci/ssh-slaves-plugin/pull/94 . This would possibly be able to eliminate the issue I raised here, but is a very broad brush and appears to remove all of the tracking of the credentials for slave launching, i.e. not limited to cloud connections where the slaves are not re-used. I am going to test that and see if it helps my situation. That update hasn't made it's way to the download site yet though, so I'll have to grab the latest built version from the Jenkins build server.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.10.1#710002-sha1:6efc396)

kuisathaverat@gmail.com (JIRA)

unread,
Nov 19, 2018, 2:39:02 AM11/19/18
to jenkinsc...@googlegroups.com

there is a change to try to mitigate this issue in ssh-slave-1.29.0

This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

boards@gmail.com (JIRA)

unread,
Aug 1, 2019, 3:08:03 PM8/1/19
to jenkinsc...@googlegroups.com
Matt Sicker updated Bug JENKINS-49235
 

Merged to master.

Jenkins / Bug JENKINS-49235
Change By: Matt Sicker
Status: In Review Fixed but Unreleased
Resolution: Fixed

boards@gmail.com (JIRA)

unread,
Aug 1, 2019, 4:36:02 PM8/1/19
to jenkinsc...@googlegroups.com
 

Released in credentials-2.2.1.

Change By: Matt Sicker
Status: Fixed but Unreleased Resolved
Released As: credentials-2.2.1
Reply all
Reply to author
Forward
0 new messages