[JIRA] (JENKINS-49022) Performance plugin. Allow choosing percentiles to track

0 views
Skip to first unread message

senthilkumar.rasan@gmail.com (JIRA)

unread,
Feb 14, 2018, 11:44:02 AM2/14/18
to jenkinsc...@googlegroups.com
Senthilkumar Rasan commented on Improvement JENKINS-49022
 
Re: Performance plugin. Allow choosing percentiles to track

Error occurs right after save button click (only when i add relative constraint and try to save). Attached screenshot with config details. Error is blocking to save the relative constraint added to job. hence i cant run the job without removing relative constraint.
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
Atlassian logo

senthilkumar.rasan@gmail.com (JIRA)

unread,
Feb 14, 2018, 11:45:02 AM2/14/18
to jenkinsc...@googlegroups.com
Senthilkumar Rasan updated an issue
 
Jenkins / Improvement JENKINS-49022
Change By: Senthilkumar Rasan
Attachment: Jenkins_PPError_1.JPG
Attachment: Jenkins_PPError_2.JPG

artem.fedorov@blazemeter.com (JIRA)

unread,
Feb 19, 2018, 4:12:03 AM2/19/18
to jenkinsc...@googlegroups.com
Artem Fedorov commented on Improvement JENKINS-49022
 
Re: Performance plugin. Allow choosing percentiles to track

I think we're fixed these errors in this release. Maybe you use snapshot that attached to this issue?
Can you reinstall this plugins from jenkins marketplace? or download  http://updates.jenkins-ci.org/download/plugins/performance/
http://jenkinsci.github.io/performance-plugin/Changelog.html

Thanks,
Artem

o.v.nenashev@gmail.com (JIRA)

unread,
Feb 23, 2018, 4:58:02 AM2/23/18
to jenkinsc...@googlegroups.com

Hi all. If you see the serialization rejecting messages, please read https://jenkins.io/blog/2018/01/13/jep-200/ (linked from the stacktrace)
There are reporting guidelines and the list of affected plugins

senthilkumar.rasan@gmail.com (JIRA)

unread,
Feb 23, 2018, 11:32:01 AM2/23/18
to jenkinsc...@googlegroups.com

I am getting the same error with snapshot attached with this issue. Error started right after jenkins upgrade to  2.104(right now i have 2.108 which throws same error)

Artem, did u test in version 2.104 or above. Error occurs when i add any relative constraint and save the job. Let me know if you need any details.

artem.fedorov@blazemeter.com (JIRA)

unread,
Feb 26, 2018, 3:24:02 AM2/26/18
to jenkinsc...@googlegroups.com

Thanks for your information. I'll upgrade my Jenkins and try again. 

senthilkumar.rasan@gmail.com (JIRA)

unread,
Mar 13, 2018, 11:28:03 AM3/13/18
to jenkinsc...@googlegroups.com

Any update?

 

artem.fedorov@blazemeter.com (JIRA)

unread,
Mar 13, 2018, 11:36:02 AM3/13/18
to jenkinsc...@googlegroups.com

Sorry, not yet. Maybe in the next week I'll have time for reproduce and fix it.
Maybe you can use jenkins LTS version, that have not such bug?

senthilkumar.rasan@gmail.com (JIRA)

unread,
Mar 13, 2018, 12:49:02 PM3/13/18
to jenkinsc...@googlegroups.com

Thanks

o.v.nenashev@gmail.com (JIRA)

unread,
Mar 13, 2018, 12:51:04 PM3/13/18
to jenkinsc...@googlegroups.com
Oleg Nenashev updated an issue
 
Change By: Oleg Nenashev
Labels: JEP-200

o.v.nenashev@gmail.com (JIRA)

unread,
Mar 13, 2018, 12:51:04 PM3/13/18
to jenkinsc...@googlegroups.com
Oleg Nenashev commented on Improvement JENKINS-49022
 
Re: Performance plugin. Allow choosing percentiles to track

Artem Fedorov JEP-200 lands in LTS on this Wednesday. I recommend to not release the proposed patch until the compatibility is fixed.
CC Jesse Glick

o.v.nenashev@gmail.com (JIRA)

unread,
Mar 13, 2018, 12:53:02 PM3/13/18
to jenkinsc...@googlegroups.com

JEP-200 is not a bug FYI. It is an intentional security hardening.

o.v.nenashev@gmail.com (JIRA)

unread,
Mar 13, 2018, 12:54:02 PM3/13/18
to jenkinsc...@googlegroups.com
Oleg Nenashev edited a comment on Improvement JENKINS-49022
JEP-200 is not a bug FYI. It is an intentional security hardening at it was announced 2 months ago . No plan to whitelist the date formatter classes in the core.

artem.fedorov@blazemeter.com (JIRA)

unread,
Mar 13, 2018, 2:21:02 PM3/13/18
to jenkinsc...@googlegroups.com

Oleg Nenashev 
Is it means, that I should remove all non-transient DateFormats fields from this plugin like in this PR https://github.com/jenkinsci/last-changes-plugin/compare/a3fa178233e3...8ea546001e39 ?
Or  should I add this classes to a resource file META-INF/hudson.remoting.ClassFilter ?
Is it possible, that we have such stacktrace  because we have such 2 fields in ConstraintDescription? https://github.com/jenkinsci/performance-plugin/blob/de83c8836ad5900b1066b7f44c33dcc33df3bdee/src/main/java/hudson/plugins/performance/constraints/RelativeConstraint.java#L50 
Thanks

o.v.nenashev@gmail.com (JIRA)

unread,
Mar 13, 2018, 3:12:03 PM3/13/18
to jenkinsc...@googlegroups.com

> Is it means, that I should remove all non-transient DateFormats fields from this plugin like in this PR https://github.com/jenkinsci/last-changes-plugin/compare/a3fa178233e3...8ea546001e39 ?

Yes, it is a preferred approach

> Or should I add this classes to a resource file META-INF/hudson.remoting.ClassFilter ?

You can do it as a workaround. Note that DateFormat classes are not synchronized internally, it is generally unsafe to use such fields in concurrent applications unless you have external sycnhronization

Yes, it is possible. Non-transient Descriptor fields are being serialized to the disk as a part of the global config. Such fields are also the subject to the concurrency issues mentioned above.

Are these fields present in the current release? If yes, probably the current versions are affected by the fix as well

o.v.nenashev@gmail.com (JIRA)

unread,
Mar 13, 2018, 3:12:03 PM3/13/18
to jenkinsc...@googlegroups.com
Oleg Nenashev edited a comment on Improvement JENKINS-49022
> Is it means, that I should remove all non-transient DateFormats fields from this plugin like in this PR https://github.com/jenkinsci/last-changes-plugin/compare/a3fa178233e3...8ea546001e39 ?

Yes, it is a preferred approach

> Or  should I add this classes to a resource file META-INF/hudson.remoting.ClassFilter ?

You can do it as a workaround. Note that DateFormat classes are not synchronized internally, it is generally unsafe to use such fields in concurrent applications unless you have external sycnhronization

> Is it possible, that we have such stacktrace  because we have such 2 fields in ConstraintDescription? https://github.com/jenkinsci/performance-plugin/blob/de83c8836ad5900b1066b7f44c33dcc33df3bdee/src/main/java/hudson/plugins/performance/constraints/RelativeConstraint.java#L50

Yes, it is possible. Non-transient Descriptor fields are being serialized to the disk as a part of the global config. Such fields are also the subject to the concurrency issues mentioned above.

Are these fields present in the current release? If yes, probably the current versions are affected by the fix JEP-200 as well

artem.fedorov@blazemeter.com (JIRA)

unread,
Mar 14, 2018, 5:47:02 AM3/14/18
to jenkinsc...@googlegroups.com

Oleg Nenashev
I reproduced it with Jenkins 2.111 and this PR fixed it. https://github.com/jenkinsci/performance-plugin/pull/162 

artem.fedorov@blazemeter.com (JIRA)

unread,
Mar 14, 2018, 5:48:07 AM3/14/18
to jenkinsc...@googlegroups.com

artem.fedorov@blazemeter.com (JIRA)

unread,
Mar 14, 2018, 10:45:02 AM3/14/18
to jenkinsc...@googlegroups.com
Change By: Artem Fedorov
Status: Open Resolved
Resolution: Fixed

senthilkumar.rasan@gmail.com (JIRA)

unread,
Mar 14, 2018, 11:52:02 AM3/14/18
to jenkinsc...@googlegroups.com
Senthilkumar Rasan commented on Improvement JENKINS-49022
 
Re: Performance plugin. Allow choosing percentiles to track

Thanks Artem for swift response. Could you attach the updated hpi file here. Getting build error in my local machine. Thanks. Appreciated.

artem.fedorov@blazemeter.com (JIRA)

unread,
Mar 14, 2018, 3:11:02 PM3/14/18
to jenkinsc...@googlegroups.com
Artem Fedorov updated an issue
 
Change By: Artem Fedorov
Attachment: performance.hpi

artem.fedorov@blazemeter.com (JIRA)

unread,
Mar 14, 2018, 3:11:03 PM3/14/18
to jenkinsc...@googlegroups.com

senthilkumar.rasan@gmail.com (JIRA)

unread,
Mar 16, 2018, 10:06:03 AM3/16/18
to jenkinsc...@googlegroups.com

Thanks Artem. Its working fine. Appreciated. 

Now performance plugin provides all required info except trend graphs with custom percentile (right now percentile Response time in select graphed metric defaulted to 90). Let me know if you add that feature.

 

Thanks

Senthil

goldyliang@gmail.com (JIRA)

unread,
Jun 12, 2019, 11:06:02 PM6/12/19
to jenkinsc...@googlegroups.com

Hi Senthil,

Is there a plan to show trend graphs with custom percentile values? I am really looking forward to that.

And further more, it looks to me the graph of response time only shows the average value, even I choose the graphType as 'PRT'.

Below is my code snippet, maybe there is something missing in it?

perfReport filterRegex: null, graphType: 'PRT', percentiles: '0,90,95,99,100', sourceDataFiles: 'SLA'

I don't see anywhere using my percentile values, except in the table of "last report".

Goldy

 
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

goldyliang@gmail.com (JIRA)

unread,
Jun 25, 2019, 6:38:02 AM6/25/19
to jenkinsc...@googlegroups.com
Goldy Liang edited a comment on Improvement JENKINS-49022
Hi Senthil, [~artem_fedorov]

Is there a plan to show trend graphs with custom percentile values? I am really looking forward to that.

And further more, it looks to me the graph of response time only shows the average value, even I choose the graphType as 'PRT'.

Below is my code snippet, maybe there is something missing in it?

{{perfReport filterRegex: null, graphType: 'PRT', percentiles: '0,90,95,99,100', sourceDataFiles: 'SLA'}}

I don't see anywhere using my percentile values, except in the table of "last report".

Goldy

 

artem.fedorov@blazemeter.com (JIRA)

unread,
Jun 25, 2019, 8:20:02 AM6/25/19
to jenkinsc...@googlegroups.com

Hi Goldy Liang
Do you asking about feature that was already implemented ~ year ago? https://github.com/jenkinsci/performance-plugin/pull/158 
Reply all
Reply to author
Forward
0 new messages