[JIRA] (JENKINS-49006) ConcurrentModificationException in getThrottledPipelineRunsForCategory

0 views
Skip to first unread message

o.v.nenashev@gmail.com (JIRA)

unread,
Feb 22, 2018, 9:51:04 AM2/22/18
to jenkinsc...@googlegroups.com
Oleg Nenashev assigned an issue to Unassigned
 

Unfortunately I was unable to find time to work on plugin over last year. I decided to step down as maintainer and to mark the plugin for adoption.

If anybody is interested, let me know

Jenkins / Bug JENKINS-49006
ConcurrentModificationException in getThrottledPipelineRunsForCategory
Change By: Oleg Nenashev
Assignee: Oleg Nenashev
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
Atlassian logo

medianick@gmail.com (JIRA)

unread,
Apr 23, 2019, 8:54:03 AM4/23/19
to jenkinsc...@googlegroups.com
Nick Jones commented on Bug JENKINS-49006
 
Re: ConcurrentModificationException in getThrottledPipelineRunsForCategory

We were bitten by this today; a PR build (on a multibranch pipeline job) started freezing – appearing to still be in progress in the UI, but not assigned to any executor, and never progressing past the node step, with this in the Jenkins system log:

Apr 23, 2019 7:36:18 AM WARNING jenkins.util.AtmostOneTaskExecutor$1 call
null
java.util.ConcurrentModificationException
	at java.util.TreeMap$PrivateEntryIterator.nextEntry(TreeMap.java:1211)
	at java.util.TreeMap$EntryIterator.next(TreeMap.java:1247)
	at java.util.TreeMap$EntryIterator.next(TreeMap.java:1242)
	at hudson.plugins.throttleconcurrents.ThrottleJobProperty.getThrottledPipelineRunsForCategory(ThrottleJobProperty.java:316)
	at hudson.plugins.throttleconcurrents.ThrottleQueueTaskDispatcher.throttleCheckForCategoriesAllNodes(ThrottleQueueTaskDispatcher.java:283)
	at hudson.plugins.throttleconcurrents.ThrottleQueueTaskDispatcher.canRunImpl(ThrottleQueueTaskDispatcher.java:256)
	at hudson.plugins.throttleconcurrents.ThrottleQueueTaskDispatcher.canRun(ThrottleQueueTaskDispatcher.java:218)
	at hudson.plugins.throttleconcurrents.ThrottleQueueTaskDispatcher.canRun(ThrottleQueueTaskDispatcher.java:176)
	at hudson.model.Queue.getCauseOfBlockageForItem(Queue.java:1197)
	at hudson.model.Queue.maintain(Queue.java:1554)
	at hudson.model.Queue$1.call(Queue.java:325)
	at hudson.model.Queue$1.call(Queue.java:322)
	at jenkins.util.AtmostOneTaskExecutor$1.call(AtmostOneTaskExecutor.java:108)
	at jenkins.util.AtmostOneTaskExecutor$1.call(AtmostOneTaskExecutor.java:98)
	at jenkins.security.ImpersonatingExecutorService$2.call(ImpersonatingExecutorService.java:71)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at hudson.remoting.AtmostOneThreadExecutor$Worker.run(AtmostOneThreadExecutor.java:112)
	at java.lang.Thread.run(Thread.java:748)

I tried aborting and restarting it multiple times but it consistently behaved the same way; the only way we got it to build again was by commenting out the throttle block entirely. It would be marginally better if it had simply failed the build, but far better if this ConcurrentModificationException were not happening at all. Incidentially, this PR was a switch to use Scripted Pipeline due to JENKINS-45140, since Declarative Syntax didn't seem to throttle at all.

This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

me@basilcrow.com (JIRA)

unread,
Feb 5, 2020, 6:20:02 PM2/5/20
to jenkinsc...@googlegroups.com
Basil Crow commented on Bug JENKINS-49006
 
Re: ConcurrentModificationException in getThrottledPipelineRunsForCategory

Christopher Head, Sascha Kiedrowski, and Nick Jones, this issue should be resolved on master and I am preparing a release of Throttle Concurrent Builds with the fix for this issue. There is an incremental build available here. Are any of you interested in testing this incremental build before I do an official release?

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

chead@chead.ca (JIRA)

unread,
Feb 6, 2020, 12:06:04 AM2/6/20
to jenkinsc...@googlegroups.com
Christopher Head commented on Bug JENKINS-49006
 
Re: ConcurrentModificationException in getThrottledPipelineRunsForCategory

Sorry, I can’t test it. I switched to Lockable Resources a long time ago, initially to fix this bug but now we use some other features too.

medianick@gmail.com (JIRA)

unread,
Feb 6, 2020, 2:58:02 PM2/6/20
to jenkinsc...@googlegroups.com
Nick Jones commented on Bug JENKINS-49006
 
Re: ConcurrentModificationException in getThrottledPipelineRunsForCategory

Basil Crow Yes, I'd be happy to get it tested on our side. We too had switched to Lockable Resources (like Christopher Head), though in our case was a bit of a kludge (to achieve throttling using a redefined set of resources that share the same category), so I'd be happy to retry with this new incremental build on our test Jenkins system. I'll grab it and post back here with my findings.

medianick@gmail.com (JIRA)

unread,
Feb 6, 2020, 6:11:05 PM2/6/20
to jenkinsc...@googlegroups.com
Nick Jones edited a comment on Bug JENKINS-49006
 
Re: ConcurrentModificationException in getThrottledPipelineRunsForCategory
[~basil] Yes, I'd be happy to get it tested on our side. We too had switched to Lockable Resources (like [~haw777]), though in our case was a bit of a kludge (to achieve throttling using a redefined set predefined quantity of resources that share the same category), so I'd be happy to retry with this new incremental build on our test Jenkins system. I'll grab it and post back here with my findings.

me@basilcrow.com (JIRA)

unread,
Feb 13, 2020, 2:19:04 PM2/13/20
to jenkinsc...@googlegroups.com

me@basilcrow.com (JIRA)

unread,
Feb 13, 2020, 2:20:03 PM2/13/20
to jenkinsc...@googlegroups.com

me@basilcrow.com (JIRA)

unread,
Feb 19, 2020, 4:18:05 PM2/19/20
to jenkinsc...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages