[JIRA] (JENKINS-47643) Allow [ci skip] to work for non-pull request changes

1 view
Skip to first unread message

m.bonnekessel@lvm.de (JIRA)

unread,
Jun 15, 2018, 4:51:03 AM6/15/18
to jenkinsc...@googlegroups.com
marbon commented on New Feature JENKINS-47643
 
Re: Allow [ci skip] to work for non-pull request changes

Any update on this issue? We are very interested in using "[ci skip]" to skip maven release commits for example.
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
Atlassian logo

witokondoria@gmail.com (JIRA)

unread,
Aug 23, 2018, 1:40:03 PM8/23/18
to jenkinsc...@googlegroups.com

Just for the record: I have finally started working on it.
Still untested, Github associated feature seems to be easy, from the provided API, to implement. OTOH, BitBucket API seems its missing some bolts (so might slow everything a bit)
This message was sent by Atlassian JIRA (v7.10.1#710002-sha1:6efc396)

kburnett@rosettastone.com (JIRA)

unread,
Aug 23, 2018, 1:59:03 PM8/23/18
to jenkinsc...@googlegroups.com

you are a hero.

witokondoria@gmail.com (JIRA)

unread,
Oct 8, 2018, 3:28:02 PM10/8/18
to jenkinsc...@googlegroups.com

Kevin Burnett, marbon and David Sanftenberg, could you test the opened pull request artifacts? Both hpi files found at https://ci.jenkins.io/blue/organizations/jenkins/Plugins%2Fscm-trait-commit-skip-plugin/detail/feature%2FskippingBranches/1/artifacts (github and bitbucket) implement filtering branches on both [skip-ci] and [ci-skip] committed messages
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

kburnett@rosettastone.com (JIRA)

unread,
Oct 14, 2018, 12:58:02 AM10/14/18
to jenkinsc...@googlegroups.com
Kevin Burnett updated an issue
 
Jenkins / New Feature JENKINS-47643
Change By: Kevin Burnett
Attachment: cannot-load.png

witokondoria@gmail.com (JIRA)

unread,
Oct 14, 2018, 4:09:02 AM10/14/18
to jenkinsc...@googlegroups.com
 
Re: Allow [ci skip] to work for non-pull request changes

Forgot to say that for testing this on bitbucket, another incrementals dependency must be manually installed (hpi from https://ci.jenkins.io/blue/organizations/jenkins/Plugins%2Fbitbucket-branch-source-plugin/detail/PR-145/7/artifacts)

Needless to say that these are developments versions ans should be installed (desireably) on a test Jenkins instance

kburnett@rosettastone.com (JIRA)

unread,
Oct 15, 2018, 1:44:02 PM10/15/18
to jenkinsc...@googlegroups.com
Kevin Burnett updated an issue
Change By: Kevin Burnett
Attachment: duplicate-name-in-config.png

kburnett@rosettastone.com (JIRA)

unread,
Oct 15, 2018, 1:47:02 PM10/15/18
to jenkinsc...@googlegroups.com
Kevin Burnett commented on New Feature JENKINS-47643
 
Re: Allow [ci skip] to work for non-pull request changes

i got the dependent plugin from https://repo.jenkins-ci.org/incrementals/org/jenkins-ci/plugins/cloudbees-bitbucket-branch-source/2.2.13-rc440.a1f1e6c1d925/, tested it out with Jason Lantz, and it works as designed. in our context, the fact that the branch is tagged excluded and therefore deleted by the orphaned item strategy (exactly as Javier Delgado said it would be) actually is a dealbreaker. we are very excited about this feature, but i think we need to wait for JENKINS-45502 to be implemented so that "ci skip" can be implemented without this side effect (FYI, Stephen Connolly / James Dumay).

two additional notes:

  • you need to specify "ci skip" without the hyphen
  • when you specify behaviours, there are now two called "Commit message filtering behaviour" (one for pull requests and one for branches). they should probably have different names. see screenshot below.

thanks a ton, Javier Delgado.

witokondoria@gmail.com (JIRA)

unread,
Oct 15, 2018, 4:45:02 PM10/15/18
to jenkinsc...@googlegroups.com

Certainly, the expected tokens doesnt contain hypens (á la circleci - https://circleci.com/docs/2.0/skip-build/)
There is another PR, still unreviewed, to allow a regexp (instead of such fixed tokens).
Will fix the behaviour names so they differ
The outcome of JENKINS-45502 will indeed alter how the skipping is performed. Nevertheless, giving the ticket priority and activity, I wouldnt foresee it to receive work mid-term.

shamil.si@gmail.com (JIRA)

unread,
Jan 30, 2019, 8:47:03 PM1/30/19
to jenkinsc...@googlegroups.com

Javier Delgado any updates on this. We are really looking forward to this feature...

witokondoria@gmail.com (JIRA)

unread,
Feb 5, 2019, 5:20:02 PM2/5/19
to jenkinsc...@googlegroups.com

This should be included on the 0.2.0 released plugin. Should appear at the update center shortly.

Could you provide feedback, in order to close this ticket?

shamil.si@gmail.com (JIRA)

unread,
Feb 5, 2019, 7:32:02 PM2/5/19
to jenkinsc...@googlegroups.com

Thanks a lot Javier Delgado. Works as expected!

witokondoria@gmail.com (JIRA)

unread,
Feb 6, 2019, 2:00:07 AM2/6/19
to jenkinsc...@googlegroups.com
Change By: Javier Delgado
Status: In Progress Review

witokondoria@gmail.com (JIRA)

unread,
Feb 6, 2019, 2:00:07 AM2/6/19
to jenkinsc...@googlegroups.com
Change By: Javier Delgado
Status: In Review Resolved
Resolution: Fixed

tom.kiemes@sap.com (JIRA)

unread,
Jul 3, 2019, 11:17:03 AM7/3/19
to jenkinsc...@googlegroups.com
Tom Kiemes commented on New Feature JENKINS-47643
 
Re: Allow [ci skip] to work for non-pull request changes

Javier Delgado sorry to bother, but was this developed just for Bitbucket or also for GitHub?

I am using version 0.4.0 of "GitHub Commit Skip SCM Behaviour" plugin on a Jenkins connected to GitHub Enterprise and my configuration looks as follows:

  • GitHub Organisation project
  • Build strategies (in this order; not sure if the order is important here):
    • Change requests
    • Regular branches
    • Skip build trigger if commit message contains
      • Pattern : skip

The documentation still states, that "The filtering is only performed for change request events, so push events to non-pull requests will be always run". But the same sentence is still in the doc for BitBucket and as far as I understand the discussion, this is working?

Any help would be appreciated.

Best regards, Tom
Reply all
Reply to author
Forward
0 new messages