[JIRA] (JENKINS-47617) CHANGE_BRANCH no longer reporting branch name, but instead PR

3 views
Skip to first unread message

r.achten@gmail.com (JIRA)

unread,
Feb 8, 2018, 7:54:02 AM2/8/18
to jenkinsc...@googlegroups.com
Rein Achten edited a comment on Bug JENKINS-47617
 
Re: CHANGE_BRANCH no longer reporting branch name, but instead PR
I've just pinpointed this to v2.2.4 of the bitbucket-branch-source-plugin. In v2.2.3, {{CHANGE_BRANCH}} is still set according to expectation. Looking through the diffs, it seems to be caused by the changes on context of [the following pull request|https://github.com/jenkinsci/bitbucket-branch-source-plugin/pull/63] (for JENKINS-45775).

[~stephenconnolly] I'm not familiar with the plugin and don't completely understand the [rationale|https://github.com/jenkinsci/bitbucket-branch-source-plugin/pull/63/files#r129575824] behind using {{branchName}} instead of {{pull.getSource().getBranch().getName()}} [here|https://github.com/jenkinsci/bitbucket-branch-source-plugin/blob/761fa289a13ff5750f7fdb8be0c980e688143197/src/main/java/com/cloudbees/jenkins/plugins/bitbucket/BitbucketSCMSource.java#L65], but I reckon this is causing the problem. Can you shed your light on this?
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
Atlassian logo

r.achten@gmail.com (JIRA)

unread,
Feb 8, 2018, 7:55:02 AM2/8/18
to jenkinsc...@googlegroups.com
Rein Achten edited a comment on Bug JENKINS-47617
I've just pinpointed this to v2.2.4 of the bitbucket-branch-source-plugin. In v2.2.3, {{CHANGE_BRANCH}} is still set according to expectation. Looking through the diffs, it seems to be caused by the changes on context of [the following pull request|https://github.com/jenkinsci/bitbucket-branch-source-plugin/pull/63] (for JENKINS-45775).

[~stephenconnolly] I'm not familiar with the plugin and don't completely understand the [rationale|https://github.com/jenkinsci/bitbucket-branch-source-plugin/pull/63/files#r129575824] behind using {{branchName}} instead of {{pull.getSource().getBranch().getName()}} [here|https://github.com/jenkinsci/bitbucket-branch-source-plugin/blob/761fa289a13ff5750f7fdb8be0c980e688143197/src/main/java/com/cloudbees/jenkins/plugins/bitbucket/BitbucketSCMSource.java# L65 L657 ], but I reckon this is causing the problem. Can you shed your light on this?

bastianbrodbeck@googlemail.com (JIRA)

unread,
May 7, 2018, 10:09:05 AM5/7/18
to jenkinsc...@googlegroups.com

Any update on this one? I just ran in this issue. No idea how to solve it as I am new to Jenkins.

amirbarkal@sparkbeyond.com (JIRA)

unread,
May 23, 2018, 9:27:03 AM5/23/18
to jenkinsc...@googlegroups.com
Amir Barkal updated an issue
 
Jenkins / Bug JENKINS-47617
Change By: Amir Barkal
Attachment: Screenshot from 2018-05-23 16-25-19.png

amirbarkal@sparkbeyond.com (JIRA)

unread,
May 23, 2018, 9:29:02 AM5/23/18
to jenkinsc...@googlegroups.com
Amir Barkal commented on Bug JENKINS-47617
 
Re: CHANGE_BRANCH no longer reporting branch name, but instead PR

+1

 

Another problem this issue is causing happens when you open the pull requests tab, you don't see the name of the branch anymore, you only see the PR number:

 

In blue ocean you see the PR name which is nice, but it would be nicer to also clearly see the branch name of the PR.

 

danielsvedberg74@gmail.com (JIRA)

unread,
May 23, 2018, 12:17:04 PM5/23/18
to jenkinsc...@googlegroups.com

I think someone should at least answer this. It has little meaning to have the CHANGE_BRANCH  set to PR-{number} 

helias.criouet@blablacar.com (JIRA)

unread,
Jun 13, 2018, 5:30:05 AM6/13/18
to jenkinsc...@googlegroups.com

Any update on that still existing blocker issue? Rein Achten seems to have done some useful reasoning work in his comment. Does it seem reasonable to you Stephen Connolly?

helias.criouet@blablacar.com (JIRA)

unread,
Jun 13, 2018, 5:31:06 AM6/13/18
to jenkinsc...@googlegroups.com
Helias Criouet edited a comment on Bug JENKINS-47617
Any update on that still existing blocker issue? [~reac] seems to have done some useful reasoning work in [ his comment |https://issues . jenkins-ci.org/browse/JENKINS-47617?focusedCommentId=327864&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-327864]. Does it seem reasonable to you [~stephenconnolly]?

helias.criouet@blablacar.com (JIRA)

unread,
Jun 13, 2018, 5:31:06 AM6/13/18
to jenkinsc...@googlegroups.com
Helias Criouet edited a comment on Bug JENKINS-47617
Any update on that still existing blocker issue? [~reac] seems to have done some useful reasoning  investigation work in [ his comment |https://issues . jenkins-ci.org/browse/JENKINS-47617?focusedCommentId=327864&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-327864]. Does it seem reasonable to you [~stephenconnolly]?

josephp90@gmail.com (JIRA)

unread,
Oct 27, 2018, 3:03:03 PM10/27/18
to jenkinsc...@googlegroups.com
Joseph Petersen resolved as Fixed
 
Change By: Joseph Petersen
Status: Open Resolved
Assignee: Joseph Petersen
Resolution: Fixed
Released As: 2.2.13
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

fasching.matthias@gmail.com (JIRA)

unread,
Nov 19, 2018, 11:44:10 AM11/19/18
to jenkinsc...@googlegroups.com
Matthias F commented on Bug JENKINS-47617
 
Re: CHANGE_BRANCH no longer reporting branch name, but instead PR

Even in version 2.2.14 this issue is still present! CHANGE_BRANCH still contains the PR-XX number instead of the name of the branch.

fasching.matthias@gmail.com (JIRA)

unread,
Nov 19, 2018, 11:44:15 AM11/19/18
to jenkinsc...@googlegroups.com
Change By: Matthias F
Status: Resolved In Review

fasching.matthias@gmail.com (JIRA)

unread,
Nov 19, 2018, 11:44:24 AM11/19/18
to jenkinsc...@googlegroups.com
Change By: Matthias F
Status: In Review Progress

fasching.matthias@gmail.com (JIRA)

unread,
Nov 19, 2018, 11:44:25 AM11/19/18
to jenkinsc...@googlegroups.com
Matthias F stopped work on Bug JENKINS-47617
 
Change By: Matthias F
Resolution: Fixed
Status: In Progress Open

fasching.matthias@gmail.com (JIRA)

unread,
Nov 19, 2018, 12:13:07 PM11/19/18
to jenkinsc...@googlegroups.com
Matthias F edited a comment on Bug JENKINS-47617
Even in version 2.2.14 this issue is still present ! . CHANGE_BRANCH still contains the PR-XX number instead of the name of the branch.

EDIT: my bad, 2.2.14 breaks in our setup because of this issue: https://issues.jenkins-ci.org/browse/JENKINS-54401 with 2.2.13 it works

fasching.matthias@gmail.com (JIRA)

unread,
Nov 19, 2018, 12:13:15 PM11/19/18
to jenkinsc...@googlegroups.com
Matthias F started work on Bug JENKINS-47617
 
Change By: Matthias F
Status: Open In Progress

fasching.matthias@gmail.com (JIRA)

unread,
Nov 19, 2018, 12:13:22 PM11/19/18
to jenkinsc...@googlegroups.com
Change By: Matthias F
Status: In Progress Review

fasching.matthias@gmail.com (JIRA)

unread,
Nov 19, 2018, 12:13:24 PM11/19/18
to jenkinsc...@googlegroups.com
Change By: Matthias F
Status: In Review Resolved
Resolution: Fixed

josephp90@gmail.com (JIRA)

unread,
Mar 7, 2020, 1:07:54 AM3/7/20
to jenkinsc...@googlegroups.com
Joseph Petersen assigned an issue to Joseph Petersen
Change By: Joseph Petersen
Assignee: Joseph Petersen (old)
This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages