[JIRA] (JENKINS-44360) '%' in branch name causes GitHub multi-branch job failures

[mark.earl.waite@gmail.com (JIRA)]

Mark Waite updated an issue

Jenkins / JENKINS-44360 '%' in branch name causes GitHub multi-branch job failures Change By: Mark Waite Summary: '%' in branch name causes Windows GitHub multi-branch job failures Add Comment

This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

[mark.earl.waite@gmail.com (JIRA)]

Mark Waite updated an issue

Jenkins / JENKINS-44360 '%' in branch name causes GitHub multi-branch job failures Change By: Mark Waite

A '%' character in a branch name breaks clone the GitHub API calls on a git repository if the job performing the clone is generated by GitHub Organization Folder plugin (windows or Linux) or the multi- GitHub branch plugin source (windows master or agent only).   The same character in the same branch does not break clone with a multi-branch pipeline automatically defined job on Linux. Steps to duplicate the problem: # Define a GitHub multibranch PIpeline job referencing the MarkEWaite/jenkins-bugs repository (or a GitHub Organization Folders job which references the GitHub organization MarkEWaite, looking only at the repository jenkins-bugs ) # Scan the repository, watch the jobs run # Open the has-percent-%-JENKINS-44360 job and confirm it failed to clone Steps to show the same branch working with a multibranch pipeline: # Define a multi-branch pipeline job using the MarkEWaite/jenkins-bugs github repo using Git as the branch source rather than GitHub # Scan the repository, watch the jobs run # Open the has-percent-%-JENKINS-44360 job and confirm it cloned successfully The issue seems to require: * GitHub Organization Folders or GitHub multibranch * '%' in the branch name on the repository

Add Comment

[mark.earl.waite@gmail.com (JIRA)]

Mark Waite updated an issue

Jenkins / JENKINS-44360 '%' in branch name causes GitHub multi-branch job failures Change By: Mark Waite

A '%' character in a branch name breaks the GitHub API calls on a git repository if the job performing the clone is generated by GitHub Organization Folder plugin (windows or Linux) or the GitHub branch source (windows master or agent only Linux ).

Steps to duplicate the problem: # Define a GitHub multibranch PIpeline job referencing the MarkEWaite/jenkins-bugs repository (or a GitHub Organization Folders job which references the GitHub organization MarkEWaite, looking only at the repository jenkins-bugs) # Scan the repository, watch the jobs run # Open the has-percent-%-JENKINS-44360 job and confirm it failed to clone Steps to show the same branch working with a multibranch pipeline: # Define a multi-branch pipeline job using the MarkEWaite/jenkins-bugs github repo using Git as the branch source rather than GitHub # Scan the repository, watch the jobs run # Open the has-percent-%-JENKINS-44360 job and confirm it cloned successfully The issue seems to require: * GitHub Organization Folders or GitHub multibranch * '%' in the branch name on the repository

Add Comment

[jglick@cloudbees.com (JIRA)]

Jesse Glick commented on JENKINS-44360

Re: '%' in branch name causes GitHub multi-branch job failures Mark Waite you changed the Status to be IN REVIEW but there is no Assignee and I see no linked PR purporting to fix the issue. Perhaps you just meant to set this to Open, and change the component to github-branch-source-plugin since that seems to be the source of the problem?

Add Comment

[mark.earl.waite@gmail.com (JIRA)]

Mark Waite updated JENKINS-44360

Jenkins / JENKINS-44360

'%' in branch name causes GitHub multi-branch job failures

Change By: Mark Waite Status: In Review Progress

Add Comment

[mark.earl.waite@gmail.com (JIRA)]

Mark Waite stopped work on JENKINS-44360

Change By: Mark Waite Status: In Progress Open

Add Comment

[mark.earl.waite@gmail.com (JIRA)]

Mark Waite updated an issue

Jenkins / JENKINS-44360 '%' in branch name causes GitHub multi-branch job failures

Change By: Mark Waite Component/s: github-branch-source-plugin Component/s: branch-api-plugin

Add Comment

[mark.earl.waite@gmail.com (JIRA)]

Mark Waite commented on JENKINS-44360

Re: '%' in branch name causes GitHub multi-branch job failures Thanks @jglick! I took too simple approach and chose the bug state as one of the proposed in the flow for next state, rather than setting it to the correct state of Open. State has been corrected and reassigned to github-branch-source-plugin.

Add Comment

[mark.earl.waite@gmail.com (JIRA)]

Mark Waite edited a comment on JENKINS-44360

Re: '%' in branch name causes GitHub multi-branch job failures

Thanks @ [~ jglick ] !  I took too simple approach and chose the bug state as one of the proposed in the flow for next state, rather than setting it to the correct state of *Open*.  State has been corrected and reassigned to github-branch-source-plugin.

Add Comment

[mark.earl.waite@gmail.com (JIRA)]

Mark Waite edited a comment on JENKINS-44360

Re: '%' in branch name causes GitHub multi-branch job failures

Thanks [~jglick]!  I took too simple approach and chose the bug state status as one of the proposed in the flow for next state status , rather than setting it to the correct state of *Open*.   State   Status has been corrected and reassigned to github-branch-source-plugin.

Add Comment