[JIRA] (JENKINS-43195) non-relocated "com.github.fge.jsonschema" classes can cause issues elsewhere

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer created an issue

Jenkins / JENKINS-43195 non-relocated "com.github.fge.jsonschema" classes can cause issues elsewhere Issue Type: Bug Assignee: Andrew Bayer Components: pipeline-model-definition-plugin Created: 2017/Mar/29 5:10 PM Priority: Minor Reporter: Andrew Bayer We don't relocate "com.github.fge.jsonschema.*" but probably should - not relocating them means anyone else trying to depend on a different version of the library gets hosed, and anyone trying to depend on that version ends up with weird relocated Jackson APIs. So...we should relocate this too. Add Comment

This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer commented on JENKINS-43195

Re: non-relocated "com.github.fge.jsonschema" classes can cause issues elsewhere Easy PR up at https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/148

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer updated JENKINS-43195

Jenkins / JENKINS-43195

non-relocated "com.github.fge.jsonschema" classes can cause issues elsewhere

Change By: Andrew Bayer Status: In Progress Review

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer started work on JENKINS-43195

Change By: Andrew Bayer Status: Open In Progress

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-43195

Re: non-relocated "com.github.fge.jsonschema" classes can cause issues elsewhere Code changed in jenkins User: Andrew Bayer Path: pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/ASTSchema.java pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/parser/Converter.groovy pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/parser/JSONParser.groovy pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/validator/JSONErrorCollector.groovy pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/endpoints/ModelConverterAction.java pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/BaseParserLoaderTest.java pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/validator/JSONSchemaTest.java pipeline-model-json-shaded/pom.xml http://jenkins-ci.org/commit/pipeline-model-definition-plugin/fa56a4c2b5290e77dddd3cd828744dfdc1697c80 Log: [FIXED JENKINS-43195] Relocate shaded com.github.fge.* Avoids polluting classloaders for other uses.

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer updated JENKINS-43195

Jenkins / JENKINS-43195

non-relocated "com.github.fge.jsonschema" classes can cause issues elsewhere

Change By: Andrew Bayer Status: In Review Resolved Resolution: Fixed

Add Comment

[bitwiseman@gmail.com (JIRA)]

Liam Newman closed an issue as Fixed

Bulk closing resolved issues.

Jenkins / JENKINS-43195 non-relocated "com.github.fge.jsonschema" classes can cause issues elsewhere

Change By: Liam Newman Status: Resolved Closed

Add Comment

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)