[JIRA] (JENKINS-42930) Use System proxy when available

9 views
Skip to first unread message

matthieu.nantern@gmail.com (JIRA)

unread,
Mar 20, 2017, 7:20:01 AM3/20/17
to jenkinsc...@googlegroups.com
Matthieu Nantern created an issue
 
Jenkins / New Feature JENKINS-42930
Use System proxy when available
Issue Type: New Feature New Feature
Assignee: Kohsuke Kawaguchi
Components: swarm-plugin
Created: 2017/Mar/20 11:19 AM
Priority: Minor Minor
Reporter: Matthieu Nantern

If System proxy is defined (with -Dhttps.proxyHost or -Dhttp.proxyHost) use it to connect to Jenkins master.

I can provide a PR if you think that this feature is useful.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
Atlassian logo

matthieu.nantern@gmail.com (JIRA)

unread,
Mar 20, 2017, 7:54:01 AM3/20/17
to jenkinsc...@googlegroups.com
Matthieu Nantern updated an issue
Change By: Matthieu Nantern
If System proxy is defined (with -Dhttps.proxyHost or -Dhttp.proxyHost) use it to connect to Jenkins master.

I can provide a PR if you think that this feature is may be useful.

o.v.nenashev@gmail.com (JIRA)

unread,
Feb 26, 2018, 3:28:41 AM2/26/18
to jenkinsc...@googlegroups.com
Oleg Nenashev assigned an issue to Unassigned
 

KK does not maintain this plugin anymore. Moving to unassigned to set the expectation

Change By: Oleg Nenashev
Assignee: Kohsuke Kawaguchi

me@basilcrow.com (JIRA)

unread,
Jun 1, 2019, 2:16:03 PM6/1/19
to jenkinsc...@googlegroups.com
Basil Crow updated an issue
Change By: Basil Crow
Priority: Minor Major
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

me@basilcrow.com (JIRA)

unread,
Jun 1, 2019, 10:39:04 PM6/1/19
to jenkinsc...@googlegroups.com
Basil Crow commented on New Feature JENKINS-42930
 
Re: Use System proxy when available

I took a shot at implementing this in #105. That change uses the SystemDefaultHttpClient class, which supports the following Java properties:

The following system properties are taken into account by this class:

  • ssl.TrustManagerFactory.algorithm
  • javax.net.ssl.trustStoreType
  • javax.net.ssl.trustStore
  • javax.net.ssl.trustStoreProvider
  • javax.net.ssl.trustStorePassword
  • java.home
  • ssl.KeyManagerFactory.algorithm
  • javax.net.ssl.keyStoreType
  • javax.net.ssl.keyStore
  • javax.net.ssl.keyStoreProvider
  • javax.net.ssl.keyStorePassword
  • http.proxyHost
  • http.proxyPort
  • https.proxyHost
  • https.proxyPort
  • http.nonProxyHosts
  • http.keepAlive
  • http.maxConnections

The semantics of these properties are defined here.

I don't have a proxy server against which to test this. Is anyone willing to try out my PR against their proxy server and report back with the results?

me@basilcrow.com (JIRA)

unread,
Jun 2, 2019, 2:09:03 PM6/2/19
to jenkinsc...@googlegroups.com
Basil Crow updated New Feature JENKINS-42930
 

Fixed in #105 and will be released in 3.17.

Change By: Basil Crow
Status: Open Fixed but Unreleased
Assignee: Basil Crow
Resolution: Fixed
Released As: 3.17

me@basilcrow.com (JIRA)

unread,
Jun 2, 2019, 6:22:10 PM6/2/19
to jenkinsc...@googlegroups.com
 

Released in 3.17.

Change By: Basil Crow
Status: Fixed but Unreleased Resolved
Reply all
Reply to author
Forward
0 new messages