[JIRA] (JENKINS-42693) No way to specify build-args for dockerfile

nervo@nervo.net (JIRA)

unread,

Mar 11, 2017, 4:23:05 PM3/11/17

to jenkinsc...@googlegroups.com

nervo nervo created an issue

Jenkins /

JENKINS-42693

No way to specify build-args for dockerfile

Issue Type:	Improvement
Assignee:	Andrew Bayer
Components:	pipeline-model-definition-plugin
Created:	2017/Mar/11 9:22 PM
Priority:	Minor
Reporter:	nervo nervo

It looks like there is no way to specify some build args (--build-arg parameter for docker build) to build an image using the "dockerfile" option. It supports "args", but only to pass to subsequents docker run calls.

 
                                                                pipeline {
  agent {
    dockerfile {
      filename 'foo/Dockerfile'
      args: '--privileged'
    }
  }
} 
                                                            

Add Comment

This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)

andrew.bayer@gmail.com (JIRA)

unread,

Mar 13, 2017, 6:14:01 PM3/13/17

to jenkinsc...@googlegroups.com

Andrew Bayer started work on

JENKINS-42693

Change By:	Andrew Bayer
Status:	Open In Progress

Add Comment

andrew.bayer@gmail.com (JIRA)

unread,

Mar 13, 2017, 6:28:02 PM3/13/17

to jenkinsc...@googlegroups.com

Andrew Bayer commented on

JENKINS-42693

Re: No way to specify build-args for dockerfile

PR up at https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/136, aiming at 1.2 release.

Add Comment

andrew.bayer@gmail.com (JIRA)

unread,

Mar 13, 2017, 6:28:02 PM3/13/17

to jenkinsc...@googlegroups.com

Andrew Bayer updated

JENKINS-42693

Jenkins /

JENKINS-42693

No way to specify build-args for dockerfile

Change By:	Andrew Bayer
Status:	In Progress Review

Add Comment

scm_issue_link@java.net (JIRA)

unread,

Mar 21, 2017, 5:15:06 PM3/21/17

to jenkinsc...@googlegroups.com

SCM/JIRA link daemon commented on

JENKINS-42693

Re: No way to specify build-args for dockerfile

Code changed in jenkins
User: Andrew Bayer
Path:
pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/agent/impl/DockerPipelineFromDockerfile.java
pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/agent/impl/DockerPipelineFromDockerfileScript.groovy
pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/AgentTest.java
pipeline-model-definition/src/test/resources/additionalDockerBuildArgs.groovy
http://jenkins-ci.org/commit/pipeline-model-definition-plugin/04206b8d9122a9b87a0352ce963730212baaa919
Log:
[FIXED JENKINS-42693] Add additionalBuildArgs dockerfile parameter

Allows specifying like
dockerfile {
additionalBuildArgs "--build-arg someArg=someValue"
}
which will get added to the "docker build ..." command line call.