[JIRA] (JENKINS-42597) Percent character (%) in filenames is not url-encoded in the CHANGES page

afein@cloudbees.com (JIRA)

unread,

Mar 8, 2017, 11:30:02 PM3/8/17

to jenkinsc...@googlegroups.com

Aaron Fein created an issue

Jenkins /

JENKINS-42597

Percent character (%) in filenames is not url-encoded in the CHANGES page

Issue Type:	Bug
Assignee:	Kirill Merkushev
Attachments:	changes.png
Components:	github-plugin
Created:	2017/Mar/09 4:29 AM
Priority:	Minor
Reporter:	Aaron Fein

Percent character (%) in filenames is not url-encoded in the CHANGES page. It results in broken links. See screenshot. In this example the URL generated is

https://github.beescloud.com/support-team/ZD-44831/blob/d51bb5f9d80eea1a9d7d3b5d52dc6485c25c4e33/conf_%.txt

whereas it should be

https://github.beescloud.com/support-team/ZD-44831/blob/d51bb5f9d80eea1a9d7d3b5d52dc6485c25c4e33/conf_%25.txt

with the %25 encoding. I believe change need in:

https://github.com/jenkinsci/git-plugin/blob/master/src/main/java/hudson/plugins/git/browser/GithubWeb.java

Add Comment

This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)

lanwen@yandex.ru (JIRA)

unread,

Mar 9, 2017, 4:05:01 AM3/9/17

to jenkinsc...@googlegroups.com

Kirill Merkushev updated an issue

Jenkins /

JENKINS-42597

Percent character (%) in filenames is not url-encoded in the CHANGES page

Change By:	Kirill Merkushev
Component/s:	git-plugin
Component/s:	github-plugin

Add Comment

lanwen@yandex.ru (JIRA)

unread,

Mar 9, 2017, 4:05:01 AM3/9/17

to jenkinsc...@googlegroups.com

Kirill Merkushev assigned an issue to Mark Waite

Jenkins /

JENKINS-42597

Percent character (%) in filenames is not url-encoded in the CHANGES page

Change By:	Kirill Merkushev
Assignee:	Kirill Merkushev Mark Waite

Add Comment

mark.earl.waite@gmail.com (JIRA)

unread,

Mar 9, 2017, 10:21:07 AM3/9/17

to jenkinsc...@googlegroups.com

Mark Waite assigned an issue to Unassigned

Jenkins /

JENKINS-42597

Percent character (%) in filenames is not url-encoded in the CHANGES page

Change By:	Mark Waite
Assignee:	Mark Waite

Add Comment

mark.earl.waite@gmail.com (JIRA)

unread,

Aug 20, 2018, 6:03:02 PM8/20/18

to jenkinsc...@googlegroups.com

Mark Waite edited a comment on

JENKINS-42597

Re: Percent character (%) in filenames is not url-encoded in the CHANGES page

I've duplicated the problem with the [ JENKINS-42597 job|https://github.com/MarkEWaite/docker-lfs/tree/lts-with-plugins/ref/jobs/Bugs-Individual/jobs/JENKINS-42597-percent-in-changed-filename-not-escaped] and with the [JENKINS-42597 branch|https://github.com/MarkEWaite/jenkins-bugs/tree/JENKINS-42597] which creates a pipeline job in my Docker image.  The steps I'd missed (note, this is not the complete set of steps to duplicate the problem, just the steps that I had failed to take from the user interface after defining the job):

# Submit a change to the github repository
# Poll the github repository for changes (in my case, in response to a notifyCommit)
# Confirm the build ran to completion
# Click the link for that specific build (number 12 in my case)
# Click the Changes link, confirm the summary shows a change to build-100%-number
# Click the link to build-100%-number, and see github report 404.  Clicking the diff link in at least one of my jobs correctly navigates to the diff on github

You can see the job definitions that show the problem in the [JENKINS-42597 branch|https://github.com/MarkEWaite/jenkins-bugs/tree/JENKINS-42597] in my jenkins-bugs repository and in the [JENKINS-42597 job|https://github.com/MarkEWaite/docker-lfs/tree/lts-with-plugins/ref/jobs/Bugs-Individual/jobs/JENKINS-42597-percent-in-changed-filename-not-escaped] in my Docker image.

Pictures captured the steps so that I'll remember them...
#  !step-01.PNG|thumbnail!
#  !step-02.PNG|thumbnail!
#  !step-03.PNG|thumbnail!