[JIRA] (JENKINS-41900) Pull "should do checkout?" logic out of Declarative Agents proper

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer created an issue

Jenkins / JENKINS-41900 Pull "should do checkout?" logic out of Declarative Agents proper Issue Type: Improvement Assignee: Andrew Bayer Components: pipeline-model-definition-plugin Created: 2017/Feb/09 4:18 PM Priority: Minor Reporter: Andrew Bayer Relates to JENKINS-41758 - to determine whether we should do a SCM checkout, we need to check Root and SkipDefaultCheckout, both of which are in pipeline-model-definition, so it's hard to make an extension of DeclarativeAgent that just depends on pipeline-model-declarative-agent. That should be fixed. Add Comment

This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer started work on JENKINS-41900

Change By: Andrew Bayer Status: Open In Progress

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer commented on JENKINS-41900

Re: Pull "should do checkout?" logic out of Declarative Agents proper PR up at https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/109

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer updated JENKINS-41900

Jenkins / JENKINS-41900

Pull "should do checkout?" logic out of Declarative Agents proper

Change By: Andrew Bayer Status: In Progress Review

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer updated JENKINS-41900

Jenkins / JENKINS-41900 Pull "should do checkout?" logic out of Declarative Agents proper

Change By: Andrew Bayer Status: In Review Resolved Resolution: Fixed

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-41900

Re: Pull "should do checkout?" logic out of Declarative Agents proper Code changed in jenkins User: Andrew Bayer Path: pipeline-model-declarative-agent/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/agent/DeclarativeAgent.java pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/model/Agent.groovy pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/agent/impl/LabelScript.groovy http://jenkins-ci.org/commit/pipeline-model-definition-plugin/32dff607141a0a82578c85be8457386df10351a5 Log: [FIXED JENKINS-41900] Expose doCheckout on DeclarativeAgent Reduces dependency load for other plugins extending DeclarativeAgent.

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-41900

Re: Pull "should do checkout?" logic out of Declarative Agents proper

Code changed in jenkins User: Andrew Bayer Path: pipeline-model-declarative-agent/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/agent/DeclarativeAgent.java pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/model/Agent.groovy

pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/agent/impl/AbstractDockerPipelineScript.groovy pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/agent/impl/AnyScript.groovy pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/agent/impl/LabelScript.groovy pipeline-model-definition/src/test/resources/org/jenkinsci/plugins/pipeline/modeldefinition/agent/impl/LabelAndOtherFieldAgentScript.groovy http://jenkins-ci.org/commit/pipeline-model-definition-plugin/20f8126272bb09467458d1a978e70016cee1026a Log: Merge pull request #117 from abayer/switch-agent-context-logic Followup to JENKINS-41900 - just record if in stage Compare: https://github.com/jenkinsci/pipeline-model-definition-plugin/compare/afaea38ea3a4...20f8126272bb

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-41900

Re: Pull "should do checkout?" logic out of Declarative Agents proper

Code changed in jenkins User: Andrew Bayer Path: pipeline-model-declarative-agent/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/agent/DeclarativeAgent.java pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/model/Agent.groovy

pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/agent/impl/LabelScript.groovy http://jenkins-ci.org/commit/pipeline-model-definition-plugin/5e21e525e54fe9cabeb86a42a67f590f85e282d3 Log:

Followup to JENKINS-41900 - just record if in stage

There's no actual good reason for carrying the whole context (i.e., Root or Stage object) around in the DeclarativeAgent when all we need to know is whether we're already in a stage. So...switch that to a boolean and have Agent.groovy check whether the context it's handed is a Root instance. If it is a Root instance, we're not in a stage. If it isn't a Root instance, we are in a stage. Tada.

Add Comment

[bitwiseman@gmail.com (JIRA)]

Liam Newman closed an issue as Fixed

Bulk closing resolved issues.

Jenkins / JENKINS-41900

Pull "should do checkout?" logic out of Declarative Agents proper

Change By: Liam Newman Status: Resolved Closed

Add Comment

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)