[JIRA] (JENKINS-41519) Post stages should have well defined order

Post stages should have well defined order

Issue Type:	Improvement
Assignee:	Andrew Bayer
Components:	pipeline-model-definition-plugin
Created:	2017/Jan/27 3:56 PM
Priority:	Major
Reporter:	Robby Pocase

Post stages currently have a defined order in which they run. This limits certain use cases (especially in regards to clean up procedures). It would be nice to be able to specify certain post stages have to run before others.

                                                                Jenkinsfile
                                                            
 
                                                                pipeline {
  agent { label 'label' }
  stages {
    stage('stage') {     
      steps {
        echo "stage"
      }
      post {
        success {
          echo "Success"
        }
        always {
            echo "Always"
            //deleteDir()
        }
      }
    }
  }
}
 
                                                            

 
                                                                [Pipeline] {
[Pipeline] stage
[Pipeline] { (stage)
[Pipeline] echo
stage
[Pipeline] echo
Post stage
[Pipeline] echo
Always
[Pipeline] echo
Success
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // node
[Pipeline] End of Pipeline
 
                                                            

In the example Jenkinsfile, I want success to run before always. In my production use case, I want to stash some artifacts for a future stage. The future stage is set up to run on certain conditions, so clean up cannot be delayed.

How order should be determined is open ended. To me, running in the Jenkinsfile order is more intuitive for a user, but there may be cases where you want to change that.

This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)

ericdnelson@gmail.com (JIRA)

unread,

Feb 28, 2018, 6:10:05 PM2/28/18

to jenkinsc...@googlegroups.com

Eric Nelson commented on

Either a user definable order or a LAST concept would be good. I tried to use always to cleanup the workspace and put a few artifact gathering steps in success and was quite confused for a bit why artifacts were not getting archived.

This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)

ikobh7@gmail.com (JIRA)

unread,

Mar 7, 2018, 4:00:06 AM3/7/18

to jenkinsc...@googlegroups.com

IKO BH updated an issue

Jenkins /

Post stages should have well defined order

Change By:	IKO BH
Attachment:	image-2018-03-07-10-58-26-892.png

ikobh7@gmail.com (JIRA)

unread,

Mar 7, 2018, 4:09:01 AM3/7/18

to jenkinsc...@googlegroups.com

IKO BH commented on

Using the following in my Jenkinsfile:

    stage('Test') {
      steps {
        sh 'pytest --junitxml result.xml testing/'
      }
      post {
        failure {
          mail(to: 'us...@example.com', subject: "Failed Pipeline : ${currentBuild.fullDisplayName}", body: "Something is wrong with ${env.BUILD_URL}")
        }
        always {
          junit 'result.xml'
        }

When one of my test fails, I get the following indication:

But the mail is being sent successfully.

When moving the 'post' section to be under 'pipline' section, or when deleting the 'always' block,leaving only the 'failure' block, Mail section is green.

You think the order of block execution within the 'post' section has an impact on the GUI presented?

As I mentioned, the Mail step doesn't actually fails, it actually send an email as it should. But GUI indicates a failure.

Any thoughts?

jgrant216@gmail.com (JIRA)

unread,

Mar 23, 2018, 12:53:02 PM3/23/18

to jenkinsc...@googlegroups.com

Jeff G commented on

+1 for this. Just got bit because you can't use archiveArtifacts in a post:success if you use cleanWs in post:always because post:always will clean up the artifacts you want to archive.

andrew.bayer@gmail.com (JIRA)

unread,

Apr 3, 2018, 4:08:08 PM4/3/18

to jenkinsc...@googlegroups.com

Andrew Bayer commented on

I think I have something that may help with this over in a PR for JENKINS-41239 - a new post condition, currently called cleanup (because I couldn't call it finally due to that being a reserved word in Groovy), which is like always (as in it'll run regardless of build status), but it runs after all other post conditions. So with this, always is the first post condition to run, and cleanup is the last, regardless of build status. So you can do things like deleteDir() etc in cleanup without problems.

Does that sound like it'd do the trick here?

stefan.thurnherr@gmail.com (JIRA)

unread,

Apr 3, 2018, 4:18:02 PM4/3/18

to jenkinsc...@googlegroups.com

Stefan Thurnherr commented on

Andrew Bayer +1 for the cleanup condition, would solve this issue for us since we mostly want to delete workspace

ericdnelson@gmail.com (JIRA)

unread,

Apr 3, 2018, 5:10:02 PM4/3/18

to jenkinsc...@googlegroups.com

Eric Nelson commented on

Andrew Bayer +1 for cleanup here as well. Solves the issue in most use cases I had in mind. Thanks!

fnasser@redhat.com (JIRA)

unread,

Sep 18, 2018, 3:58:02 PM9/18/18

to jenkinsc...@googlegroups.com

Fernando Nasser commented on