[JIRA] (JENKINS-41503) JSON Schema issue: mapArgumentValue not accepting null

[kzantow@cloudbees.com (JIRA)]

Keith Zantow created an issue

Jenkins / JENKINS-41503 JSON Schema issue: mapArgumentValue not accepting null Issue Type: Bug Assignee: Andrew Bayer Components: pipeline-model-definition-plugin Created: 2017/Jan/27 4:15 AM Priority: Minor Reporter: Keith Zantow Arguments with _ { isLiteral: true, "value": null } _ fail schema validation. I think this needs to allow null values: https://github.com/jenkinsci/pipeline-model-definition-plugin/blob/master/pipeline-model-api/src/main/resources/ast-schema.json#L50 Took this valid pipeline: pipeline { agent { docker { image "httpd:2.4.12" args null } } stages { stage("foo") { steps { sh 'cat /usr/local/apache2/conf/extra/httpd-userdir.conf' sh 'echo "The answer is 42"' } } } } which converts to the corresponding JSON, that no longer passes schema validation due to agent docker args null value: { "pipeline": { "agent": { "type": "docker", "arguments": [ { "key": "image", "value": { "isLiteral": true, "value": "httpd:2.4.12" } }, { "key": "args", "value": { "isLiteral": true, "value": null } } ] }, "stages": [ { "name": "foo", "branches": [ { "name": "default", "steps": [ { "name": "sh", "arguments": [ { "key": "script", "value": { "isLiteral": true, "value": "cat /usr/local/apache2/conf/extra/httpd-userdir.conf" } } ] }, { "name": "sh", "arguments": [ { "key": "script", "value": { "isLiteral": true, "value": "echo \"The answer is 42\"" } } ] } ] } ] } ] } } Add Comment

This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)

[kzantow@cloudbees.com (JIRA)]

Keith Zantow updated an issue

Jenkins / JENKINS-41503 JSON Schema issue: mapArgumentValue not accepting null

Change By: Keith Zantow

Arguments with _ { isLiteral: true, "value": null } _

fail schema validation.

I think this needs to allow null values: https://github.com/jenkinsci/pipeline-model-definition-plugin/blob/master/pipeline-model-api/src/main/resources/ast-schema.json#L50 Took this valid pipeline:

{code}

pipeline {     agent {         docker {             image "httpd:2.4.12"             args null         }     }     stages {         stage("foo") {             steps {                 sh 'cat /usr/local/apache2/conf/extra/httpd-userdir.conf'                 sh 'echo "The answer is 42"'             }         }     } }

{code}

which converts to the corresponding JSON, that no longer passes schema validation due to agent docker args null value:

{code}

{code}

Add Comment

[kzantow@cloudbees.com (JIRA)]

Keith Zantow updated an issue

Jenkins / JENKINS-41503 JSON Schema issue: mapArgumentValue not accepting null Change By: Keith Zantow

Arguments with { isLiteral: true, "value": null } fail schema validation. I think this needs to allow null values: https://github.com/jenkinsci/pipeline-model-definition-plugin/blob/master/pipeline-model-api/src/main/resources/ast-schema.json#L50 or alternately, don't include those args in the JSON during conversion? Not sure if they are necessarily equivalent.

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer commented on JENKINS-41503

Re: JSON Schema issue: mapArgumentValue not accepting null PR up at https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/122

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer updated JENKINS-41503

Jenkins / JENKINS-41503

JSON Schema issue: mapArgumentValue not accepting null

Change By: Andrew Bayer Status: In Progress Review

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer started work on JENKINS-41503

Change By: Andrew Bayer Status: Open In Progress

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-41503

Re: JSON Schema issue: mapArgumentValue not accepting null Code changed in jenkins User: Andrew Bayer Path: pipeline-model-api/src/main/resources/ast-schema.json pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/parser/Converter.groovy pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/AbstractModelDefTest.java pipeline-model-definition/src/test/resources/json/jsonSchemaNull.json pipeline-model-definition/src/test/resources/jsonSchemaNull.groovy http://jenkins-ci.org/commit/pipeline-model-definition-plugin/6e518e32c311d5f80458a1911cbbea6b4da87783 Log: [FIXED JENKINS-41503] Allow null values in JSON Also required changing org.json -> Jackson conversion to go through a string rather than use a mapper due to the mapper not liking nulls at all.

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer updated JENKINS-41503

Jenkins / JENKINS-41503

JSON Schema issue: mapArgumentValue not accepting null

Change By: Andrew Bayer Status: In Review Resolved Resolution: Fixed

Add Comment

[bitwiseman@gmail.com (JIRA)]

Liam Newman closed an issue as Fixed

Bulk closing resolved issues.

Jenkins / JENKINS-41503 JSON Schema issue: mapArgumentValue not accepting null

Change By: Liam Newman Status: Resolved Closed

Add Comment

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)