[JIRA] (JENKINS-41426) EC2- Keeps sending stop signal to a manually stopped instance

[cardenas.mcb@gmail.com (JIRA)]

Manuel Cardenas created an issue

Jenkins / JENKINS-41426 EC2- Keeps sending stop signal to a manually stopped instance Issue Type: Bug Assignee: Francis Upton Components: ec2-plugin Created: 2017/Jan/25 1:48 PM Environment: * Jenkins 2.19.4.2 * Java Version: 1.8.0_111 * ec2:1.36 'Amazon EC2 plugin' Priority: Minor Reporter: Manuel Cardenas When using EC2 plugin to stop (not terminate) slave instances after a certain amount of idle time, if you stop manually one of those slaves you can see in the logs messages like the following one: ``` INFO h.p.ec2.EC2RetentionStrategy#internalCheck: Idle timeout of [XXX] after 82 idle minutes INFO h.plugins.ec2.EC2AbstractSlave#idleTimeout: EC2 instance idle time expired: [XXX-ID] INFO h.plugins.ec2.EC2AbstractSlave#stop: EC2 instance stop request sent for [XXX-ID] ``` This message fill the logs. Any way to remove it? Add Comment

This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)

[cardenas.mcb@gmail.com (JIRA)]

Manuel Cardenas updated an issue

Jenkins / JENKINS-41426 EC2- Keeps sending stop signal to a manually stopped instance

Change By: Manuel Cardenas When using EC2 plugin to stop (not terminate) slave instances after a certain amount of idle time, if you stop manually one of those slaves before the stop signal is sent, you can see in the logs messages like the following one:

``` INFO h.p.ec2.EC2RetentionStrategy#internalCheck: Idle timeout of [XXX] after 82 idle minutes INFO h.plugins.ec2.EC2AbstractSlave#idleTimeout: EC2 instance idle time expired: [XXX-ID] INFO h.plugins.ec2.EC2AbstractSlave#stop: EC2 instance stop request sent for [XXX-ID] ```

The plugin keeps sending the stop signal even if the instance is already stopped.

This message fill the logs. Any way to remove it?

Add Comment

[luigi.tagliamonte86@gmail.com (JIRA)]

Luigi Tagliamonte commented on JENKINS-41426

Re: EC2- Keeps sending stop signal to a manually stopped instance Hello there, I have the same problem and I think that for stopped or disconnected computers (Jenkins slaves nodes) the internal check function https://github.com/jenkinsci/ec2-plugin/blob/master/src/main/java/hudson/plugins/ec2/EC2RetentionStrategy.java#L92 should not be executed or, if it is like that by design (I'm not a Jenkins expert) you should return 1 at the beginning of the function and avoid to do all the math and re-send a stop request. If my analysis if the issue is correct I will be happy to open a PR.

Add Comment

This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)

[luigi.tagliamonte86@gmail.com (JIRA)]

Luigi Tagliamonte edited a comment on JENKINS-41426

Re: EC2- Keeps sending stop signal to a manually stopped instance

Hello there, I have the same problem and I think that for stopped or disconnected computers (Jenkins slaves nodes) the internal check function [ https://github.com/jenkinsci/ec2-plugin/blob/master/src/main/java/hudson/plugins/ec2/EC2RetentionStrategy.java#L92 ]

should not be executed or, if it is like that by design (I'm not a Jenkins expert) you should return 1 at the beginning of the function and avoid to do all the math and re-send a stop request.

If my analysis if of the issue is correct I will be happy to open a PR.

Add Comment

[adrien.lecharpentier@gmail.com (JIRA)]

Adrien Lecharpentier updated an issue

Jenkins / JENKINS-41426

EC2- Keeps sending stop signal to a manually stopped instance

Change By: Adrien Lecharpentier

When using EC2 plugin to stop (not terminate) slave instances after a certain amount of idle time, if you stop manually one of those slaves before the stop signal is sent, you can see in the logs messages like the following one:

``` {noformat}

INFO h.p.ec2.EC2RetentionStrategy#internalCheck: Idle timeout of [XXX] after 82 idle minutes INFO h.plugins.ec2.EC2AbstractSlave#idleTimeout: EC2 instance idle time expired: [XXX-ID] INFO h.plugins.ec2.EC2AbstractSlave#stop: EC2 instance stop request sent for [XXX-ID]

``` {noformat}

The plugin keeps sending the stop signal even if the instance is already stopped. This message fill the logs. Any way to remove it?

Add Comment

This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

[adrien.lecharpentier@gmail.com (JIRA)]

[raihaan.shouhell@autodesk.com (JIRA)]

Raihaan Shouhell commented on JENKINS-41426

Re: EC2- Keeps sending stop signal to a manually stopped instance We now check for the current state and do nothing if already in the desired state

Add Comment

[raihaan.shouhell@autodesk.com (JIRA)]

Raihaan Shouhell closed an issue as Fixed

Jenkins / JENKINS-41426

EC2- Keeps sending stop signal to a manually stopped instance

Change By: Raihaan Shouhell Status: Open Closed Resolution: Fixed

Add Comment