[JIRA] (JENKINS-41391) skipDefaultCheckout should default parameter value to "true"

[bitwiseman@gmail.com (JIRA)]

Liam Newman created an issue

Jenkins / JENKINS-41391 skipDefaultCheckout should default parameter value to "true" Issue Type: Improvement Assignee: Andrew Bayer Components: pipeline-model-definition-plugin Created: 2017/Jan/24 8:10 PM Priority: Minor Reporter: Liam Newman The boolean parameter should be optional and default to true if not provided. https://github.com/jenkinsci/pipeline-model-definition-plugin/blob/01ba61a99d1f99bf82ba70d8c94d2d6c5e88714b/pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/options/impl/SkipDefaultCheckout.java#L37 options { skipDefaultCheckout() } Add Comment

This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer commented on JENKINS-41391

Re: skipDefaultCheckout should default parameter value to "true" There was some reason this was problematic, but right now I can't remember what it was. I'll give it a look.

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer commented on JENKINS-41391

Re: skipDefaultCheckout should default parameter value to "true"

PR up at https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/100

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer started work on JENKINS-41391

Change By: Andrew Bayer Status: Open In Progress

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer updated JENKINS-41391

Jenkins / JENKINS-41391

skipDefaultCheckout should default parameter value to "true"

Change By: Andrew Bayer Status: In Progress Review

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-41391

Re: skipDefaultCheckout should default parameter value to "true" Code changed in jenkins User: Andrew Bayer Path: pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/options/impl/SkipDefaultCheckout.java pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/OptionsTest.java pipeline-model-definition/src/test/resources/multipleProperties.groovy http://jenkins-ci.org/commit/pipeline-model-definition-plugin/a632cc6ab24f42498d3827af5db4abe017a0c0b0 Log: [FIXED JENKINS-41391] Switch skipDefaultCheckout to default true That is - make skipDefaultCheckout() work the same as skipDefaultCheckout(true).

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer updated JENKINS-41391

Jenkins / JENKINS-41391

skipDefaultCheckout should default parameter value to "true"

Change By: Andrew Bayer Status: In Review Resolved Resolution: Fixed

Add Comment

[bitwiseman@gmail.com (JIRA)]

Liam Newman closed an issue as Fixed

Bulk closing resolved issues.

Jenkins / JENKINS-41391 skipDefaultCheckout should default parameter value to "true"

Change By: Liam Newman Status: Resolved Closed

Add Comment

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)