[JIRA] (JENKINS-41336) Cron based jobs are triggered at random times and also at the time Stash is unavailable

[vivian.zhang@turn.com (JIRA)]

Vivian zhang created an issue

Jenkins / JENKINS-41336 Cron based jobs are triggered at random times and also at the time Stash is unavailable Issue Type: Bug Assignee: nathan m Components: stash-pullrequest-builder-plugin Created: 2017/Jan/23 6:20 PM Environment: Jenkins 2.7 stash-pullrequest-builder-plugin 1.7 Priority: Blocker Reporter: Vivian zhang The cron based jobs are working fine until stash-pullrequest-builder-plugin is installed and configured for one of our gating job. The frequency to run is every 2 min. Since then all the cron based jobs are not triggered at specified time, but rather at random time. They also get triggered every time Stash is unavailable, such as during its backup. Hence all cron based jobs failed. Add Comment

This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)

[gentoo.integer@gmail.com (JIRA)]

Kanstantsin Shautsou commented on JENKINS-41336

Re: Cron based jobs are triggered at random times and also at the time Stash is unavailable Description has nothing useful, during the problem catch /threadDump

Add Comment

[aheritier@apache.org (JIRA)]

Arnaud Héritier commented on JENKINS-41336

Re: Cron based jobs are triggered at random times and also at the time Stash is unavailable

Kanstantsin Shautsou the behavior is that all cron based jobs aren't executed when they are supposed to do it because Triggers are busy to interact with stash The thread is showing something like this (thanks Daniel Beck) at stashpullrequestbuilder.stashpullrequestbuilder.stash.StashApiClient.getRequest(StashApiClient.java:254) at stashpullrequestbuilder.stashpullrequestbuilder.stash.StashApiClient.getPullRequestMergeStatus(StashApiClient.java:150) at stashpullrequestbuilder.stashpullrequestbuilder.StashRepository.isPullRequestMergable(StashRepository.java:209) at stashpullrequestbuilder.stashpullrequestbuilder.StashRepository.isBuildTarget(StashRepository.java:261) at stashpullrequestbuilder.stashpullrequestbuilder.StashRepository.getTargetPullRequests(StashRepository.java:75) at stashpullrequestbuilder.stashpullrequestbuilder.StashPullRequestsBuilder.run(StashPullRequestsBuilder.java:32) at stashpullrequestbuilder.stashpullrequestbuilder.StashBuildTrigger.run(StashBuildTrigger.java:299) at hudson.triggers.Trigger.checkTriggers(Trigger.java:273) at hudson.triggers.Trigger$Cron.doRun(Trigger.java:222) Trigger.checkTriggers should only call tasks which are immediate. These ones could start in another thread a longer process to really trigger the job or not. Here the StashBuildTrigger.run does too much stuffs and is quickly blocked or creates a lot of delay if the Stash isn't available or doesn't reply quickly (which is never the case). This bug makes this plugin not usable and the only solution is to deactivate/uninstall it for now.

Add Comment

[gentoo.integer@gmail.com (JIRA)]

Kanstantsin Shautsou commented on JENKINS-41336

Re: Cron based jobs are triggered at random times and also at the time Stash is unavailable

Right or stop calling from cron if it has configured hooks, depends on plugin design.

Add Comment

[vivian.zhang@turn.com (JIRA)]

Vivian zhang commented on JENKINS-41336

Re: Cron based jobs are triggered at random times and also at the time Stash is unavailable

I'm surprised that the plugin requires cron to be set up for the job, which is very inefficient to go through all the open PRs every time. It should try to use the branch info provided by Stash post-commit hook instead.

Add Comment

[gentoo.integer@gmail.com (JIRA)]

Kanstantsin Shautsou commented on JENKINS-41336

Re: Cron based jobs are triggered at random times and also at the time Stash is unavailable

That's jenkins design - all Triggers inherit cron functionality, but it can be simply skipped.

Add Comment

[vivian.zhang@turn.com (JIRA)]

Vivian zhang commented on JENKINS-41336

Re: Cron based jobs are triggered at random times and also at the time Stash is unavailable

What I meant was this plugin should rely on Stash's post-commit webhook plugin for sending change notification to Jenkins, and trigger the build with poll scm option checked (no cron needed here). Looks like this place is to report Jenkins core bug, maybe I should file an issue report at the plugin's github site?

Add Comment

[gentoo.integer@gmail.com (JIRA)]

Kanstantsin Shautsou commented on JENKINS-41336

Re: Cron based jobs are triggered at random times and also at the time Stash is unavailable

And how it will work behind nat then?

Add Comment

[vivian.zhang@turn.com (JIRA)]

Vivian zhang commented on JENKINS-41336

Re: Cron based jobs are triggered at random times and also at the time Stash is unavailable

That's how it's been working without this plugin, although I still like some of the features provided by this plugin.

Add Comment

[larry.brigman@arris.com (JIRA)]

Larry Brigman commented on JENKINS-41336

Re: Cron based jobs are triggered at random times and also at the time Stash is unavailable

I'm seeing jobs queue when I get this error: Mar 23, 2017 4:43:00 PM stashpullrequestbuilder.stashpullrequestbuilder.StashRepository getTargetPullRequests INFO: Fetch PullRequests (ansible-checks). java.util.concurrent.ExecutionException: java.net.SocketTimeoutException: Read timed out at java.util.concurrent.FutureTask.report(FutureTask.java:122) at java.util.concurrent.FutureTask.get(FutureTask.java:202) at stashpullrequestbuilder.stashpullrequestbuilder.stash.StashApiClient.getRequest(StashApiClient.java:254) at stashpullrequestbuilder.stashpullrequestbuilder.stash.StashApiClient.getPullRequests(StashApiClient.java:86)   Using Jenkins 2.44 on Ubuntu 14.04 LTS OpenJDK 64bit Java 1.7.0_79 Stash Pull Request Builder 1.7 Against Stash/Bitbucket v4.4.1 The timeout is due to an issue on the bitbucket end but it shouldn't be causing a build to be queued.

Add Comment

This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)

[ivan.polonevich@gmail.com (JIRA)]

ivan palanevich commented on JENKINS-41336

Re: Cron based jobs are triggered at random times and also at the time Stash is unavailable

You can try to use that fix - https://github.com/kmoco2am/stash-pullrequest-builder-plugin/commit/da4ed53fb8f38f10df956175e7feda76f64f766e

Add Comment

This message was sent by Atlassian JIRA (v7.10.1#710002-sha1:6efc396)

[bochenski.kuba+jenkins@gmail.com (JIRA)]

Jakub Bochenski assigned an issue to Unassigned

Jenkins / JENKINS-41336

Cron based jobs are triggered at random times and also at the time Stash is unavailable

Change By: Jakub Bochenski Assignee: nathan m

Add Comment

This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

[bochenski.kuba+jenkins@gmail.com (JIRA)]

Jakub Bochenski commented on JENKINS-41336

Re: Cron based jobs are triggered at random times and also at the time Stash is unavailable So the issue here is that StashBuildTrigger.run runs for too long?

Add Comment

[bochenski.kuba+jenkins@gmail.com (JIRA)]

Jakub Bochenski closed an issue as Fixed

This issue has been closed because of inactivity. Please reopen it if you think it's still valid

Jenkins / JENKINS-41336

Cron based jobs are triggered at random times and also at the time Stash is unavailable

Change By: Jakub Bochenski Status: Open Closed Resolution: Fixed

Add Comment

[luis.ehlen@gmail.com (JIRA)]

Luis Ehlen commented on JENKINS-41336

Re: Cron based jobs are triggered at random times and also at the time Stash is unavailable I just updated to the latest Jenkins LTS 2.204.2 and the latest version of the stash pull request builder plugin 1,17 (from 1.8) and the mentioned behavior with the cron based jobs appeared. I can see this on my logs:   Feb 19, 2020 12:25:29 PM WARNING hudson.triggers.Trigger checkTriggersTrigger stashpullrequestbuilder.stashpullrequestbuilder.StashBuildTrigger.run() triggered by hudson.maven.MavenModuleSet@45177041[JOB_NAME] spent too much time (54 sec) in its execution, other timers can be affected

Add Comment

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)

[luis.ehlen@gmail.com (JIRA)]

Luis Ehlen reopened an issue

Jenkins / JENKINS-41336

Cron based jobs are triggered at random times and also at the time Stash is unavailable

Change By: Luis Ehlen Resolution: Fixed Status: Closed Reopened

Add Comment