[JIRA] (JENKINS-39799) Nasty compilation failure when post doesn't contain name/closure blocks

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer updated an issue

Jenkins / JENKINS-39799 Nasty compilation failure when post doesn't contain name/closure blocks Change By: Andrew Bayer Summary: Nasty compilation failure when invalid build condition names used post doesn't contain name/closure blocks Add Comment

This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer updated JENKINS-39799

Jenkins / JENKINS-39799 Nasty compilation failure when post doesn't contain name/closure blocks

Change By: Andrew Bayer Status: In Progress Review

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer commented on JENKINS-39799

Re: Nasty compilation failure when post doesn't contain name/closure blocks PR up at https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/56

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-39799

Re: Nasty compilation failure when post doesn't contain name/closure blocks

Code changed in jenkins User: Andrew Bayer Path: pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/parser/ModelParser.groovy pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/validator/ModelValidatorImpl.groovy pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/ValidatorTest.java pipeline-model-definition/src/test/resources/errors/badPostContent.groovy http://jenkins-ci.org/commit/pipeline-model-definition-plugin/bfc38f958d33fa9115fa1d357504f58a8174ec10 Log: [FIXED JENKINS-39799] Properly handle bad content in post blocks. We actually would have errored out properly-ish if it wasn't for the fact that we ended up with a ModelASTBuildCondition with null condition and null branch, leading to the NPE during compilation. I decided to improve the error messaging and make sure we don't attempt to validate further when condition or branch are null.

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer updated JENKINS-39799

Jenkins / JENKINS-39799

Nasty compilation failure when post doesn't contain name/closure blocks

Change By: Andrew Bayer Status: In Review Resolved Resolution: Fixed

Add Comment

[bitwiseman@gmail.com (JIRA)]

Liam Newman closed an issue as Fixed

Bulk closing resolved issues.

Jenkins / JENKINS-39799 Nasty compilation failure when post doesn't contain name/closure blocks

Change By: Liam Newman Status: Resolved Closed

Add Comment

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)