[JIRA] (JENKINS-39684) Use docker images from private registry

Use docker images from private registry

Issue Type:	Story
Assignee:	Andrew Bayer
Components:	pipeline-model-definition-plugin
Created:	2016/Nov/11 9:51 PM
Priority:	Minor
Reporter:	Patrick Wolf

When using an agent directive in Declarative Pipeline there is no way to specify the Docker Registry to use. In Scripted Pipline this is available via the withRegistry wrapper

 
                                                                docker.withRegistry('https://docker.mycorp.com/', 'docker-login') {
  git '…'
  docker.build('myapp').push('latest')
}

For Declarative we should allow admins to create a default registry to be used by all Pipelines at the master level or the folder level. We should also allow a specific registry setting in the language itself via the agent directive.

This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)

pwolf@cloudbees.com (JIRA)

unread,

Nov 11, 2016, 4:54:01 PM11/11/16

to jenkinsc...@googlegroups.com

Patrick Wolf commented on

Michael Neale James Dumay

Do you guys have any suggestions for the syntax?

mneale@cloudbees.com (JIRA)

unread,

Nov 14, 2016, 5:29:01 PM11/14/16

to jenkinsc...@googlegroups.com

Michael Neale commented on

Patrick Wolf Andrew Bayer I think the agent syntax was made flexible enough to cater for this.

agent docker:"foo" registry:

{... config for registry}

would something like that work? or the docker item take a block in that case with all the config needed? (Andrew would be able to comment on what is best)

andrew.bayer@gmail.com (JIRA)

unread,

Nov 16, 2016, 12:59:02 PM11/16/16

to jenkinsc...@googlegroups.com

Andrew Bayer commented on

Hrm. I don't like the idea of mixing closures with string values in the agent config. That ship has already sailed, I think. I'll play around with it, but I don't think it'll work well. Most likely, we'll need straight key/value pairings.

andrew.bayer@gmail.com (JIRA)

unread,

Nov 16, 2016, 1:01:02 PM11/16/16

to jenkinsc...@googlegroups.com

Andrew Bayer commented on

Ok, turns out it's technically possible, but I'm really unsure about the syntactic feel.

andrew.bayer@gmail.com (JIRA)

unread,

Nov 16, 2016, 1:45:02 PM11/16/16

to jenkinsc...@googlegroups.com

Andrew Bayer commented on

I tell a lie - there's no viable way to fit non-String agent values into the AST. Grr.

andrew.bayer@gmail.com (JIRA)

unread,

Nov 16, 2016, 1:48:01 PM11/16/16

to jenkinsc...@googlegroups.com

Andrew Bayer edited a comment on

I tell a lie - there's no viable way to fit non- closure {{ String}} {{ agent}} values into the AST. Grr. We *could* do maps, though. So I'd lean towards this syntax:

{code}
agent docker:'foo', registry:[url:'http://...', username:'...', password:'...']
{code}

Still need to think how we'd fit credentials into that, though.

mneale@cloudbees.com (JIRA)

unread,

Nov 16, 2016, 8:13:01 PM11/16/16

to jenkinsc...@googlegroups.com

Michael Neale commented on

that looks reasonable. I am not aware how registry works today with withCredentials, but perhaps its a matter of takign a credentialId as an option?

p.leibiger@codecraft.de (JIRA)

unread,

Dec 19, 2016, 6:34:02 AM12/19/16

to jenkinsc...@googlegroups.com

Peter Leibiger commented on

Current syntax looks like this withDockerRegistry([credentialsId: 'foo', url: 'https://docker.foo.com']).
Tried to add it as wrapper but obviously that didn't work out.

p.leibiger@codecraft.de (JIRA)

unread,

Dec 19, 2016, 6:38:01 AM12/19/16

to jenkinsc...@googlegroups.com

Peter Leibiger commented on

Maybe the agent syntax always needs to be a closure, away from strings.
In the future there might be a lot of parameters for different kinds of agents.

mneale@cloudbees.com (JIRA)

unread,

Dec 20, 2016, 2:21:01 AM12/20/16

to jenkinsc...@googlegroups.com

Michael Neale commented on

Peter Leibiger I know Andrew Bayer was looking at making the agent syntax more extensible: https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/73 - so perhaps that is the place to add in registry support?

p.leibiger@codecraft.de (JIRA)

unread,

Dec 20, 2016, 6:03:01 AM12/20/16

to jenkinsc...@googlegroups.com

Peter Leibiger commented on

Michael Neale I already commented on that PR regarding this issue: https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/73#issuecomment-267946020

andrew.bayer@gmail.com (JIRA)

unread,

Jan 7, 2017, 7:14:02 PM1/7/17

to jenkinsc...@googlegroups.com

Andrew Bayer updated

Jenkins /

Use docker images from private registry

Change By:	Andrew Bayer
Status:	In Progress Review

andrew.bayer@gmail.com (JIRA)

unread,

Jan 7, 2017, 7:14:02 PM1/7/17

to jenkinsc...@googlegroups.com

Andrew Bayer started work on

Change By:	Andrew Bayer
Status:	Open In Progress

andrew.bayer@gmail.com (JIRA)

unread,

Jan 7, 2017, 7:14:03 PM1/7/17

to jenkinsc...@googlegroups.com

Andrew Bayer commented on

Preliminary PR up at https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/86

p.leibiger@codecraft.de (JIRA)

unread,

Jan 9, 2017, 6:19:01 AM1/9/17

to jenkinsc...@googlegroups.com

Peter Leibiger commented on

I can probably test this sometime this week.

scm_issue_link@java.net (JIRA)

unread,

Jan 19, 2017, 5:47:03 PM1/19/17

to jenkinsc...@googlegroups.com

SCM/JIRA link daemon commented on