[JIRA] (JENKINS-39342) Make the promoted-builds-plugin DSL extension for job-dsl-plugin extensible: Automatically Generated DSL

5 views
Skip to first unread message

frederic.chuong@gmail.com (JIRA)

unread,
Oct 28, 2016, 2:13:01 AM10/28/16
to jenkinsc...@googlegroups.com
Frédéric Chuong created an issue
 
Jenkins / Improvement JENKINS-39342
Make the promoted-builds-plugin DSL extension for job-dsl-plugin extensible: Automatically Generated DSL
Issue Type: Improvement Improvement
Assignee: Daniel Spilker
Components: job-dsl-plugin, promoted-builds-plugin
Created: 2016/Oct/28 6:12 AM
Environment: job-dsl-plugin 1.46
promoted-builds-plugin 2.27
Labels: job-dsl-plugin promoted-builds
Priority: Minor Minor
Reporter: Frédéric Chuong

The current DSL extension is static and needs to be modified/improved whenever a new feature is added to promoted-builds-plugin.
By the extensible nature of this plugin (it provides the PromotionCondition ExtensionPoint for third parties to implement), this makes the DSL extension requirement to be dynamic depending on available plugins ; this doesn't scale well with the current static DSL extension.
job-dsl-plugin 1.46 introduced the Automatically Generated DSL feature to address this issue on job-dsl-plugin itself by the use of javaposse.jobdsl.dsl.ExtensibleContext / javaposse.jobdsl.dsl.ContextType at the DSL level (model introspection done by helpers such as javaposse.jobdsl.plugin.structs.DescribableContext).

The promoted-builds-plugin DSL extension should make use of those DSL authoring tool to automatically discover available PromotionCondition.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
Atlassian logo

frederic.chuong@gmail.com (JIRA)

unread,
Oct 28, 2016, 2:20:01 AM10/28/16
to jenkinsc...@googlegroups.com

frederic.chuong@gmail.com (JIRA)

unread,
Oct 28, 2016, 2:21:02 AM10/28/16
to jenkinsc...@googlegroups.com

aferguson@ea.com (JIRA)

unread,
Jan 16, 2017, 8:16:01 PM1/16/17
to jenkinsc...@googlegroups.com
Andrew Ferguson commented on Improvement JENKINS-39342
 
Re: Make the promoted-builds-plugin DSL extension for job-dsl-plugin extensible: Automatically Generated DSL

I'd really love to see this; The inability to use publishers in promoted plugin DSL is causing headaches left and right for my team :/

o.v.nenashev@gmail.com (JIRA)

unread,
Jun 1, 2019, 6:32:04 AM6/1/19
to jenkinsc...@googlegroups.com

There was an attempt to land it in https://github.com/jenkinsci/promoted-builds-plugin/pull/96 , but it has not been finished. Anyone interested in JobDSL integration, you are welcome to adopt and recover this pull request or to suggest your own implementation.

This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

o.v.nenashev@gmail.com (JIRA)

unread,
Jun 1, 2019, 6:33:02 AM6/1/19
to jenkinsc...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages