[JIRA] (JENKINS-38285) Add extension point for declarative config sections

1 view
Skip to first unread message

andrew.bayer@gmail.com (JIRA)

unread,
Sep 16, 2016, 1:45:01 PM9/16/16
to jenkinsc...@googlegroups.com
Andrew Bayer created an issue
 
Jenkins / Story JENKINS-38285
Add extension point for declarative config sections
Issue Type: Story Story
Assignee: Andrew Bayer
Components: pipeline-model-definition-plugin
Created: 2016/Sep/16 5:44 PM
Priority: Minor Minor
Reporter: Andrew Bayer

The top-level config sections in Declarative Pipelines are currently hardcoded in the plugin. We need to make them an ExtensionPoint instead. =)

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
Atlassian logo

andrew.bayer@gmail.com (JIRA)

unread,
Sep 23, 2016, 4:58:01 PM9/23/16
to jenkinsc...@googlegroups.com
Andrew Bayer commented on Story JENKINS-38285
 
Re: Add extension point for declarative config sections

So this may not actually be viable for a few reasons:

  • Need to know when to execute whatever script the config section contributes - i.e., how do we know "Ok, run this snippet of code for the postBuild section after stages are done and before we leave the potential node block that stages are run in"? This is the biggie that I just can't figure out an answer to.
  • Adding validation support via moving the methods in ModelValidator to the ModelASTElement extension in question is doable enough, but not ideal.
  • Along the same lines, contributing to the JSON schema (or more accurately, generating the JSON schema dynamically from information provided by the various config sections) is probably doable but a bit ugly conceptually.
  • ModelParser and JSONParser, on the other hand, would need complete rewrites. I'm not sure how we'd do that yet, but given the "when to execute" problem, I don't think it's worth it for me to invest much thought on this in particular yet.

andrew.bayer@gmail.com (JIRA)

unread,
Oct 25, 2016, 11:18:02 AM10/25/16
to jenkinsc...@googlegroups.com
Andrew Bayer resolved as Won't Fix
 

So I couldn't find a viable way to do this, sadly.

Change By: Andrew Bayer
Status: Open Resolved
Resolution: Won't Fix

bitwiseman@gmail.com (JIRA)

unread,
Oct 22, 2019, 11:25:53 PM10/22/19
to jenkinsc...@googlegroups.com
Liam Newman closed an issue as Won't Fix
 

Bulk closing resolved issues.

Change By: Liam Newman
Status: Resolved Closed
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages