[JIRA] (JENKINS-37862) Extract build symlink handling to a plugin

0 views
Skip to first unread message

jglick@cloudbees.com (JIRA)

unread,
Aug 31, 2016, 1:15:01 PM8/31/16
to jenkinsc...@googlegroups.com
Jesse Glick created an issue
 
Jenkins / Task JENKINS-37862
Extract build symlink handling to a plugin
Issue Type: Task Task
Assignee: Unassigned
Components: core
Created: 2016/Aug/31 5:14 PM
Labels: symlink split-plugins-from-core robustness windows
Priority: Major Major
Reporter: Jesse Glick

There are many bugs and limitations which arise mainly on Windows related to use of symbolic links for build directories (Run.createSymlink for lastSuccessful -> builds/lastSuccessfulBuild, and PeepholdPermalink.writeSymlink for builds/lastSuccessfulBuild -> 99).

Under the assumption that few users even know about, let alone care about, the longstanding Jenkins feature of allowing you to refer to, say, a particular artifact from the last stable build of a job using a fixed file path on the master node (for use from external systems), I think it is reasonable to split this out into a plugin for the tiny set of people who need it, and not bother everyone else with these bugs.

PeepholePermalink.resolve does use symlinks as a kind of cache, useful for example to avoid massive build loading when resolving lastFailedBuild when the past several hundred builds in fact succeeded. But perhaps this can be done in some other way, like a simple $JENKINS_HOME/jobs/$job/permalinks.properties. That would anyway result in better performance for those Windows users who cannot create symlinks.

(Even Unix users are occasionally hit by problems when they use, e.g., cp -r to back up $JENKINS_HOME. IIRC it is a filed bug that this results in cryptic exceptions.)

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
Atlassian logo

pibeitz@gmail.com (JIRA)

unread,
Apr 11, 2019, 9:23:02 AM4/11/19
to jenkinsc...@googlegroups.com
Pierre Beitz commented on Task JENKINS-37862
 
Re: Extract build symlink handling to a plugin

Jesse Glick I like this idea (and also I need it to fix symlink issues of the shelve plugin once and for all). I'm happy to start working on it, but cannot commit to any timeline. Would this be ok for you or do you intend to tackle it soon?

This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

jglick@cloudbees.com (JIRA)

unread,
Apr 12, 2019, 3:23:02 PM4/12/19
to jenkinsc...@googlegroups.com
Jesse Glick assigned an issue to Jesse Glick
 

I will give it a shot.

Change By: Jesse Glick
Assignee: Jesse Glick

jglick@cloudbees.com (JIRA)

unread,
Apr 12, 2019, 3:24:04 PM4/12/19
to jenkinsc...@googlegroups.com
Jesse Glick started work on Task JENKINS-37862
 
Change By: Jesse Glick
Status: Open In Progress

jglick@cloudbees.com (JIRA)

unread,
Apr 13, 2019, 12:43:02 PM4/13/19
to jenkinsc...@googlegroups.com

jglick@cloudbees.com (JIRA)

unread,
Jul 11, 2019, 3:09:03 PM7/11/19
to jenkinsc...@googlegroups.com
Change By: Jesse Glick
Status: In Review Fixed but Unreleased
Resolution: Fixed
Released As: 2.185

o.v.nenashev@gmail.com (JIRA)

unread,
Jul 15, 2019, 6:27:07 AM7/15/19
to jenkinsc...@googlegroups.com

merten.schumann@asg.com (JIRA)

unread,
Aug 6, 2019, 3:10:02 AM8/6/19
to jenkinsc...@googlegroups.com

> allowing you to refer to, say, a particular artifact from the last stable build of a job using a fixed file path on the master node

 

we do use exactly this to refer build results of build jobs from test jobs ... I think we had no wget at time of creating such jobs  - well, so I'll (have to) give the Build Symlink plugin a try, when these changes appear in the LTS release ... thanx for not just removing this feature

no one else relying on good old symlinks in the Jenkins filesystem?

jglick@cloudbees.com (JIRA)

unread,
Aug 6, 2019, 1:19:02 PM8/6/19
to jenkinsc...@googlegroups.com

refer build results of build jobs from test jobs ... I think we had no wget at time of creating such jobs

The usual way of doing this is with the Copy Artifact plugin.

merten.schumann@asg.com (JIRA)

unread,
Aug 7, 2019, 1:46:05 AM8/7/19
to jenkinsc...@googlegroups.com

... Copy Artifact plugin, one approach, sure
we've got (the same) scripts running in Hud aeh Jenkins + in other environments - Ux shell or Cygwin - and then it's good not to say required to have the same preconditions, I mean, just copy command instead of a plugin available in Jenkins environment "only" ...

I've got a question: so when I upgrade Jenkins to a newer release with this behavior for new builds no symlinks will be created (as long as the Build Symlink plugin is not installed/active) - what about existing builds? Will Jenkins remove all the symlinks from existing builds after the upgrade? Hopefully only when the "Manage Old Data" action is invoked ...

jglick@cloudbees.com (JIRA)

unread,
Aug 7, 2019, 3:06:02 PM8/7/19
to jenkinsc...@googlegroups.com

Will Jenkins remove all the symlinks from existing builds after the upgrade?

No. See release notes for a script to do this manually if you care.

merten.schumann@asg.com (JIRA)

unread,
Aug 8, 2019, 2:41:02 AM8/8/19
to jenkinsc...@googlegroups.com

good ... Thanx alot for your feedback, Jesse Glick.
Merten

merten.schumann@asg.com (JIRA)

unread,
Oct 10, 2019, 4:21:33 AM10/10/19
to jenkinsc...@googlegroups.com

just updated our Jenkins to 2.190.1 - made test builds, Build Symlinks plugin enabled and disabled - thanx to the plugin the symlinks are still there, thanx alot again

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages