[JIRA] (JENKINS-37809) Throttling based on parameters does not work in Pipelines

[alunsford@webassign.net (JIRA)]

Aaron Lunsford created an issue

Jenkins / JENKINS-37809 Throttling based on parameters does not work in Pipelines Issue Type: Bug Assignee: Oleg Nenashev Attachments: Screen Shot 2016-08-29 at 5.05.27 PM.png Components: throttle-concurrent-builds-plugin Created: 2016/Aug/30 1:05 PM Priority: Major Reporter: Aaron Lunsford Configuration Pipeline job with parameters Execute concurrent builds if necessary: true Throttle Concurrent Builds: true Prevent multiple jobs with identical parameters from running concurrently: true Notes - Job parameters are defined as part of the pipeline setup with the properties command Problem When throttling based on one of the job's parameters, the plugin does not prevent multiple builds from running concurrently when the defined parameter is the same. Add Comment

This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)

[alunsford@webassign.net (JIRA)]

Aaron Lunsford updated an issue

Jenkins / JENKINS-37809 Throttling based on parameters does not work in Pipelines

Change By: Aaron Lunsford h3. Configuration # Pipeline job with parameters # Execute concurrent builds if necessary: true # Throttle Concurrent Builds: true # Prevent multiple jobs with identical parameters from running concurrently: true h3. Notes

- Job parameters are defined as part of the pipeline setup with the {{properties}} command

h3. Problem

When throttling based on one of the job's parameters, the plugin does not prevent multiple builds from running concurrently when the defined parameter is the same.

Add Comment

[alunsford@webassign.net (JIRA)]

Aaron Lunsford commented on JENKINS-37809

Re: Throttling based on parameters does not work in Pipelines I did some more digging on the issue and it looks like problem is in the getParametersFromWorkUnit() method. On Freestyle jobs, the conditional that checks unit.context.actions gets populated with values, but for Pipeline jobs it does not. The WorkUnit object that is passed to getParametersFromWorkUnit() for a normal job looks like this: hudson.model.queue.WorkUnit@53acb86e[work=Working], where "Working" is the name of the job. For Pipeline jobs, it looks like hudson.model.queue.WorkUnit@496091d7work=part of Throttle-this #11, where "Throttle-this" is the name of the job and "#11" is the build number. To try and summarize: Freestyle jobs where the plugin works: WorkUnit object: hudson.model.queue.WorkUnit@53acb86e[work=Working] WorkUnit.context: hudson.model.queue.WorkUnitContext@14401e37 WorkUnit.context.actions: [hudson.model.ParametersAction@7e92e075, hudson.model.CauseAction@1d3d3d46] Pipeline jobs where the plugin does not work: WorkUnit object: hudson.model.queue.WorkUnit@496091d7work=part of Throttle-this #11 WorkUnit.context: hudson.model.queue.WorkUnitContext@47a7768b WorkUnit.context.actions: []

Add Comment

[alunsford@webassign.net (JIRA)]

Aaron Lunsford edited a comment on JENKINS-37809

Re: Throttling based on parameters does not work in Pipelines

I did some more digging on the issue and it looks like problem is in the {{getParametersFromWorkUnit()}} method. On Freestyle jobs, the conditional that checks {{unit.context.actions}} gets populated with values, but for Pipeline jobs it does not.

The {{WorkUnit}} object that is passed to {{getParametersFromWorkUnit()}} for a normal job looks like this: {{hudson.model.queue.WorkUnit@53acb86e[work=Working]}}, where "Working" is the name of the job. For Pipeline jobs, it looks like {{hudson.model.queue.WorkUnit@496091d7[work=part of Throttle-this #11]}}, where "Throttle-this" is the name of the job and "#11" is the build number.

To try and summarize: Freestyle jobs where the plugin works:

{noformat} - WorkUnit object: {{ hudson.model.queue.WorkUnit@53acb86e[work=Working] }} - WorkUnit.context: {{ hudson.model.queue.WorkUnitContext@14401e37 }} - WorkUnit.context.actions: {{ [hudson.model.ParametersAction@7e92e075, hudson.model.CauseAction@1d3d3d46] {noformat } }

Pipeline jobs where the plugin does not work:

{noformat} - WorkUnit object: {{ hudson.model.queue.WorkUnit@496091d7[work=part of Throttle-this #11] }} - WorkUnit.context: {{ hudson.model.queue.WorkUnitContext@47a7768b }} - WorkUnit.context.actions: {{ [] {noformat } }

Add Comment

[alunsford@webassign.net (JIRA)]

Aaron Lunsford updated an issue

Jenkins / JENKINS-37809

Throttling based on parameters does not work in Pipelines

Change By: Aaron Lunsford

h3. Configuration # Pipeline job with parameters # Execute concurrent builds if necessary: true # Throttle Concurrent Builds: true # Prevent multiple jobs with identical parameters from running concurrently: true h3. Notes - Job parameters are defined as part of the pipeline setup with the {{properties}} command

- This is also an issue when properties are not defined as part of the pipeline setup, and are configured through the UI directly

h3. Problem When throttling based on one of the job's parameters, the plugin does not prevent multiple builds from running concurrently when the defined parameter is the same.

Add Comment

[alunsford@webassign.net (JIRA)]

Aaron Lunsford edited a comment on JENKINS-37809

Re: Throttling based on parameters does not work in Pipelines

I did some more digging on the issue and it looks like problem is in the {{getParametersFromWorkUnit()}} method. On Freestyle jobs, the conditional that checks {{unit.context.actions}} gets populated with values, but for Pipeline jobs it does not.

The {{WorkUnit}} object that is passed to {{getParametersFromWorkUnit()}} for a normal job looks like this: { { noformat} hudson.model.queue.WorkUnit@53acb86e[work=Working] {noformat } } , where "Working" is the name of the job. For Pipeline jobs, it looks like { { noformat} hudson.model.queue.WorkUnit@496091d7[work=part of Throttle-this #11] {noformat } } , where "Throttle-this" is the name of the job and "#11" is the build number.

To try and summarize: Freestyle jobs where the plugin works: {noformat} - WorkUnit object: hudson.model.queue.WorkUnit@53acb86e[work=Working] - WorkUnit.context: hudson.model.queue.WorkUnitContext@14401e37 - WorkUnit.context.actions: [hudson.model.ParametersAction@7e92e075, hudson.model.CauseAction@1d3d3d46] {noformat} Pipeline jobs where the plugin does not work: {noformat} - WorkUnit object: hudson.model.queue.WorkUnit@496091d7[work=part of Throttle-this #11] - WorkUnit.context: hudson.model.queue.WorkUnitContext@47a7768b - WorkUnit.context.actions: [] {noformat}

Add Comment

[jglick@cloudbees.com (JIRA)]

Jesse Glick updated an issue

Jenkins / JENKINS-37809

Throttling based on parameters does not work in Pipelines

Change By: Jesse Glick Labels: pipeline

Add Comment

[o.v.nenashev@gmail.com (JIRA)]

Oleg Nenashev updated an issue

Jenkins / JENKINS-37809

Throttling based on parameters does not work in Pipelines

Change By: Oleg Nenashev Issue Type: Bug New Feature

Add Comment

[o.v.nenashev@gmail.com (JIRA)]

Oleg Nenashev commented on JENKINS-37809

Re: Throttling based on parameters does not work in Pipelines TCB plugin is not integrated with Pipeline, so it is a New Feature.

Add Comment

[o.v.nenashev@gmail.com (JIRA)]

Oleg Nenashev resolved as Duplicate

Closing as a duplicate of JENKINS-31801

Jenkins / JENKINS-37809

Throttling based on parameters does not work in Pipelines

Change By: Oleg Nenashev Status: Open Resolved Resolution: Duplicate

Add Comment

[HemangLavana@java.net (JIRA)]

HemangLavana commented on JENKINS-37809

Re: Throttling based on parameters does not work in Pipelines Are you sure, it is duplicate: when I looked at JENKINS-31801, it seems to be about supporting throttle feature within the pipeline. Whereas if you look at the screenshot attached to this issue, it is about using TCB and pipeline like any other normal job. And this specific issue is that the feature in TCB plugin "to throttle based on job parameters" for pipeline jobs does not work whereas it works for normal jobs.

Add Comment

[o.v.nenashev@gmail.com (JIRA)]

Oleg Nenashev commented on JENKINS-37809

Re: Throttling based on parameters does not work in Pipelines

HemangLavana I am sure. TCB plugin is not integrated with Pipeline, which is explicitly mentioned in https://github.com/jenkinsci/pipeline-plugin/blob/master/COMPATIBILITY.md . It means that any TCB plugin logic may work incorrectly with Pipeline.

Add Comment

[HemangLavana@java.net (JIRA)]

HemangLavana commented on JENKINS-37809

Re: Throttling based on parameters does not work in Pipelines

thx for clarifying

Add Comment

[clauto@gmail.com (JIRA)]

Leeam Dagan commented on JENKINS-37809

Re: Throttling based on parameters does not work in Pipelines

Oleg Nenashev Can this bug be reopened now? Pipeline support of TCB was added in 2.0 and 2.01 However parameter based throttling was not added, or does this instead need to be a new feature request? I am leaning towards bug because there exists no way to do parameter throttling unless using freestyle, but as referenced here https://github.com/jenkinsci/pipeline-plugin/blob/master/COMPATIBILITY.md TCB has indeed been added to pipeline support.

Add Comment

This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

[clauto@gmail.com (JIRA)]

Leeam Dagan reopened an issue

Jenkins / JENKINS-37809

Throttling based on parameters does not work in Pipelines

Change By: Leeam Dagan Resolution: Duplicate Status: Resolved Reopened

Add Comment

[vinus079@gmail.com (JIRA)]

Vinay Somashekar updated an issue

Jenkins / JENKINS-37809

Throttling based on parameters does not work in Pipelines

Change By: Vinay Somashekar Issue Type: New Feature Bug

Add Comment

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)

[vinus079@gmail.com (JIRA)]

Vinay Somashekar commented on JENKINS-37809

Re: Throttling based on parameters does not work in Pipelines Oleg Nenashev, Could you please look at this one? Now, this should be a bug and not Feature.

Add Comment

[yeluolei@gmail.com (JIRA)]

Rurui Ye commented on JENKINS-37809

Re: Throttling based on parameters does not work in Pipelines

any update on this? I saw it was linked to the workUnitContext issue

Add Comment

[dan666@gmail.com (JIRA)]

Danny Gueta commented on JENKINS-37809

Re: Throttling based on parameters does not work in Pipelines

+1, any update on this ? we've used this plugin in the past but once we moved to pipelines its not working anymore, can't limit by parameters.

Add Comment

[nightfader@gmail.com (JIRA)]

Sherabi GuessWhat commented on JENKINS-37809

Re: Throttling based on parameters does not work in Pipelines

We are having the same issue. 1. Uncheck "Do not allow concurrent builds" 2. Check "Throttle concurrent builds"      -> Check "Prevent multiple jobs with identical parameters from running concurrently" Below is Pipeline as code for the above steps: // disableConcurrentBuilds(), --> Note concurrency is enabled since this line is commented out. {{ [$class: 'ThrottleJobProperty', categories: [], limitOneJobWithMatchingParams: true, maxConcurrentPerNode: 0, maxConcurrentTotal: 0, paramsToUseForLimit: '', throttleEnabled: true, throttleOption: 'project'],}}

Add Comment

[nightfader@gmail.com (JIRA)]

Sherabi GuessWhat edited a comment on JENKINS-37809

Re: Throttling based on parameters does not work in Pipelines

We are having the same issue. 1. Uncheck "Do not allow concurrent builds" 2. Check "Throttle concurrent builds"      -> Check "Prevent multiple jobs with identical parameters from running concurrently" Below is Pipeline as code for the above steps: {{// disableConcurrentBuilds(), --> Note concurrency is enabled since this line is commented out.}}

{{ [$class: 'ThrottleJobProperty', categories: [], {color:# FF0000 ff0000 }limitOneJobWithMatchingParams: true{color}, maxConcurrentPerNode: 0, maxConcurrentTotal: 0, paramsToUseForLimit: '', {color:# FF0000 ff0000 }throttleEnabled: true{color}, throttleOption: 'project'] ,}}

Add Comment

[nightfader@gmail.com (JIRA)]

Sherabi GuessWhat edited a comment on JENKINS-37809

Re: Throttling based on parameters does not work in Pipelines

We are having the same issue. 1. Uncheck "Do not allow concurrent builds" 2. Check "Throttle concurrent builds"      -> Check "Prevent multiple jobs with identical parameters from running concurrently" Below is Pipeline as code for the above steps: {{ {{ // disableConcurrentBuilds(), --> Note concurrency is enabled since this line is commented out.}} }}

{{ [$class: 'ThrottleJobProperty', categories: [], {color:#ff0000}limitOneJobWithMatchingParams: true{color}, maxConcurrentPerNode: 0, maxConcurrentTotal: 0, paramsToUseForLimit: '', {color:#ff0000}throttleEnabled: true{color}, throttleOption: 'project'] }}

Add Comment

[nightfader@gmail.com (JIRA)]

[fbladilo@redhat.com (JIRA)]

Franco Bladilo updated JENKINS-37809

Jenkins / JENKINS-37809

Throttling based on parameters does not work in Pipelines

Change By: Franco Bladilo Status: Reopened Open

Add Comment

This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)

[fbladilo@redhat.com (JIRA)]

Franco Bladilo commented on JENKINS-37809

Re: Throttling based on parameters does not work in Pipelines Having the same issues not being able to throttle pipeline jobs based on parameters, has this received any attention/help/updates? This is causing a lot of pain on our internal CI. Running Jenkins jenkins-2.222.1 with latest TCB.

Add Comment