[JIRA] (JENKINS-37778) Pipeline Config: Getting env vars from Credentials

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer created an issue

Jenkins / JENKINS-37778 Pipeline Config: Getting env vars from Credentials Issue Type: Story Assignee: Andrew Bayer Components: pipeline-config-plugin Created: 2016/Aug/29 6:45 PM Priority: Minor Reporter: Andrew Bayer What would be nice and idiomatic is to be able to something like: environment { AWS_ACCESS_KEY_ID = credentials(id='amazonKeyId') AWS_ACESS_KEY_SECRET = credentials(id='passwordId') } (or something more configgy looking). This can be limited to the single secret case if needed (ie not username/password). Using various incarnations of the wrapper: withCredentials([[$class: 'UsernamePasswordMultiBinding', credentialsId: '', passwordVariable: 'AWS_SECRET', usernameVariable: 'AWS_ID']]) { // some block } You can, I think get credentials back out but it is seems less configgy for common scenarious. Add Comment

This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer updated an issue

Jenkins / JENKINS-37778 Pipeline Config: Getting env vars from Credentials

Change By: Andrew Bayer Environment: Pipeline Config 0.1

Add Comment

[andrew.bayer@gmail.com (JIRA)]

Andrew Bayer commented on JENKINS-37778

Re: Pipeline Config: Getting env vars from Credentials So I'm wondering if it might actually make more sense to do a separate credentials section rather than combining with the environment section...need to think on this.

Add Comment

[rsandell@cloudbees.com (JIRA)]

rsandell started work on JENKINS-37778

Change By: rsandell Status: Open In Progress

Add Comment

[rsandell@cloudbees.com (JIRA)]

rsandell assigned an issue to rsandell

Jenkins / JENKINS-37778

Pipeline Config: Getting env vars from Credentials

Change By: rsandell Assignee: Andrew Bayer rsandell

Add Comment

[mneale@cloudbees.com (JIRA)]

Michael Neale commented on JENKINS-37778

Re: Pipeline Config: Getting env vars from Credentials Andrew Bayer given most tools outside of the java ecosystem, that one may call from a 'sh' step would use environment variables, I think it still makes sense to make it explicit what they are (those that don't use IAM or some out of band security service or device of course).

Add Comment

[mneale@cloudbees.com (JIRA)]

Michael Neale edited a comment on JENKINS-37778

Re: Pipeline Config: Getting env vars from Credentials

[~abayer] given most tools outside of the java ecosystem , that one may call could use from a 'sh' step would use environment variables, I think it still makes sense to make it explicit what they are (those that don't use IAM or some out of band security service or device of course).

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-37778

Re: Pipeline Config: Getting env vars from Credentials

Code changed in jenkins User: Robert Sandell Path: pipeline-model-definition/pom.xml pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/model/Root.groovy pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/model/Stage.groovy pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/model/CredentialsBindingHandler.java pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/steps/CredentialWrapper.java pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/steps/CredentialWrapperStep.java pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/ModelInterpreter.groovy pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/steps/CredentialWrapperStep/config.groovy pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/steps/CredentialWrapperStep/help.html pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/AbstractModelDefTest.java pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/steps/CredentialWrapperStepTest.java pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/util/HasArchived.java pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/util/InputStreamContainingString.java pipeline-model-definition/src/test/resources/credentials/usernamePassword.groovy http://jenkins-ci.org/commit/pipeline-model-definition-plugin/5346000747953975d22b2b09a8a5d44328ca9a3b Log: JENKINS-37778 Support credentials in environment Compare: https://github.com/jenkinsci/pipeline-model-definition-plugin/compare/6e953c4ed1e2^...534600074795

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-37778

Re: Pipeline Config: Getting env vars from Credentials

Code changed in jenkins User: Robert Sandell Path:

pipeline-model-api/pom.xml pipeline-model-declarative-agent/pom.xml pipeline-model-definition/pom.xml pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/parser/ModelParser.groovy pom.xml http://jenkins-ci.org/commit/pipeline-model-definition-plugin/df39786c1495c4df0a974892c905770390160b35 Log: Merge branch 'master' of github.com:jenkinsci/pipeline-model-definition-plugin into JENKINS-37778 Compare: https://github.com/jenkinsci/pipeline-model-definition-plugin/compare/9b4ba7e75cea...df39786c1495

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-37778

Re: Pipeline Config: Getting env vars from Credentials

Code changed in jenkins User: Robert Sandell Path:

pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/steps/CredentialWrapperStepTest.java pipeline-model-definition/src/test/resources/credentials/mixedEnv.groovy http://jenkins-ci.org/commit/pipeline-model-definition-plugin/8b4885875aca43509f183a5e5972608b7387c119 Log: JENKINS-37778 more happy path testing

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-37778

Re: Pipeline Config: Getting env vars from Credentials

Code changed in jenkins User: Robert Sandell Path:

pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/model/CredentialsBindingHandler.java pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/steps/CredentialWrapperStepTest.java pipeline-model-definition/src/test/resources/credentials/noBinding.groovy http://jenkins-ci.org/commit/pipeline-model-definition-plugin/47f5b4c035267b8300904cf7f55370d3fbe8ce22 Log: JENKINS-37778 A negative test And some test case refactoring to try to fix/work around the ClassRule optimizations

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-37778

Re: Pipeline Config: Getting env vars from Credentials

Code changed in jenkins User: Robert Sandell Path:

pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/steps/CredentialWrapperStep.java pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/ClosureModelTranslator.groovy pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/PropertiesToMapTranslator.groovy pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/steps/CredentialWrapperStep/config.groovy pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/steps/CredentialWrapperStep/help.html pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/steps/CredentialWrapperStepTest.java http://jenkins-ci.org/commit/pipeline-model-definition-plugin/8287a8ae825b58742c0b812c8d7cb2d8b1c714d8 Log: JENKINS-37778 credentials should not be a step Now "just a method" in environment

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-37778

Re: Pipeline Config: Getting env vars from Credentials

Code changed in jenkins User: Robert Sandell Path:

pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/model/CredentialsBindingHandler.java http://jenkins-ci.org/commit/pipeline-model-definition-plugin/1617729be36e0b016d14d7c368939d1712168681 Log: JENKINS-37778 Use class FQN instead of String literal

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-37778

Re: Pipeline Config: Getting env vars from Credentials

Code changed in jenkins User: Robert Sandell Path:

pipeline-model-declarative-agent/pom.xml pipeline-model-declarative-agent/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/agent/DeclarativeAgent.java pipeline-model-declarative-agent/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/agent/DeclarativeAgentDescriptor.java pipeline-model-definition/pom.xml pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/Utils.groovy pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/model/AbstractBuildConditionResponder.groovy pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/model/Agent.groovy pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/model/JobProperties.groovy pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/model/MappedClosure.groovy pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/model/NestedModel.groovy pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/model/Parameters.groovy pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/model/Root.groovy pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/model/Stage.groovy pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/model/Stages.groovy pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/model/StepsBlock.groovy pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/model/Tools.groovy pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/model/Triggers.groovy pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/ModelStepLoader.java pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/agent/impl/DockerPipeline.java pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/agent/impl/DockerPipelineFromDockerfile.java pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/agent/impl/Label.java pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/model/BuildCondition.java pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/ModelInterpreter.groovy pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/agent/impl/DockerPipelineFromDockerfileScript.groovy pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/AbstractModelDefTest.java pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/AgentTest.java pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/ValidatorTest.java pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/agent/impl/LabelAndOtherFieldAgent.java pipeline-model-definition/src/test/resources/fromAlternateDockerfile.groovy pipeline-model-definition/src/test/resources/fromDockerfile.groovy http://jenkins-ci.org/commit/pipeline-model-definition-plugin/7e5cbd41d9a9f5cf6b14e68ba1f9fa9a855cdba7 Log: Merge remote-tracking branch 'origin/master' into JENKINS-37778 Conflicts: pipeline-model-definition/pom.xml pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/model/Root.groovy pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/model/Stage.groovy Compare: https://github.com/jenkinsci/pipeline-model-definition-plugin/compare/1617729be36e...7e5cbd41d9a9

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-37778

Re: Pipeline Config: Getting env vars from Credentials

Code changed in jenkins User: Robert Sandell Path:

pipeline-model-definition/pom.xml pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/steps/CredentialWrapperStepTest.java http://jenkins-ci.org/commit/pipeline-model-definition-plugin/bec0c4be0503c5703e9d6e0da24833bc999d1372 Log: JENKINS-37778 Fix test after merge Something unrelated in the shared libraries caused the tests to fail bumping the dependency down one version to fix that. An npe caused bu the credentials folder property to not be correctly initialized also fixed.

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-37778

Re: Pipeline Config: Getting env vars from Credentials

Code changed in jenkins User: Robert Sandell Path:

pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/ast/AbstractModelASTCodeBlock.java pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTScriptBlock.java pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTStage.java pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTWhen.java pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/validator/ModelValidator.java pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/model/Stage.groovy pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/parser/JSONParser.groovy pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/parser/ModelParser.groovy pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/validator/ModelValidatorImpl.groovy pipeline-model-definition/src/main/resources/ast-schema.json pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/ModelInterpreter.groovy pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/WhenStageTest.java pipeline-model-definition/src/test/resources/when/simpleWhen.groovy pipeline-model-definition/src/test/resources/when/whenEmpty.groovy pipeline-model-definition/src/test/resources/when/whenException.groovy http://jenkins-ci.org/commit/pipeline-model-definition-plugin/44c8249f6df539cc3477d08b0142813d91001a45

Log: Merge remote-tracking branch 'origin/master' into JENKINS-37778

Conflicts: pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/ModelInterpreter.groovy

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-37778

Re: Pipeline Config: Getting env vars from Credentials

Code changed in jenkins User: Robert Sandell Path:

pipeline-model-definition/pom.xml pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/model/Root.groovy pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/model/Stage.groovy pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/model/CredentialsBindingHandler.java pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/steps/CredentialWrapper.java

pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/ClosureModelTranslator.groovy pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/ModelInterpreter.groovy pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/PropertiesToMapTranslator.groovy pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/AbstractModelDefTest.java pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/EnvironmentTest.java pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/steps/CredentialWrapperStepTest.java pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/util/HasArchived.java pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/util/InputStreamContainingString.java pipeline-model-definition/src/test/resources/credentials/mixedEnv.groovy pipeline-model-definition/src/test/resources/credentials/noBinding.groovy pipeline-model-definition/src/test/resources/credentials/usernamePassword.groovy http://jenkins-ci.org/commit/pipeline-model-definition-plugin/f4e86644f5f483602da9b7686d9fc4a0e6b51e07 Log: Merge pull request #46 from jenkinsci/JENKINS-37778

JENKINS-37778 Support credentials in environment

Compare: https://github.com/jenkinsci/pipeline-model-definition-plugin/compare/ec6f0ea92278...f4e86644f5f4

Add Comment

[rsandell@cloudbees.com (JIRA)]

rsandell updated JENKINS-37778

Jenkins / JENKINS-37778

Pipeline Config: Getting env vars from Credentials

Change By: rsandell Status: In Progress Review

Add Comment

[rsandell@cloudbees.com (JIRA)]

rsandell updated JENKINS-37778

Jenkins / JENKINS-37778 Pipeline Config: Getting env vars from Credentials

Change By: rsandell Status: In Review Resolved Resolution: Done

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-37778

Re: Pipeline Config: Getting env vars from Credentials

Code changed in jenkins User: Robert Sandell Path:

SYNTAX.md http://jenkins-ci.org/commit/pipeline-model-definition-plugin/71c3d60ee486e48757bbd76315dc69a9e0418775 Log: Update SYNTAX.md Noting changes introduced in JENKINS-37792, JENKINS-37781 and JENKINS-37778 Also fixed the script example and marked the code sections as groovy so that GitHub hopefully can color the code a bit more nicely.

Add Comment

[bitwiseman@gmail.com (JIRA)]

Liam Newman closed an issue as Done

Bulk closing resolved issues.

Jenkins / JENKINS-37778

Pipeline Config: Getting env vars from Credentials

Change By: Liam Newman Status: Resolved Closed

Add Comment

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)