[JIRA] (JENKINS-37589) Replay link does not show up if Jenkinsfile had a syntax error

14 views
Skip to first unread message

tyler@monkeypox.org (JIRA)

unread,
Aug 22, 2016, 10:55:03 AM8/22/16
to jenkinsc...@googlegroups.com
R. Tyler Croy created an issue
 
Jenkins / Bug JENKINS-37589
Replay link does not show up if Jenkinsfile had a syntax error
Issue Type: Bug Bug
Assignee: Jesse Glick
Components: workflow-plugin
Created: 2016/Aug/22 2:54 PM
Labels: community-bee
Priority: Minor Minor
Reporter: R. Tyler Croy

Steps to reproduce

  • Create a Pipeline with a Jenkinsfile
  • Introduce a Groovy syntax error, like omitting a trailing parenthesis on a method call
  • Execute

What ends up happening is that an exception is shown, e.g.:

Checking out Revision f29c250737c3db53f709977224c4547a43ed4886 (refs/remotes/origin/master)
org.codehaus.groovy.control.MultipleCompilationErrorsException: startup failed:
WorkflowScript: 7: expecting ')', found ']' @ line 7, column 17.
                   ])

But the sidebar includes no Replay link to attempt to fix the change, instead you need to commit a change to make the Jenkinsfile correct Groovy syntax.

Expected

  • Replay is shown no matter how fscked my Jenkinsfile is so I can correct it

This issue also occurs if you use Replay and introduce a Groovy syntax error as well. Also, I believe this is related to JENKINS-34555
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
Atlassian logo

jglick@cloudbees.com (JIRA)

unread,
Sep 9, 2016, 4:38:04 PM9/9/16
to jenkinsc...@googlegroups.com
Jesse Glick updated an issue
Change By: Jesse Glick
Component/s: workflow-cps-plugin
Component/s: pipeline

roidelapluie@inuits.eu (JIRA)

unread,
Dec 19, 2016, 2:46:01 AM12/19/16
to jenkinsc...@googlegroups.com
Julien Pivotto updated an issue
Change By: Julien Pivotto
Attachment: PP.png

chris@orr.me.uk (JIRA)

unread,
Feb 10, 2017, 7:44:01 AM2/10/17
to jenkinsc...@googlegroups.com
Christopher Orr commented on Bug JENKINS-37589
 
Re: Replay link does not show up if Jenkinsfile had a syntax error

Probably not surprising, but thought I'd note: the same occurs if you make a syntax error with a purely Declarative Pipeline.

prince96raj@gmail.com (JIRA)

unread,
Apr 30, 2018, 3:54:02 AM4/30/18
to jenkinsc...@googlegroups.com
Prince Raj Kumar updated an issue
 
Change By: Prince Raj Kumar
Priority: Minor Major
This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
Atlassian logo

svanoort@cloudbees.com (JIRA)

unread,
May 2, 2018, 5:38:03 PM5/2/18
to jenkinsc...@googlegroups.com
Sam Van Oort updated an issue
Change By: Sam Van Oort
Labels: community-bee maybe-fixed-by-durability-megafix

svanoort@cloudbees.com (JIRA)

unread,
May 2, 2018, 5:39:02 PM5/2/18
to jenkinsc...@googlegroups.com
Sam Van Oort commented on Bug JENKINS-37589
 
Re: Replay link does not show up if Jenkinsfile had a syntax error

R. Tyler Croy Christopher Orr Can you check if the error occurs with workflow-cps 2.50 and workflow-cps 2.21? I just released a set of fixes that I think address this.

enrique.r.canales@gmail.com (JIRA)

unread,
Aug 10, 2018, 11:24:03 AM8/10/18
to jenkinsc...@googlegroups.com

I had tested this with workflow-cps 2.54 and workflow-job 2.21 and it looks like the Replay link shows up, but the ` Main Script` portion does not when there was a syntax error.
This message was sent by Atlassian JIRA (v7.10.1#710002-sha1:6efc396)

dnusbaum@cloudbees.com (JIRA)

unread,
Aug 23, 2018, 2:21:02 PM8/23/18
to jenkinsc...@googlegroups.com

It looks like the main script portion does not show up because ReplayAction#isReplayableSandboxTest returns false because loading the execution fails with the following:

Aug 23, 2018 2:16:33 PM org.jenkinsci.plugins.workflow.cps.replay.ReplayAction getExecutionBlocking
WARNING: Error fetching execution for replay
java.io.IOException: Syntax #1 did not yet start
	at org.jenkinsci.plugins.workflow.job.WorkflowRun$Owner.get(WorkflowRun.java:1125)
	at org.jenkinsci.plugins.workflow.cps.replay.ReplayAction.getExecutionBlocking(ReplayAction.java:126)
	at org.jenkinsci.plugins.workflow.cps.replay.ReplayAction.isReplayableSandboxTest(ReplayAction.java:166)
        ... the rest of the stack is not relevant (tested via script console)

vivek.pandey@gmail.com (JIRA)

unread,
Nov 15, 2018, 5:57:02 PM11/15/18
to jenkinsc...@googlegroups.com
Vivek Pandey updated an issue
 
Change By: Vivek Pandey
Labels: community-bee maybe-fixed-by-durability-megafix triaged-2018-11
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

marcin.kwiecien@jamf.com (JIRA)

unread,
Oct 8, 2019, 2:45:02 PM10/8/19
to jenkinsc...@googlegroups.com
Marcin Kwiecien commented on Bug JENKINS-37589
 
Re: Replay link does not show up if Jenkinsfile had a syntax error

It would be awesome if this was fixed... Because it's a major pain. If you don't copy your Jenkinsfile before hitting on the "Run" button and the build fails due to Groovy syntax error then all your changes to the Jenkinsfile you just did via the Replay button are gone.
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages