[JIRA] (JENKINS-36826) Support Jenkins Pipeline for Jabber notifications

38 views
Skip to first unread message

alexvanacker@gmail.com (JIRA)

unread,
Jul 20, 2016, 11:29:02 AM7/20/16
to jenkinsc...@googlegroups.com
Alexis Vanacker created an issue
 
Jenkins / New Feature JENKINS-36826
Support Jenkins Pipeline for Jabber notifications
Issue Type: New Feature New Feature
Assignee: kutzi
Components: instant-messaging-plugin, jabber-plugin
Created: 2016/Jul/20 3:28 PM
Priority: Major Major
Reporter: Alexis Vanacker

It would be great to be able to send Jabber notifications from a Pipeline job.

Example:
sendJabber targets:myn...@chat.mycompany.com

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
Atlassian logo

benh@swimfrog.com (JIRA)

unread,
Aug 31, 2016, 6:13:01 PM8/31/16
to jenkinsc...@googlegroups.com

derek@redeyebandit.com (JIRA)

unread,
Sep 16, 2016, 12:39:07 PM9/16/16
to jenkinsc...@googlegroups.com

ttamalfor@gmail.com (JIRA)

unread,
Sep 28, 2016, 11:02:03 AM9/28/16
to jenkinsc...@googlegroups.com

rfox@psualum.com (JIRA)

unread,
Dec 27, 2016, 4:43:01 PM12/27/16
to jenkinsc...@googlegroups.com
Ryan Fox commented on New Feature JENKINS-36826

eduardo.lezcano@be.atlascopco.com (JIRA)

unread,
Mar 3, 2017, 9:22:04 AM3/3/17
to jenkinsc...@googlegroups.com

thorsten.rossner@gmail.com (JIRA)

unread,
Jun 7, 2018, 1:27:02 AM6/7/18
to jenkinsc...@googlegroups.com

Please review and (hopefully) accept the Pull requests. This is an essential functionality for working with Pipelines.

This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)
Atlassian logo

thorsten.rossner@gmail.com (JIRA)

unread,
Jun 7, 2018, 1:27:04 AM6/7/18
to jenkinsc...@googlegroups.com
Thorsten R. updated an issue
 
Change By: Thorsten R.
Comment:
Please review and (hopefully) accept the Pull requests. This is an essential functionality for working with Pipelines.

thorsten.rossner@gmail.com (JIRA)

unread,
Jun 7, 2018, 1:30:02 AM6/7/18
to jenkinsc...@googlegroups.com
 
Re: Support Jenkins Pipeline for Jabber notifications

Please review and (hopefully) accept the Pull-Requests, as this functionality is essential for working with Pipelines and there are no efficient workarounds (at least on Windows environments).

regs@akom.net (JIRA)

unread,
Jun 7, 2018, 10:11:02 AM6/7/18
to jenkinsc...@googlegroups.com
Alexander Komarov edited a comment on New Feature JENKINS-36826
I started working on this feature, and it requires 2 PRs (im and jabber plugins). I'll open them once the code is ready to merge.

[changes for Instant Messaging |https://github.com/jenkinsci/instant-messaging-plugin/compare/master...akomakom:pipeline-support?expand=1]
[changes for Jabber|https://github.com/jenkinsci/jabber-plugin/compare/master...akomakom:pipeline-support?expand=1]

  Direct links to branches if you want to build this manually:

It's a work in progress [https://github .   com/akomakom/instant-messaging-plugin/tree/pipeline-support]

[https://github.com/akomakom/jabber-plugin/tree/pipeline-support]

I am introducing a *jabberNotify* step: 
{code:java}
//pipeline: 
jabberNotify targets: '*test'

//normal options can be set:
jabberNotify notificationStrategy: 'failure', notifyCulprits: true, notifyFixers: true, notifySuspects: true, notifyUpstreamCommitters: true, targets: '*test'

//plus some extras:
jabberNotify extraMessage: 'I am the tester!', targets: '*test'{code}
 In "test" Jabber chatroom (Result is *NOT BUILT* because the job hasn't finished and result hasn't been set):
{noformat}
[17:49:03] <Jenkins> Project test-pipeline-syntax build #70: NOT BUILT in 0.22 sec: http://xxxxxx I am the tester!!!{noformat}
 I'm basically aiming to make a pipeline step that causes a "notify now" type action, disregarding concepts like "notify on start/end" that would only be possible in a FreestyleJob, but honoring things like "only culprits", "strategy", etc.  So the step code will probably wind up in either catch or finally blocks in real life most of the time (but it can be used multiple times in a build).

Without a doubt I'm not doing everything the best way, but I'll try to build on this over time.  Comments and PR's (to my branches, I guess) are welcome.

 *Syntax generator screenshot:*

!Screenshot_2017-12-02_06-40-27.png|thumbnail!  

flo@geekplace.eu (JIRA)

unread,
Jun 7, 2018, 10:36:02 AM6/7/18
to jenkinsc...@googlegroups.com

As far as I can tell, there are no pull requests open.

regs@akom.net (JIRA)

unread,
Jun 7, 2018, 11:00:03 AM6/7/18
to jenkinsc...@googlegroups.com

Florian Schmaus, I'm guessing that you own Jabber but not Instant Messaging.

I have two branches, one for each, and I can't open the PR for Jabber until the PR for IM is merged.  I don't know if anyone owns that plugin, and I don't feel qualified to take it over and make executive decisions about its architecture.  Thus we're deadlocked.

flo@geekplace.eu (JIRA)

unread,
Jun 18, 2018, 6:14:04 AM6/18/18
to jenkinsc...@googlegroups.com
Florian Schmaus assigned an issue to kutzi
 
Change By: Florian Schmaus
Assignee: Florian Schmaus kutzi

flo@geekplace.eu (JIRA)

unread,
Jun 18, 2018, 6:18:04 AM6/18/18
to jenkinsc...@googlegroups.com

Florian Schmaus, I'm guessing that you own Jabber but not Instant Messaging.

That is unfortunately the current situation.

I have two branches, one for each, and I can't open the PR for Jabber until the PR for IM is merged.

Please also open the PR against the jabber-plugin with a reference to this bug and a note that it requires the instant-messaging-plugin PR to be applied first.

I don't know if anyone owns that plugin, and I don't feel qualified to take it over and make executive decisions about its architecture.  Thus we're deadlocked.

Kutzi is AFAIKT the maintainer for the instant-messaging-plugin. I don't now if the is still active. I'll possibly try to claim maintainership for the instant-messaging-plugin too, like I did with the jabber-plugin, if no one else steps up.

 

johan@zoom.nu (JIRA)

unread,
Dec 28, 2018, 7:34:07 AM12/28/18
to jenkinsc...@googlegroups.com

Florian Schmaus could you please try to take stewardship of the IM Plugin? I'd love to see the pipeline PRs finally merged.

This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

andrewrobertdouglas@gmail.com (JIRA)

unread,
Jun 23, 2019, 7:30:04 AM6/23/19
to jenkinsc...@googlegroups.com

Hi,

Is there anything that I can do to help move this along?  I'm migrating quite a few jobs from freestyle to pipelines and I would hate to lose this functionality.

jimklimov@gmail.com (JIRA)

unread,
Aug 1, 2019, 3:51:04 PM8/1/19
to jenkinsc...@googlegroups.com

I can now merge the IM and IRC PRs, but did not ask for Jabber rights (so Florian Schmaus should follow up with the merge of https://github.com/jenkinsci/jabber-plugin/pull/18).

I ported that logic for ircbot so there would be an ircNotify pipeline step as well, and can at least confirm that this coupling works

jimklimov@gmail.com (JIRA)

unread,
Aug 1, 2019, 3:51:14 PM8/1/19
to jenkinsc...@googlegroups.com
Jim Klimov assigned an issue to Jim Klimov
 
Change By: Jim Klimov
Assignee: kutzi Jim Klimov

flo@geekplace.eu (JIRA)

unread,
Aug 1, 2019, 4:34:04 PM8/1/19
to jenkinsc...@googlegroups.com
Florian Schmaus commented on New Feature JENKINS-36826
 
Re: Support Jenkins Pipeline for Jabber notifications

so Florian Schmaus should follow up with the merge of https://github.com/jenkinsci/jabber-plugin/pull/18

That PR has conflicts that you need to resolve first.

jimklimov@gmail.com (JIRA)

unread,
Aug 2, 2019, 7:51:03 AM8/2/19
to jenkinsc...@googlegroups.com

> That PR has conflicts that you need to resolve first.

Unfortunately I am not the author nor committer there. I think in github the repo maintainer may by default edit the source branch of a PR, in the other developer's repository.
Given that the conflict is just something in "versions.gradle", can you please see if it is something you may and can fix easily?

regs@akom.net (JIRA)

unread,
Aug 2, 2019, 8:58:02 AM8/2/19
to jenkinsc...@googlegroups.com

Will fix, just returning from vacation.

regs@akom.net (JIRA)

unread,
Aug 2, 2019, 4:03:03 PM8/2/19
to jenkinsc...@googlegroups.com

FYI, the jabber PR no longer has conflicts, but I suspect that it should be updated to depend on a stable version of the instant messaging plugin once it is released with the changes. It's not clear to me whether the SNAPSHOT version is even published in the wild.

jimklimov@gmail.com (JIRA)

unread,
Aug 3, 2019, 2:03:03 PM8/3/19
to jenkinsc...@googlegroups.com

Thanks. I was trying to make a release yesterday, but it stumbled on older dependencies first and on newly caught findbugs then, so stalled a bit ;(

regs@akom.net (JIRA)

unread,
Aug 3, 2019, 6:53:03 PM8/3/19
to jenkinsc...@googlegroups.com

No rush on my part.
Also, our team switched to Mattermost since I pushed this, so this will probably be my only PR for the foreseeable future.

jimklimov@gmail.com (JIRA)

unread,
Aug 5, 2019, 11:05:03 PM8/5/19
to jenkinsc...@googlegroups.com

I performed a release 1.37 of the instant-messaging-plugin so hopefully in a few hours its artifacts will be published and be dependable upon.

Also, you could endeavour to make a plugin to notify/bot/... via Mattermost, right?

regs@akom.net (JIRA)

unread,
Aug 6, 2019, 10:09:03 AM8/6/19
to jenkinsc...@googlegroups.com

Sounds good Jim Klimov.

Mattermost already has a plugin that does not depend on instant-messaging and has plugin support: https://jenkins.io/doc/pipeline/steps/mattermost/

regs@akom.net (JIRA)

unread,
Aug 6, 2019, 10:09:05 AM8/6/19
to jenkinsc...@googlegroups.com
Alexander Komarov edited a comment on New Feature JENKINS-36826
Sounds good [~jimklimov].   

Mattermost already has a plugin that does not depend on instant-messaging and has
plugin pipeline support: https://jenkins.io/doc/pipeline/steps/mattermost/

flo@geekplace.eu (JIRA)

unread,
Oct 17, 2019, 3:12:06 PM10/17/19
to jenkinsc...@googlegroups.com
Change By: Florian Schmaus
Status: In Progress Review
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

flo@geekplace.eu (JIRA)

unread,
Oct 17, 2019, 3:12:08 PM10/17/19
to jenkinsc...@googlegroups.com
Florian Schmaus assigned an issue to Florian Schmaus
Change By: Florian Schmaus
Assignee: Jim Klimov Florian Schmaus

flo@geekplace.eu (JIRA)

unread,
Oct 23, 2019, 8:32:08 AM10/23/19
to jenkinsc...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages