[JIRA] (JENKINS-36720) Investigate/cleanup medium-severity FindBugs issues in the Jenkins core

[o.v.nenashev@gmail.com (JIRA)]

Oleg Nenashev created an issue

Jenkins / JENKINS-36720 Investigate/cleanup medium-severity FindBugs issues in the Jenkins core Issue Type: Task Assignee: Unassigned Components: core Created: 2016/Jul/15 4:39 PM Priority: Minor Reporter: Oleg Nenashev Currently FindBugs settings ignore all medium-priority issues. It's bad, because this level contains NPE checks and other serious issues. TODOs: Remove filtering of medium-priority issues Investigate error codes, add low-important once to the ignore list Fix important issues Add Comment

This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)

[o.v.nenashev@gmail.com (JIRA)]

Oleg Nenashev commented on JENKINS-36720

Re: Investigate/cleanup medium-severity FindBugs issues in the Jenkins core Summary: 2 issues in CLI 477 issues in the core The output is too long to be published as text, I'll attach it

Add Comment

[o.v.nenashev@gmail.com (JIRA)]

Oleg Nenashev updated an issue

Jenkins / JENKINS-36720

Investigate/cleanup medium-severity FindBugs issues in the Jenkins core

Change By: Oleg Nenashev Attachment: findbugsIssues_core.txt

Add Comment

[S.Spieker@gmx.net (JIRA)]

Stefan Spieker assigned an issue to Stefan Spieker

Jenkins / JENKINS-36720 Investigate/cleanup medium-severity FindBugs issues in the Jenkins core

Change By: Stefan Spieker Assignee: Stefan Spieker

Add Comment

This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

[S.Spieker@gmx.net (JIRA)]

Stefan Spieker started work on JENKINS-36720

Change By: Stefan Spieker Status: Open In Progress

Add Comment

[dbeck@cloudbees.com (JIRA)]

Daniel Beck commented on JENKINS-36720

Re: Investigate/cleanup medium-severity FindBugs issues in the Jenkins core Is this done completely in 2.191, or just partially?

Add Comment

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)

[S.Spieker@gmx.net (JIRA)]

Stefan Spieker commented on JENKINS-36720

Re: Investigate/cleanup medium-severity FindBugs issues in the Jenkins core

There are several PRs done for this and there are more to come. This is a quite huge task. I think we would be down to 400 spotbugs issues if all PRs would be merged. So I guess this will be in progress for a longer while

Add Comment

[o.v.nenashev@gmail.com (JIRA)]

Oleg Nenashev updated an issue

Jenkins / JENKINS-36720

Investigate/cleanup medium-severity FindBugs issues in the Jenkins core

Change By: Oleg Nenashev Labels: hacktoberfest newbie-friendly

Add Comment

[o.v.nenashev@gmail.com (JIRA)]

Oleg Nenashev commented on JENKINS-36720

Re: Investigate/cleanup medium-severity FindBugs issues in the Jenkins core I am thinking about Highlighting this story for Hacktoberfest. WDYT Stefan Spieker?

Add Comment

[o.v.nenashev@gmail.com (JIRA)]

Oleg Nenashev updated an issue

Jenkins / JENKINS-36720

Investigate/cleanup medium-severity FindBugs issues in the Jenkins core

Change By: Oleg Nenashev

Currently FindBugs settings ignore all medium-priority issues. It's bad, because this level contains NPE checks and other serious issues. TODOs:

- Remove filtering of medium-priority issues - Investigate error codes, add low-important once to the ignore list - Fix important issues in small pull requests This task can be handled by multiple contributors!

Add Comment

[S.Spieker@gmx.net (JIRA)]

Stefan Spieker commented on JENKINS-36720

Re: Investigate/cleanup medium-severity FindBugs issues in the Jenkins core Oleg Nenashev: Yes. That is a good idea. We have a lot issues still to solve. Maybe you should mention then that changing in the main pom the line 109 with this : <findbugs.threshold>Medium</findbugs.threshold> is enough to get all spotbugs issues.

Add Comment

[o.v.nenashev@gmail.com (JIRA)]

Oleg Nenashev updated an issue

Jenkins / JENKINS-36720

Investigate/cleanup medium-severity FindBugs issues in the Jenkins core

Change By: Oleg Nenashev

Currently FindBugs settings ignore all medium-priority issues. It's bad, because this level contains NPE checks and other serious issues. TODOs:

- Remove filtering of medium-priority issues by setting <findbugs.threshold>Medium</findbugs.threshold>

- Investigate error codes, add low-important once to the ignore list - Fix important issues in small pull requests This task can be handled by multiple contributors!

Add Comment

[S.Spieker@gmx.net (JIRA)]

Stefan Spieker commented on JENKINS-36720

Re: Investigate/cleanup medium-severity FindBugs issues in the Jenkins core Current status: [INFO] Total bugs: 400

Add Comment

[o.v.nenashev@gmail.com (JIRA)]

Oleg Nenashev commented on JENKINS-36720

Re: Investigate/cleanup medium-severity FindBugs issues in the Jenkins core

Ugh. But it is still a  very good progress, thanks!

Add Comment

[S.Spieker@gmx.net (JIRA)]

Stefan Spieker commented on JENKINS-36720

Re: Investigate/cleanup medium-severity FindBugs issues in the Jenkins core

We are on a good way, but still some steps to go: [java] Warnings generated: 362

Add Comment

[o.v.nenashev@gmail.com (JIRA)]

Oleg Nenashev commented on JENKINS-36720

Re: Investigate/cleanup medium-severity FindBugs issues in the Jenkins core

Thanks for your hard work Stefan Spieker! I really look forward to introduce stricter requirements at some point

Add Comment

[raihaan.shouhell@autodesk.com (JIRA)]

Raihaan Shouhell commented on JENKINS-36720

Re: Investigate/cleanup medium-severity FindBugs issues in the Jenkins core

Probably due to findsecbugs we are at [java] Warnings generated: 591 right now

Add Comment