[JIRA] [git-plugin] (JENKINS-34363) Environment variable not set on git notifyCommit

[jani.makela@pp3.inet.fi (JIRA)]

Jani Mäkelä created an issue

Jenkins / JENKINS-34363 Environment variable not set on git notifyCommit Issue Type: Bug Assignee: Mark Waite Components: git-plugin Created: 2016/Apr/21 7:51 AM Environment: Jenkins ver. 1.642.4 Git-plugin 2.4.4 Priority: Minor Reporter: Jani Mäkelä Passing parameters to git/notifyCommit not setting environment variables. I have setup a parametrised build with the string parameter 'desc', doing `curl -s jenkinsurl?url=giturl\&desc=description` does not however set the environemnt variable, it's still using the default. Add Comment

This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)

[jani.makela@pp3.inet.fi (JIRA)]

Jani Mäkelä updated an issue

Jenkins / JENKINS-34363 Environment variable not set on git notifyCommit

Change By: Jani Mäkelä

Passing parameters to git/notifyCommit not setting environment variables. I have setup a parametrised build with the string parameter 'desc', doing ` {{ curl -s jenkinsurl?url=giturl\&desc=description ` }} does not however set the environemnt variable, it's still using the default. Add Comment

[mark.earl.waite@gmail.com (JIRA)]

Mark Waite resolved as Won't Fix

That is the expected behavior with the notifyCommit syntax you used. The notifyCommit call (without a sha1=xxx parameter) does not schedule a build, it schedules polling of the repository to see if something is waiting to be built. If you want to pass parameters to a build, please use http://server/job/myjob/buildWithParameters?PARAMETER=Value

Jenkins / JENKINS-34363 Environment variable not set on git notifyCommit

Change By: Mark Waite Status: Open Resolved Resolution: Won't Fix

Add Comment

[evadeflow@gmail.com (JIRA)]

Evade Flow commented on JENKINS-34363

Re: Environment variable not set on git notifyCommit

> If you want to pass parameters to a build, please use: http://server/job/myjob/buildWithParameters?PARAMETER=Value

I'm confused. Using the buildWithParameters endpoint is an unsatisfactory solution because it requires authentication, which simply isn't required in many environments. And this link: http://javadoc.jenkins-ci.org/git/hudson/plugins/git/GitStatus.html#SAFE_PARAMETERS claims that it's possible to pass parameters via notifyCommit, provided you set the Jenkins system property hudson.model.ParametersAction.safeParameters to a comma-separated list of parameters that should be allowed to pass through. > The notifyCommit call (without a sha1=xxx parameter) does not schedule a build, it schedules polling of the repository... So... which of the following is correct: 1. It is never possible to pass build parameters via notifyCommit 1. It is possible to pass parameters via notifyCommit, provided those parameters are listed in hudson.model.ParametersAction.safeParameters 1. It is possible to pass parameters via notifyCommit, provided those parameters are listed in hudson.model.ParametersAction.safeParameters and you also pass sha1=<xxx>

Add Comment

This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)

[evadeflow@gmail.com (JIRA)]

Evade Flow edited a comment on JENKINS-34363

Re: Environment variable not set on git notifyCommit

> _If you want to pass parameters to a build, please use:_ {{http://server/job/myjob/buildWithParameters?PARAMETER=Value}}

I'm confused. Using the {{buildWithParameters}} endpoint is an unsatisfactory solution because it requires authentication, which simply isn't required in many environments. And this link:

* http://javadoc.jenkins-ci.org/git/hudson/plugins/git/GitStatus.html#SAFE_PARAMETERS claims that it's possible to pass parameters via {{notifyCommit}}, provided you set the Jenkins system property {{hudson.model.ParametersAction.safeParameters}} to a comma-separated list of parameters that should be allowed to pass through. > _The notifyCommit call (without a sha1=xxx parameter) does not schedule a build, it schedules polling of the repository..._

So... which of the following is correct:

1. # It is _never_ possible to pass build parameters via {{notifyCommit}} 1. # It is possible to pass parameters via {{notifyCommit}}, provided those parameters are listed in {{hudson.model.ParametersAction.safeParameters}} 1. # It is possible to pass parameters via {{notifyCommit}}, provided those parameters are listed in {{hudson.model.ParametersAction.safeParameters}} _and_ you also pass {{sha1=<xxx>}}

Add Comment

[evadeflow@gmail.com (JIRA)]

Evade Flow commented on JENKINS-34363

Re: Environment variable not set on git notifyCommit

Here's another link implying that it should be possible—somehow—to pass parameters via notifyCommit: https://www.mail-archive.com/jenkinsc...@googlegroups.com/msg64262.html But I fear, after attempting it a bunch of different ways, that this is incorrect, and the answer to the question I posed previously is: It is never possible to pass build parameters via notifyCommit Mark Waite: Since your name was on 5b57aac7, can you confirm whether this is the case? Specifically, I'm hitting this URL from a commit hook: http://acme.com/jenkins/git/notifyCommit?url=g...@acme.com:demo/widget-utils.git&REBUILD_ALL=false and hoping that REBUILD_ALL will be set to false in my parameterized job, instead of its default value of true. Thanks!

Add Comment

[mark.earl.waite@gmail.com (JIRA)]

Mark Waite closed an issue as Won't Fix

Jenkins / JENKINS-34363

Environment variable not set on git notifyCommit

Change By: Mark Waite Status: Resolved Closed

Add Comment

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)