[JIRA] [acceptance-test-harness] (JENKINS-33107) ATH Docker Fixtures might fail using Docker-Machine

3 views
Skip to first unread message

asotobueno@cloudbees.com (JIRA)

unread,
Feb 23, 2016, 11:34:02 AM2/23/16
to jenkinsc...@googlegroups.com
Alex Soto created an issue
 
Jenkins / Bug JENKINS-33107
ATH Docker Fixtures might fail using Docker-Machine
Issue Type: Bug Bug
Assignee: Alex Soto
Components: acceptance-test-harness
Created: 23/Feb/16 4:33 PM
Labels: improvement
Priority: Minor Minor
Reporter: Alex Soto

When using ATH Docker fixture feature, depending on the method you call for starting a new container, might result on a failure if running under Docker-Machine.

The problem is that bindIp is hardcoded to 127.0.0.1 (https://github.com/jenkinsci/acceptance-test-harness/blob/b27c150f35a386dfced4a5960127bf62f9c34363/src/main/java/org/jenkinsci/test/acceptance/docker/DockerImage.java#L32)

The solution might be exploring DOCKER_HOST environment variable and try to get the ip from there.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)
Atlassian logo

asotobueno@cloudbees.com (JIRA)

unread,
Feb 24, 2016, 5:15:01 AM2/24/16
to jenkinsc...@googlegroups.com
Alex Soto started work on Bug JENKINS-33107
 
Change By: Alex Soto
Status: Open In Progress

scm_issue_link@java.net (JIRA)

unread,
Feb 25, 2016, 11:10:02 AM2/25/16
to jenkinsc...@googlegroups.com
SCM/JIRA link daemon commented on Bug JENKINS-33107
 
Re: ATH Docker Fixtures might fail using Docker-Machine

Code changed in jenkins
User: Robert Sandell
Path:
pom.xml
src/main/java/org/jenkinsci/test/acceptance/docker/DockerImage.java
src/test/java/org/jenkinsci/test/acceptance/docker/DockerImageTest.java
http://jenkins-ci.org/commit/acceptance-test-harness/ad3855e729ca30a6a31d448b1ab131d0f61396d1
Log:
Merge pull request #79 from lordofthejars/JENKINS-33107

JENKINS-33107 Docker Fixtures might fail using Docker-Machine

Compare: https://github.com/jenkinsci/acceptance-test-harness/compare/590918c8579b...ad3855e729ca

ogondza@gmail.com (JIRA)

unread,
Aug 15, 2019, 9:08:02 AM8/15/19
to jenkinsc...@googlegroups.com
Oliver Gondža resolved as Fixed
 
Change By: Oliver Gondža
Status: In Progress Resolved
Resolution: Fixed
This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)
Reply all
Reply to author
Forward
0 new messages