[JIRA] [core] (JENKINS-31605) Plugin manager allows uninstalling bundled plugins

[dbeck@cloudbees.com (JIRA)]

Daniel Beck created an issue

Jenkins / JENKINS-31605 Plugin manager allows uninstalling bundled plugins Issue Type: Bug Assignee: Tom FENNELLY Components: core Created: 17/Nov/15 7:11 PM Environment: Jenkins 1.638 Priority: Minor Reporter: Daniel Beck Introduced here: https://github.com/jenkinsci/jenkins/pull/1847/files#diff-c2decd7ac964b46c352a3960d1ffd9f1L114 It's no longer relevant whether a plugin is bundled for whether it can be uninstalled. However, when you (schedule to) uninstall a bundled plugin, it'll just get reinstalled on restart. This check needs to be reinstated in addition to the dependencies check. Add Comment

This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)

[tom.fennelly@gmail.com (JIRA)]

Tom FENNELLY commented on JENKINS-31605

Re: Plugin manager allows uninstalling bundled plugins I've no problem with changing this to never allow bundled plugins to be uninstalled (it's easy), but I am curious to know exactly what problem it is causing? The only way you should be able to uninstall a plugin (bundled or otherwise) is if there's no other installed plugin depending on it.

Add Comment

[tom.fennelly@gmail.com (JIRA)]

Tom FENNELLY commented on JENKINS-31605

Re: Plugin manager allows uninstalling bundled plugins

Actually, I didn't think this would be possible. I thought I introduced the concept of a "core" dependency and that this was added to all bundled plugins. Anyway ... just a thought and something else to check when fixing this.

Add Comment

[dbeck@cloudbees.com (JIRA)]

Daniel Beck updated an issue

Jenkins / JENKINS-31605

Plugin manager allows uninstalling bundled plugins

Change By: Daniel Beck Labels: lts-candidate

Add Comment

[dbeck@cloudbees.com (JIRA)]

Daniel Beck commented on JENKINS-31605

Re: Plugin manager allows uninstalling bundled plugins Tom FENNELLY The problem is that the behavior is unexpected. Rather than actually removing the plugin, you only effectively reset its version to the one that comes bundled. So changing back to not allowing this (while we still have bundled plugins) makes sense IMO.

Add Comment

[tom.fennelly@gmail.com (JIRA)]

Tom FENNELLY commented on JENKINS-31605

Re: Plugin manager allows uninstalling bundled plugins

Daniel Beck I agree. Should be easy fix.

Add Comment

[tom.fennelly@gmail.com (JIRA)]

Tom FENNELLY updated an issue

Jenkins / JENKINS-31605

Plugin manager allows uninstalling bundled plugins

Change By: Tom FENNELLY Labels: lts-candidate  regression

Add Comment

[jnord@cloudbees.com (JIRA)]

James Nord commented on JENKINS-31605

Re: Plugin manager allows uninstalling bundled plugins I beleive this is now working in 2.x as there are no bundled plugins in OSS - only custom derivatives...

Add Comment

This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)

[stephen.alan.connolly@gmail.com (JIRA)]

Stephen Connolly closed an issue as Cannot Reproduce

Cannot reproduce in 2.x

Jenkins / JENKINS-31605

Plugin manager allows uninstalling bundled plugins

Change By: Stephen Connolly Status: Open Closed Resolution: Cannot Reproduce

Add Comment

[dbeck@cloudbees.com (JIRA)]

Daniel Beck updated an issue

Jenkins / JENKINS-31605 Plugin manager allows uninstalling bundled plugins

Change By: Daniel Beck Labels: lts-candidate regression

Add Comment

[chead@chead.ca (JIRA)]

Christopher Head reopened an issue

I think this is still an issue. I am running 2.176.2 and I tried to uninstall the LDAP plugin. It lets me try, and I even tried actually deleting the files from /var/lib/jenkins/plugins, but after restarting, it comes back.

Jenkins / JENKINS-31605 Plugin manager allows uninstalling bundled plugins

Change By: Christopher Head Resolution: Cannot Reproduce Status: Closed Reopened

Add Comment

This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

[dbeck@cloudbees.com (JIRA)]

Daniel Beck closed an issue as Cannot Reproduce

Most things about plugin management have changed in the almost three years this was filed. Please create a new issue, and describe what happened in detail there.

Jenkins / JENKINS-31605 Plugin manager allows uninstalling bundled plugins

Change By: Daniel Beck Status: Reopened Closed Resolution: Cannot Reproduce

Add Comment

[dbeck@cloudbees.com (JIRA)]

Daniel Beck edited a comment on JENKINS-31605

Re: Plugin manager allows uninstalling bundled plugins Most Many things about plugin management have changed in the almost three years this was filed. Please create a new issue, and describe what happened in detail there.

Add Comment

[chead@chead.ca (JIRA)]

Christopher Head commented on JENKINS-31605

Re: Plugin manager allows uninstalling bundled plugins

OK. JENKINS-58580.

Add Comment