[JIRA] [core] (JENKINS-30101) Keep user specific reason for offline slave when slave getting disconnected

[tomer4@gmail.com (JIRA)]

Tomer Galun created an issue

Jenkins / JENKINS-30101 Keep user specific reason for offline slave when slave getting disconnected Issue Type: Improvement Assignee: Unassigned Components: core Created: 23/Aug/15 3:33 PM Priority: Minor Reporter: Tomer Galun Jenkins 1.598 1. When taking slave offline by user - you can specify a reason. If the slave is getting disconnected (i.e. after a reboot), the reason is changed to a java exception, and you can't see the original reason. 2. When a slave is in a "connecting" state (slave agent being lunched) and is in offline state - the reason doesn't appear on the computer page (/computer/host...). Add Comment

This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)

[gentoo.integer@gmail.com (JIRA)]

Kanstantsin Shautsou commented on JENKINS-30101

Re: Keep user specific reason for offline slave when slave getting disconnected 1. Jenkins restart is one thing, after jenkins start it calls computers.updates (afair). So something can be related in this part of code. 2. probably can be related to asynchronous actions between submitted runnable in threadPoolForRemoting (afair in this way it launches slaves) and offline marking/interruption.

Add Comment

[tomer4@gmail.com (JIRA)]

Tomer Galun commented on JENKINS-30101

Re: Keep user specific reason for offline slave when slave getting disconnected

1. when I said reboot - I meant a reboot of the slave (Channel Termination) 2. I guess you right.. Anyway, this is much less important

Add Comment

[tomer4@gmail.com (JIRA)]

Tomer Galun edited a comment on JENKINS-30101

Re: Keep user specific reason for offline slave when slave getting disconnected

hudson/slaves/SlaveComputer.java  1. In the function setChannel there is the line(531): offlineCause = null; which remove the offline cause after the slave reconnect. I don't think this is the right behaviour we expect - The offline state should remain in case it made by User / CLI. 2. line 473 We might override a user offline cause with a ChannelTermination cause. I think the right way is, again, check if there is a user / CLI cause and if so - don't change it. although I'm not sure if I don't miss anything here... (what is the expected behaviour in case that the node is offline and it disconnect from the slave... )

Add Comment

[tomer4@gmail.com (JIRA)]

Tomer Galun commented on JENKINS-30101

Re: Keep user specific reason for offline slave when slave getting disconnected hudson/slaves/SlaveComputer.java 1. In the function setChannel there is the line(531): offlineCause = null; which remove the offline cause after the slave reconnect. I don't think this is the right behaviour we expect - The offline state should remain in case it made by User / CLI. 2. line 473 We might override a user offline cause with a ChannelTermination cause. I think the right way is, again, check if there is a user / CLI cause and if so - don't change it. although I'm not sure if I don't miss anything here... (what is the expected behaviour in case that the node is offline and it disconnect from the slave...

Add Comment

[daigno@gmail.com (JIRA)]

Eric Daigneault commented on JENKINS-30101

Re: Keep user specific reason for offline slave when slave getting disconnected

I would make this as a bug rather than an improvement.  This makes Offline reasons provided by the user completely useless as a communication tool within the team regarding why this specific agent is offline. The Offline Reason is Effectively broken in the current behavior

Add Comment

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)