[JIRA] [core] (JENKINS-26407) Support expandableTextbox form validation

2 views
Skip to first unread message

recena@gmail.com (JIRA)

unread,
Apr 22, 2016, 9:45:09 AM4/22/16
to jenkinsc...@googlegroups.com
Manuel Jesús Recena Soto assigned an issue to Manuel Jesús Recena Soto
 
Jenkins / Improvement JENKINS-26407
Support expandableTextbox form validation
Change By: Manuel Jesús Recena Soto
Assignee: Oliver Gondža Manuel Jesús Recena Soto
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)
Atlassian logo

gentoo.integer@gmail.com (JIRA)

unread,
Oct 3, 2016, 4:09:01 PM10/3/16
to jenkinsc...@googlegroups.com
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
Atlassian logo

ogondza@gmail.com (JIRA)

unread,
Oct 4, 2016, 3:23:02 AM10/4/16
to jenkinsc...@googlegroups.com

I do not think it is a bug. The markup just does not add necessary attributes at all. Hopefully, adding them will be enough to get that to work.

gentoo.integer@gmail.com (JIRA)

unread,
Oct 4, 2016, 8:11:01 AM10/4/16
to jenkinsc...@googlegroups.com
        <j:when test="${h.isMultiline(value)}">
            <!-- multiline text area to begin with -->
            <f:textarea checkUrl="${attrs.checkUrl}" name='${attrs.name}' value="${value}" field="${attrs.field}"/>
        </j:when>

Fixes the case for textarea when text already saved you load it.

When it single input, expandTextArea() js kills it.
Also `validated` attribute kills page load because it expects to input to be in td that will be in tr that will have neighbour with tr validation-area-error that is missing in current jelly. So at all this will work only in f.entry(). Removing table layout screw view because there is button for expand.

gentoo.integer@gmail.com (JIRA)

unread,
Oct 4, 2016, 8:20:01 AM10/4/16
to jenkinsc...@googlegroups.com

textbox uses <m:input xmlns:m="jelly:hudson.util.jelly.MorphTagLibrary" and would work only in f.entry()

gentoo.integer@gmail.com (JIRA)

unread,
Oct 4, 2016, 9:57:07 AM10/4/16
to jenkinsc...@googlegroups.com

Also it seems that validation must be re-registered after html replacement.

pjdarton@gmail.com (JIRA)

unread,
Oct 2, 2019, 11:19:11 AM10/2/19
to jenkinsc...@googlegroups.com
pjdarton updated an issue
 
Jenkins / Bug JENKINS-26407
Support expandableTextbox form validation
Change By: pjdarton
Issue Type: Improvement Bug
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages