[JIRA] [accurev-plugin] (JENKINS-24710) Accurev changelog displays "Action=Dispatch" transactions

1 view
Skip to first unread message

skylar.sutton@gmail.com (JIRA)

unread,
Apr 24, 2016, 9:58:01 AM4/24/16
to jenkinsc...@googlegroups.com
Skylar Sutton commented on Bug JENKINS-24710
 
Re: Accurev changelog displays "Action=Dispatch" transactions

I attempted to create my own patch but the state of the public source for the accurev-plugin is shamefully sub-par. The source was several versions behind the official release, would not compile as published, and after making modifications required to get it to compile... the Jenkins plugin environment refused to acknowledge it / allow me to debug it.

After multiple requests for help from project contributors (including Scott) went unanswered, I gave up on this effort.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)
Atlassian logo

josephp90@gmail.com (JIRA)

unread,
Sep 22, 2016, 11:30:02 AM9/22/16
to jenkinsc...@googlegroups.com
Change By: Joseph Petersen
Assignee: Scott Tatum Joseph Petersen
This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)
Atlassian logo

josephp90@gmail.com (JIRA)

unread,
Sep 22, 2016, 11:31:01 AM9/22/16
to jenkinsc...@googlegroups.com
Joseph Petersen commented on Bug JENKINS-24710
 
Re: Accurev changelog displays "Action=Dispatch" transactions

Skylar, would I be able to help you?

What fork is this? Would I be able to take a look at your changes?

skylar.sutton@gmail.com (JIRA)

unread,
Sep 22, 2016, 1:16:02 PM9/22/16
to jenkinsc...@googlegroups.com

I have long since deleted the changes due to the issues mentioned in the comments above.

At a high level, the change was a "filtering expression" that could be applied to the changelog... allowing me to exclude items (ex: include the item if "action != dispatch"). I tinkered with a multi-select or checkbox setting for only the "actions" you wanted, but felt that was too specific of an implementation.

For what it's worth the issue still occurs, and I am still interested in a resolution.

josephp90@gmail.com (JIRA)

unread,
Sep 22, 2016, 2:05:04 PM9/22/16
to jenkinsc...@googlegroups.com

We do not have AccuSync up and running yet...

So could you pass me a log for the output and I would also appreciate the same output in XML if possible.
What does this transaction look? You could take the hist command and grab the XML that would be nice.

I would be happy to fix this issue.

josephp90@gmail.com (JIRA)

unread,
Sep 22, 2016, 2:06:02 PM9/22/16
to jenkinsc...@googlegroups.com
Joseph Petersen edited a comment on Bug JENKINS-24710
We do not have AccuSync up and running yet...

So could you pass me a log for the output and I would also appreciate the same output in XML if possible.
What does this transaction look? You could take the hist command into a terminal and grab the XML that would be nice.


I would be happy to fix this issue.

skylar.sutton@gmail.com (JIRA)

unread,
Sep 22, 2016, 4:46:06 PM9/22/16
to jenkinsc...@googlegroups.com

Using the WebGUI's export feature on one of the transactions looks like this:

<?xml version="1.0" encoding="UTF-8"?>
<table>
<Transaction>
<Time>Mon Sep 19 20:00:38 GMT-400 2016</Time>
<Action>dispatch</Action>
<User>accusync</User>
<TransNum>3093257</TransNum>
<Comment></Comment>
</Transaction>
</table>

josephp90@gmail.com (JIRA)

unread,
Sep 22, 2016, 5:26:01 PM9/22/16
to jenkinsc...@googlegroups.com

My guess would be to do some kind of sanity check on the parser.

                    if ("transaction".equalsIgnoreCase(tagName)) {
                        String accuSyncCheck = parser.getAttributeValue("", "action");
                        if (StringUtils.isNotEmpty(accuSyncCheck) && accuSyncCheck.equals("dispatch")) {
                            break;
                        }

josephp90@gmail.com (JIRA)

unread,
Sep 22, 2016, 5:51:01 PM9/22/16
to jenkinsc...@googlegroups.com

Would it be possible to filter out all transaction by accusync user, my guess that would be the default username for anyone running accusync?

skylar.sutton@gmail.com (JIRA)

unread,
Sep 23, 2016, 12:07:01 AM9/23/16
to jenkinsc...@googlegroups.com

In our specific impl. the user is always accusync, but I don't know enough about that side of the installation to know if that is an AccuRev "standard" or just something our SysAdmins picked.

josephp90@gmail.com (JIRA)

unread,
Sep 23, 2016, 3:10:01 AM9/23/16
to jenkinsc...@googlegroups.com
Joseph Petersen updated an issue
 
Change By: Joseph Petersen
We _emphasized text_We have a JIRA --> AccuRev synchronization process which runs several times per hour (as the user "accusync").

While I'm not intimately familiar with our synch process, the AccuRev transaction log indicates every "sync" has 'action=dispatch' and no file modifications.

Previous versions (v0.6.27) of the AccuRev Jenkins plugin did not display these dispatch transactions in the changelog, but after upgrading to v0.6.30 our change log is flooded with them.

Documentation available does not indicate that there is a way to manually disable/ignore these changelog entries... so I will assume that in previous versions the plugin was ignoring them and that functionality has been changed.

{code}
• [John Doe] updated file to include help file release 1.0.10
• [Jane Doe] Fixed sorted result set.
• [accusync]
• [accusync]
• [accusync]
• [accusync]
• [accusync]
• [accusync]
• [accusync]
• [accusync]
• [accusync]
• [accusync]
• [accusync]
• [accusync]
• [accusync]
• [accusync]
• [accusync]
• [accusync]
• [accusync]
• [accusync]
• [accusync]
• [accusync]
• [accusync]
• [accusync]
• [accusync]
• [accusync]
• [accusync]
• ... about 100 more ...
• [accusync]

{code}

josephp90@gmail.com (JIRA)

unread,
Sep 23, 2016, 3:11:02 AM9/23/16
to jenkinsc...@googlegroups.com
Joseph Petersen updated an issue

josephp90@gmail.com (JIRA)

unread,
Sep 23, 2016, 3:44:03 AM9/23/16
to jenkinsc...@googlegroups.com
Joseph Petersen commented on Bug JENKINS-24710
 
Re: Accurev changelog displays "Action=Dispatch" transactions

So issue is a lot simpler it seems.

you can do accurev hist -k promote,purge.... and just leave out dispatch filter the output

josephp90@gmail.com (JIRA)

unread,
Sep 28, 2016, 9:36:01 AM9/28/16
to jenkinsc...@googlegroups.com

sadly accurev hist -k only accepts a single parameter and does not accept multiple -k flags...

But I noticed there was already a method called filterTransaction which is always called after parsing the Transactions list.

So simple added:

filteredTransactions.removeIf(t -> t.getAction().equalsIgnoreCase("dispatch"));

josephp90@gmail.com (JIRA)

unread,
Sep 28, 2016, 9:43:02 AM9/28/16
to jenkinsc...@googlegroups.com
Joseph Petersen edited a comment on Bug JENKINS-24710
sadly accurev hist -k only accepts a single parameter and does not accept multiple -k flags...

But I noticed there was already a method called filterTransaction filterTransactions which is always called after parsing the Transactions list.

So simple added:

{code:java}

filteredTransactions.removeIf(t -> t.getAction().equalsIgnoreCase("dispatch"));
{code}

scm_issue_link@java.net (JIRA)

unread,
Sep 28, 2016, 11:15:02 AM9/28/16
to jenkinsc...@googlegroups.com

Code changed in jenkins
User: Joseph
Path:
src/main/java/hudson/plugins/accurev/AccurevLauncher.java
src/main/java/hudson/plugins/accurev/AccurevPlugin.java
src/main/java/hudson/plugins/accurev/AccurevSCM.java
src/main/java/hudson/plugins/accurev/AccurevStream.java
src/main/java/hudson/plugins/accurev/AccurevTransaction.java
src/main/java/hudson/plugins/accurev/ParseChangeLog.java
src/main/java/hudson/plugins/accurev/UUIDUtils.java
src/main/java/hudson/plugins/accurev/cmd/Login.java
src/main/java/hudson/plugins/accurev/cmd/PopulateCmd.java
src/main/java/hudson/plugins/accurev/cmd/ShowStreams.java
src/main/java/hudson/plugins/accurev/delegates/AbstractModeDelegate.java
src/main/java/hudson/plugins/accurev/delegates/ReftreeDelegate.java
src/main/java/hudson/plugins/accurev/delegates/SnapshotDelegate.java
src/main/java/hudson/plugins/accurev/delegates/WorkspaceDelegate.java
src/main/java/hudson/plugins/accurev/parsers/xml/ParseShowStreams.java
src/main/java/hudson/plugins/jetty/security/Password.java
src/main/resources/hudson/plugins/accurev/AccurevSCM/config.jelly
src/main/resources/hudson/plugins/accurev/AccurevSCM/global.jelly
http://jenkins-ci.org/commit/accurev-plugin/b8296bb9c55c924f48c91356fe9ba7d9e35d4298
Log:
Merged PR #28 from casz/master

Poll failed searching in parents when “Show one stream at a time” was
checked.
Fixed regression in PR #25

  • Improved logic for Workspace

Was not working with “One stream at a time” settings.

  • Fixed Change log on Ignore Parent

getChangesFromStreams did not respect Ignore Stream Parent.

  • Fixed getStreamRules.

IgnoreStreamParent should be the first to be considered, then One
Stream at a time on server, then find all streams.

Introduced unique identifiers, also added a migrator to ensure best
compatibility moving forward.

  • Fixed backwards compatibility

Made the Server UUID change fully backwards compatibility :tada:

I cannot believe this has been open since 2012...

  • StringUtils used
  • Allow empty password even with OBF
  • Javadoc and removed unused migrate field

These usually originate from accurev sync.

  • PR #24 fix PollOnMaster enabled when build using workspace

builds that use workspace or reftree definitely requires workspace even
if PollOnMaster enabled.

josephp90@gmail.com (JIRA)

unread,
Sep 30, 2016, 2:41:01 AM9/30/16
to jenkinsc...@googlegroups.com

Skylar can you confirm that they are filtered now?

skylar.sutton@gmail.com (JIRA)

unread,
Oct 3, 2016, 9:09:01 AM10/3/16
to jenkinsc...@googlegroups.com

Thanks. Will try to test today or tomorrow... been bogged down with a few things.

skylar.sutton@gmail.com (JIRA)

unread,
Oct 3, 2016, 10:51:06 AM10/3/16
to jenkinsc...@googlegroups.com

Joseph - Is there a snapshot available? I am no longer setup to build this project and the GIT tags are only showing release tags right now.

josephp90@gmail.com (JIRA)

unread,
Oct 3, 2016, 10:53:06 AM10/3/16
to jenkinsc...@googlegroups.com

The latest version includes this fix

josephp90@gmail.com (JIRA)

unread,
Oct 3, 2016, 10:59:05 AM10/3/16
to jenkinsc...@googlegroups.com

If you want any snapshots, they can be found on each build through jenkins ci
https://jenkins.ci.cloudbees.com/job/plugins/job/accurev-plugin/org.jenkins-ci.plugins$accurev/lastSuccessfulBuild/artifact/
Then you can just click previous build till you find the one you want.

skylar.sutton@gmail.com (JIRA)

unread,
Oct 3, 2016, 1:10:02 PM10/3/16
to jenkinsc...@googlegroups.com

Got it, apologies... did not see it listed in the 0.7.2 release notes.

I upgraded and will report back after our nightly build.

skylar.sutton@gmail.com (JIRA)

unread,
Oct 4, 2016, 8:35:02 AM10/4/16
to jenkinsc...@googlegroups.com
Skylar Sutton resolved as Fixed
 

Marking resolved - changelog no longer includes the [accusync] entries. Thanks!
Change By: Skylar Sutton
Status: Open Resolved
Resolution: Fixed

josephp90@gmail.com (JIRA)

unread,
Mar 7, 2020, 1:07:24 AM3/7/20
to jenkinsc...@googlegroups.com
Joseph Petersen assigned an issue to Joseph Petersen
Change By: Joseph Petersen
Assignee: Joseph Petersen (old)
This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages