[JIRA] [core] (JENKINS-23786) Permit "Execute shell" jobs to return 2 for "unstable"

[annemoroney@alum.mit.edu (JIRA)]

AnneTheAgile commented on JENKINS-23786

Re: Permit "Execute shell" jobs to return 2 for "unstable" Craig Ringer, did you ever get feedback on your patch? I don't know how patches normally get added to Jenkins? I would love this fix too. Add Comment

This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)

[annemoroney@alum.mit.edu (JIRA)]

AnneTheAgile edited a comment on JENKINS-23786

Re: Permit "Execute shell" jobs to return 2 for "unstable"

[~ringerc], did you ever get feedback on your patch? I don't know how patches normally get added to Jenkins?

I would love this fix too.

p.s. Note, the linked "Duplicate" ticket was closed in favor of this one.

Add Comment

[dbeck@cloudbees.com (JIRA)]

Daniel Beck commented on JENKINS-23786

Re: Permit "Execute shell" jobs to return 2 for "unstable"

AnneTheAgile See https://github.com/jenkinsci/jenkins/pull/1325#issuecomment-107914540

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-23786

Re: Permit "Execute shell" jobs to return 2 for "unstable"

Code changed in jenkins User: Craig Ringer Path: core/src/main/java/hudson/tasks/Shell.java core/src/main/resources/hudson/tasks/Shell/config.groovy test/src/test/java/hudson/tasks/ShellTest.java http://jenkins-ci.org/commit/jenkins/e773eb44621ded75e66e4d4b3aa6f7a48bebcb49 Log: JENKINS-23786: Allow Shell jobs to set a return code for unstable Currently a shell job has to make a HTTP call back to Jenkins to set its build result as unstable. This is slow, requires the slave to have access to the master's HTTP interface, and is fiddly. The alternative, the TextFinder plugin, is no better. Instead, allow a job to set the build result to unstable with a return value. Adds the Advanced parameter "unstableReturn" which, if non-zero, is the code the script must return to set the build as unstable.

Add Comment

This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-23786

Re: Permit "Execute shell" jobs to return 2 for "unstable"

Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/tasks/BatchFile.java core/src/main/java/hudson/tasks/CommandInterpreter.java core/src/main/java/hudson/tasks/Shell.java core/src/main/resources/hudson/tasks/BatchFile/config.jelly core/src/main/resources/hudson/tasks/BatchFile/help-unstableReturn.html core/src/main/resources/hudson/tasks/Messages.properties core/src/main/resources/hudson/tasks/Shell/config.groovy core/src/main/resources/hudson/tasks/Shell/config.properties core/src/main/resources/hudson/tasks/Shell/help-unstableReturn.html test/src/test/java/hudson/tasks/BatchFileTest.java test/src/test/java/hudson/tasks/ShellTest.java http://jenkins-ci.org/commit/jenkins/720b75f096e573b102323b529ec952e2106d4a57 Log: Merge pull request #2563 from stochmial/shell-setunstable-rebased JENKINS-23786 Permit the Shell plugin to set a build result as unstable via a return code Compare: https://github.com/jenkinsci/jenkins/compare/74c534207ca0...720b75f096e5

Add Comment

[scm_issue_link@java.net (JIRA)]

SCM/JIRA link daemon commented on JENKINS-23786

Re: Permit "Execute shell" jobs to return 2 for "unstable"

Code changed in jenkins User: Craig Ringer Path: core/src/main/java/hudson/tasks/BatchFile.java core/src/main/resources/hudson/tasks/BatchFile/config.jelly core/src/main/resources/hudson/tasks/BatchFile/config.properties test/src/test/java/hudson/tasks/BatchFileTest.java http://jenkins-ci.org/commit/jenkins/4b067fdf15fc1568ce27a921e41047201047507b Log: JENKINS-23786: Allow batch files to set an exit code for unstable builds

Add Comment

[dbeck@cloudbees.com (JIRA)]

Daniel Beck resolved as Fixed

Fixed towards 2.26 Jenkins / JENKINS-23786

Permit "Execute shell" jobs to return 2 for "unstable"

Change By: Daniel Beck Status: Open Resolved Resolution: Fixed

Add Comment

[o.v.nenashev@gmail.com (JIRA)]

Oleg Nenashev commented on JENKINS-23786

Re: Permit "Execute shell" jobs to return 2 for "unstable" The fix also includes https://github.com/jenkinsci/jenkins/pull/2563/commits/359548efa074f9ed3537552f5f9f2b51faf33e25

Add Comment

[Martin.Jost@nokia.com (JIRA)]

Martin Jost commented on JENKINS-23786

Re: Permit "Execute shell" jobs to return 2 for "unstable"

So what is now the behaviour ? From what I understand from https://github.com/jenkinsci/jenkins/blob/master/core/src/main/resources/hudson/tasks/Shell/help-unstableReturn.html: 0: pass (green) "The value 0 is ignored and does not make the build unstable to keep the default behaviour consistent." 1: red (fail) ? Or can this also be used for "unstable" ? a configurable value (!= 0) meaning "unstable" What about other exit values ? Will they make the job red ? Is it possible to switch the behaviour off (to old behaviour (0:"pass"; all else "fail") to ease transition to the version containing this ?

Add Comment

[dbeck@cloudbees.com (JIRA)]

Daniel Beck commented on JENKINS-23786

Re: Permit "Execute shell" jobs to return 2 for "unstable"

Is it possible to switch the behaviour off (to old behaviour (0:"pass"; all else "fail") to ease transition to the version containing this ? Quoting the help text, emphasis mine: If set, the shell exit code that will be interpreted as an unstable build result.

Add Comment

[gentoo.integer@gmail.com (JIRA)]

Kanstantsin Shautsou commented on JENKINS-23786

Re: Permit "Execute shell" jobs to return 2 for "unstable"

It was pretty easy to change status with touch file and make conditional status change on file. If jenkins interprets exit code 2 specially then it crazy regression, already existing jobs may use unstable for deployment, while failed shell script shouldn't provide the way to trigger build. http://tldp.org/LDP/abs/html/exitcodes.html#EXITCODESREF

Add Comment

[gentoo.integer@gmail.com (JIRA)]

Kanstantsin Shautsou commented on JENKINS-23786

Re: Permit "Execute shell" jobs to return 2 for "unstable"

Huh, found that it configurable, hope it disabled by default.

Add Comment

[alexej.ismailov@gmail.com (JIRA)]

Alexej Ismailov commented on JENKINS-23786

Re: Permit "Execute shell" jobs to return 2 for "unstable"

I'm sorry if this is a stupid question, but how do I use this? How to configure jenkins to interpret exit code 2 as unstable? If I do this inside a step:  sh returnStatus:true, script: 'exit 2' I get same behaviour as if I would exit with 1: 11:27:13 Catching error for later recovery: hudson.AbortException: script returned exit code 2...[Pipeline] End of PipelineERROR: script returned exit code 2 Finished: FAILURE

Add Comment

This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)

[alexej.ismailov@gmail.com (JIRA)]

Alexej Ismailov edited a comment on JENKINS-23786

Re: Permit "Execute shell" jobs to return 2 for "unstable"

I'm sorry if this is a stupid question, but how do I use this? How to configure jenkins to interpret exit code 2 as unstable? If I do this inside a step:  sh returnStatus:true, script: 'exit 2' I get same behaviour as if I would exit with 1:

* {noformat} 11:27:13 *   Catching error for later recovery: hudson.AbortException: script returned exit code 2

... [Pipeline] End of PipelineERROR: script returned exit code 2 Finished: FAILURE

{noformat}

Add Comment

[alexej.ismailov@gmail.com (JIRA)]

Alexej Ismailov edited a comment on JENKINS-23786

Re: Permit "Execute shell" jobs to return 2 for "unstable"

I'm sorry if this is a stupid question, but how do I use this? How to configure jenkins to interpret exit code 2 as unstable? If I do this inside a step:  sh returnStatus:true, script: ' """ exit 2 ' """ I get same behaviour as if I would exit with 1:

{noformat} 11:27:13 Catching error for later recovery: hudson.AbortException: script returned exit code 2

... [Pipeline] End of PipelineERROR: script returned exit code 2 Finished: FAILURE {noformat}

Add Comment

[Aaron.Marasco@BIA-Boeing.com (JIRA)]

Aaron Marasco commented on JENKINS-23786

Re: Permit "Execute shell" jobs to return 2 for "unstable"

Alexej Ismailov all of the above examples, being from 2016, were probably using the "classic" interface which has a field in the UI. In pipeline code, you want to use the "returnStatus" flag when calling sh - see https://jenkins.io/doc/pipeline/steps/workflow-durable-task-step/#sh-shell-script - unfortunately you cannot use "returnStdout" at the same time; see JENKINS-44930.

Add Comment

[rvernica@gmail.com (JIRA)]

Rares Vernica updated an issue

Jenkins / JENKINS-23786

Permit "Execute shell" jobs to return 2 for "unstable"

Change By: Rares Vernica Attachment: exit-unstable.png

Add Comment

[rvernica@gmail.com (JIRA)]

Rares Vernica commented on JENKINS-23786

Re: Permit "Execute shell" jobs to return 2 for "unstable" See this screenshot on how you can set it. Notice the Exit code to set build unstable field.

Add Comment