Groups
Groups
Sign in
Groups
Groups
Jenkins Developers
Conversations
About
Send feedback
Help
[Review Request] PR to fix junit-plugin issue JENKINS-42438
25 views
Skip to first unread message
Matthias Fuchs
unread,
Apr 24, 2017, 12:27:52 PM
4/24/17
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to Jenkins Developers
Hi,
could anyone of you please review
https://github.com/jenkinsci/junit-plugin/pull/66
?
The issue is that the unit-test-class duration is calculated wrongly for Android-Tests, which makes the Parallel Test Executor Plugin useless.
This PR reverts a few lines of a previous commit that introduced a bug (JENKINS-42438).
The actual code changes are less than 5 LOC that partially revert a cmomit that introduced JENKINS-42438.
The rest are unit tests.
Best,
Matthias
Oleg Nenashev
unread,
Apr 25, 2017, 5:44:53 AM
4/25/17
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to Jenkins Developers
Responded.
IMHO it would be better to have a more intelligent float number parser compatible with JUnit XML specification
понедельник, 24 апреля 2017 г., 18:27:52 UTC+2 пользователь Matthias Fuchs написал:
Matthias Fuchs
unread,
Apr 26, 2017, 3:57:50 AM
4/26/17
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to jenkin...@googlegroups.com
Thanks for your comment.
Unfortunately I fail to see how the fixed issue relates to float parsing.
Could you please give me a hint there?
Best,
Matthias
> --
> You received this message because you are subscribed to a topic in the
> Google Groups "Jenkins Developers" group.
> To unsubscribe from this topic, visit
>
https://groups.google.com/d/topic/jenkinsci-dev/atG9LSK13dQ/unsubscribe
.
> To unsubscribe from this group and all its topics, send an email to
>
jenkinsci-de...@googlegroups.com
> <mailto:
jenkinsci-de...@googlegroups.com
>.
> To view this discussion on the web visit
>
https://groups.google.com/d/msgid/jenkinsci-dev/83a9f7a2-bed9-4506-af9e-2812da28f207%40googlegroups.com
> <
https://groups.google.com/d/msgid/jenkinsci-dev/83a9f7a2-bed9-4506-af9e-2812da28f207%40googlegroups.com?utm_medium=email&utm_source=footer
>.
> For more options, visit
https://groups.google.com/d/optout
.
Reply all
Reply to author
Forward
0 new messages