Automated plugin release failing on 'check interesting categories' step

[José Lamas Ríos]

Hi, 

I'm having problems with the automated release workflow for genexus-plugin.

For instance, this CD run at https://github.com/jenkinsci/genexus-plugin/runs/5325279945

After the successful build it gets to create the release draft, but then seems to fail at finding it with an interesting category, so the release is not fired.

The draft release was created at https://github.com/jenkinsci/genexus-plugin/releases/tag/untagged-1934fa52b049ad8ace3d and running these commands on my terminal does seem to work:

McJLR:~jlr$ RESULT=$(gh api /repos/jenkinsci/genexus-plugin/releases | jq -e -r '.[] | select(.draft == true and .name == "next") | .body' | egrep "$INTERESTING_CATEGORIES" || echo 'failed')

McJLR:~ jlr$ echo $RESULT

## 🐛 Bug fixes

Any ideas?

Thanks in advance,

[José Lamas Ríos]

Maybe unrelated but I've just noticed that the release draft that was just created and is listed as the most recent one but shows a Dec 10 2021 date...

There is in fact another release on that date that is not in draft state but (probably due to some error on my part) got published while keeping the 'next' tag / name.

I'll later try renaming or deleting the old release and check if that fixes the problem. 

[Tim Jacomb]

We were just discussing this here:

https://github.com/jenkinsci/dark-theme-plugin/pull/170#issuecomment-1050263227

By using a manual trigger to bypass the interesting category check and publishing the release notes myself I was able to get the release out

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/c742b7c1-e2e2-456a-a6ab-d2a56f76fb36n%40googlegroups.com.

[Alex]

To amend my comment on the dark-theme-plugin PR, I got the action somewhat of working by wiping the additional drafts and keeping one that covers all.

I'm using release-drafter via GitHub actions outside of Jenkins too and have repositories with several drafts with different entries, so I'm not sure whether that is an actual issue with CD or GH actions/release-drafter itself.

However, I didn't make it as far as Tim, because the "release" step fails with a 403 on deployment for me. That failure creates a new draft and we're basically back at step one.

[Alex]

I got it working by exchanging the GitHub token in the workflow with a PAT: https://github.com/jenkinsci/purge-build-queue-plugin/commit/3e0e709bf62ec15a84d5bf4e2e81a98ace7b79bf

I guess, GitHub either changed or broke something (both I'm currently unaware of), because the regular GH token suffices and grants read/write perms to all scopes, unless you change the workflow permission to read only for content, but that doesn't apply here. 

[Tim Jacomb]

Weirdly if I run all the steps locally from the GitHub action I'm getting the right results =/

https://github.com/jenkinsci/jenkins-infra-test-plugin/runs/5330785488?check_suite_focus=true

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/badbb90d-1358-48c4-809a-0462c08c9c00n%40googlegroups.com.

[Alex]

Looks like others had the same idea like me and got it working with a PAT: https://github.com/release-drafter/release-drafter/issues/1081#issuecomment-1050099868 

Or locally like it does work for you.

[José Lamas Ríos]

Thank you all for your comments and help.

tl;dr: seems to be working now (last PR merge resulted in a new release)

FTR: some notes about what I did:

1. Last night I manually ran the workflow to see if it made any difference that there was already a release draft. 
1. It created an additional release draft https://github.com/jenkinsci/genexus-plugin/releases/tag/untagged-1934fa52b049ad8ace3d in addition to the previous one at https://github.com/jenkinsci/genexus-plugin/releases/tag/untagged-7aa3d1fa5d120e7a8b1a. Both are shown as created Dec 10 2021, though it might simply be a problem with the web site logic fetching the date for release with that 'next' name and getting the data for the old one (name is not unique). 
• The check interesting categories did return true, the release was triggered, although it failed for some reason I could not understand (the build shows as success but at the end it says the "Process completed with exit code 4". https://github.com/jenkinsci/genexus-plugin/runs/5326733932?check_suite_focus=true
• An additional release dr
2. Then this morning tried:
• Deleted the release drafts mentioned above
• Also deleted that old 'next' release that was actually published.
• Fired the workflow again (https://github.com/jenkinsci/genexus-plugin/runs/5333860868?check_suite_focus=true)
• A new release draft was created, which again shows the Dec 10 2021 date and references the commit at that time (https://github.com/jenkinsci/genexus-plugin/commit/a6dbd90e9ec54c3b9ca1e3f9888cc8a2e9f1ebc5)
• The package was created at https://repo.jenkins-ci.org/releases/org/jenkins-ci/plugins/genexus/294.v9475d0bc3504/ but then the release failed with a 403 error when trying to transfer it to maven.jenkins-ci.org.
3. Later:
• Delete the latest release draft.
• Delete the git tag 'next' 
• Fired workflow (https://github.com/jenkinsci/genexus-plugin/actions/runs/1899441015)
• The new draft was correctly created (no date, no tag) https://github.com/jenkinsci/genexus-plugin/releases/tag/untagged-298c04db8291690da8f9
• Release failed again with same 403 error.
4. Last:
• Merged a PR from dependabot (Bumps actions/setup-java from 2.5.0 to 3) https://github.com/jenkinsci/genexus-plugin/pull/30
• CD was automatically fired and completed without errors (https://github.com/jenkinsci/genexus-plugin/actions/runs/1899746441) resulting in
• New release published https://github.com/jenkinsci/genexus-plugin/releases/tag/296.v7ea4debe37c9

You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/110lPg1O2u0/unsubscribe.
To unsubscribe from this group and all its topics, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/de8037a9-c7fe-4142-885d-7ccb8b52eb1bn%40googlegroups.com.

[Alex]

I had a chat with a GitHub staff member earlier:

Hi Alex,

Thank you for your patience with this issue.

Our team verified today that a releases feature flag that was enabled yesterday caused the experienced behavior with accessing draft releases from API calls authenticated with GITHUB_TOKEN.

This flag was disabled earlier today, so accessing draft releases via API should work as expected again. This flag will remain disabled until our engineering team investigates and addresses the impact it had on using GITHUB_TOKEN.

Please let us know if there is anything else we can help out with. Thank you again for writing in about this behavior!

I can verify it works again, however, if you have several release drafts, you should get rid of them nevertheless. Only the newest entry is edited, as supposed to be.

~Alex

 

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CABFj%2Bga8yPt3JBAGYC2XhRPWXJzYvC6OnDp5qsZwi_b94SN%3DVg%40mail.gmail.com.