Build pipeline plugin pull request review

[Jeff Storey]

Hi,

I had opened a pull request about a week ago to fix a few significant
issues with the build pipeline plugin not working for parameterized
builds (the issues fixes here were mentioned in 7 different JIRA
issues that I found). This is my first commit to Jenkins, so I was
hoping someone could review and merge the request.

https://github.com/jenkinsci/build-pipeline-plugin/pull/56

Thank you,
Jeff Storey

[Kanstantsin Shautsou]

Hi, this plugin maintained by centrum company, but they disappeared. Added them in CC again.

I released previous version with hotfixes, i will try to look/test your PR when i will have time (if nobody do it earlier).

[Kanstantsin Shautsou]

We're writing to let you know that the group you tried to contact (plugins) may not exist, or you may not have permission to post messages to the group. A few more details on why you weren't able to post...

Not sure how we can access them...

[Jeff Storey]

Thank you. I also tried contacting them but did not get a response.

> --
> You received this message because you are subscribed to a topic in the
> Google Groups "Jenkins Developers" group.
> To unsubscribe from this topic, visit
> https://groups.google.com/d/topic/jenkinsci-dev/qJcgynMPvlg/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to
> jenkinsci-de...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

[Kanstantsin Shautsou]

Looks good for me. 

Could somebody else review?

[Kanstantsin Shautsou]

Thanks for your PR, released as 1.4.5 and closed ~10 issues. Next time feel free to link issues between each other with "duplicates".

[Jeff Storey]

Thanks. I'll be sure to update jira in the future.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/cef48399-f67f-48ac-89c5-f0e17fb73fb8%40googlegroups.com.