Enabling ImgBot in jenkinsci and in jenkins-infra/jenkins.io?

[Oleg Nenashev]

Hi all,

I would like to enable ImgBot in some of my plugins in order to optimize image sizes. ImgBot is a bot which creates pull requests with image optimizations, e.g. here is a sample pull requests for the Jenkins Core: https://github.com/oleg-nenashev/jenkins/pull/38. There are a lot of historical images in Jenkins, and it could be a good opportunity to optimize them. 

There is a free open-source plan for ImgBot, so I think enabling the bot should not be a problem. As for other bots, I suggest we enable it in the org but do not enable it widely by default. Each plugin maintainer will be able to enable it on his/her own.

What do you think?

Thanks in advance,

Oleg

[Raihaan Shouhell]

I think its a good idea  +1

[Tim Jacomb]

+1

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/98b1fe89-d010-40e2-8103-a70d085fcdd0%40googlegroups.com.

[Rick]

+1

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3Bif8h7iOuAD9tROEJ2apH4ZVSOASHC1mVA5nsT9oY1t%2BVA%40mail.gmail.com.

--

Zhao Xiaojie (Rick)

Blog: https://github.com/LinuxSuRen

Twitter: https://twitter.com/suren69811254

[Mark Waite]

+1

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3Bif8h7iOuAD9tROEJ2apH4ZVSOASHC1mVA5nsT9oY1t%2BVA%40mail.gmail.com.

--

Thanks!

Mark Waite

[Marky Jackson]

+1

{     
    "regards" : {
         "name" : “marky”,
         "phone" : "+1 (408) 464 2965”,
         "email" : “marky.r...@gmail.com",
         "team" : “jackson5“,

 “role” : “software engineer"
     }
 }

On Oct 7, 2019, at 6:06 AM, Rick <linux...@gmail.com> wrote:



To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAMM7nTEGMK%3DGYb6u-19OpZwZBE8se4SoPK%2BrcecN3r4Q8JQ_DA%40mail.gmail.com.

[Baptiste Mathus]

I'm a bit unconvinced this really changes the situation given things are still versioned and kept in the repo history, but still +1 why not! :)

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLDM57J9zbP-MKrvQ64R%3Dm5xKLu%2BY235WM41NUYkr6EEQw%40mail.gmail.com.

[Liam Newman]

It's not about size in the repo but size being served.  +1. 

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPyTVp3wet6VecECQqZDLAiTOHERfuPXsZ%2BhpNDLefDxS8tr6w%40mail.gmail.com.

[Oleg Nenashev]

Yes, it is only about the served/packaged size. There is no practical way to change the repo size, and optimizing images will actually increase that slightly.

But it is important to have content size optimized to improve loading times over network and to reduce package sizes

P.S: Don't forget to test it on the Chuck Norris plugin!

On Monday, October 7, 2019 at 5:37:12 PM UTC+2, Liam Newman wrote:

It's not about size in the repo but size being served.  +1. 

On Mon, Oct 7, 2019 at 8:25 AM Baptiste Mathus <bma...@cloudbees.com> wrote:

I'm a bit unconvinced this really changes the situation given things are still versioned and kept in the repo history, but still +1 why not! :)

Le lun. 7 oct. 2019 à 10:09, Oleg Nenashev <o.v.n...@gmail.com> a écrit :

Hi all,

I would like to enable ImgBot in some of my plugins in order to optimize image sizes. ImgBot is a bot which creates pull requests with image optimizations, e.g. here is a sample pull requests for the Jenkins Core: https://github.com/oleg-nenashev/jenkins/pull/38. There are a lot of historical images in Jenkins, and it could be a good opportunity to optimize them. 

There is a free open-source plan for ImgBot, so I think enabling the bot should not be a problem. As for other bots, I suggest we enable it in the org but do not enable it widely by default. Each plugin maintainer will be able to enable it on his/her own.

What do you think?

Thanks in advance,

Oleg

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkin...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLDM57J9zbP-MKrvQ64R%3Dm5xKLu%2BY235WM41NUYkr6EEQw%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkin...@googlegroups.com.

[Oleg Nenashev]

Thanks all, I have enabled it in the org. Feel free to add it to your repositories which have images.

First pull request: https://github.com/jenkinsci/role-strategy-plugin/pull/108

[Ullrich Hafner]

How do I add it to a repository? It is not listed below

https://github.com/jenkinsci/warnings-ng-plugin/settings/installations

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/c3b28a11-7c25-4e90-a71e-2ed0c80388eb%40googlegroups.com.

[Oleg Nenashev]

You should be able to configure it using https://github.com/organizations/jenkinsci/settings/installations/2628097

Please let me know if it does not work

On Tuesday, October 8, 2019 at 9:20:08 AM UTC+2, Ullrich Hafner wrote:

How do I add it to a repository? It is not listed below

https://github.com/jenkinsci/warnings-ng-plugin/settings/installations

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/c3b28a11-7c25-4e90-a71e-2ed0c80388eb%40googlegroups.com.

[Ullrich Hafner]

I get a 404 :-(

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/2e9b475e-c3e7-40a4-bba0-ef626aee5151%40googlegroups.com.

[Oleg Nenashev]

Anyway, enabled it for you. Will figure out what is the official way to manage it.

Are there any opinions about enabling it in the Jenkins core? As usual, it implies giving a bot a Write permission so that it can create PRs in local branches...

You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/DQrz2p3ddJE/unsubscribe.
To unsubscribe from this group and all its topics, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/0215B490-60E6-4B95-AE68-B241A89949BF%40gmail.com.

[Arnaud Héritier]

The same I cannot add / change anything in https://github.com/jenkinsci/cloudbees-jenkins-advisor-plugin/settings/installations

And if I go on the app side I can install it only in organisations I am an admin https://github.com/marketplace/imgbot

Only jenkinsci admins can either activate the bot on some repo or globally for all of them.

I am not sure there is any risk to do it globally 

Can you captivate it fir cloudbees-jenkins-advisor-plugin please? 

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLBLa06jCU1htSoozbsNSiWXrxdhM5qryFLE_Fy%2Bfjg%3Dgw%40mail.gmail.com.

--

-----

Arnaud Héritier

http://aheritier.net

Mail/GTalk: aheritier AT gmail DOT com

Twitter/Skype : aheritier

[Oleg Nenashev]

Is everyone fine with enabling it for the Jenkins Core repository?

Just to check whether we are ready for it

On Tuesday, October 8, 2019 at 1:04:06 PM UTC+2, Arnaud Héritier wrote:

The same I cannot add / change anything in https://github.com/jenkinsci/cloudbees-jenkins-advisor-plugin/settings/installations

And if I go on the app side I can install it only in organisations I am an admin https://github.com/marketplace/imgbot

Only jenkinsci admins can either activate the bot on some repo or globally for all of them.

I am not sure there is any risk to do it globally 

Can you captivate it fir cloudbees-jenkins-advisor-plugin please? 

On Tue, Oct 8, 2019 at 12:55 PM Oleg Nenashev <o.v.n...@gmail.com> wrote:

Anyway, enabled it for you. Will figure out what is the official way to manage it.

Are there any opinions about enabling it in the Jenkins core? As usual, it implies giving a bot a Write permission so that it can create PRs in local branches...

On Tue, Oct 8, 2019 at 12:51 PM Ullrich Hafner <ullric...@gmail.com> wrote:

I get a 404 :-(

To unsubscribe from this group and stop receiving emails from it, send an email to jenkin...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/2e9b475e-c3e7-40a4-bba0-ef626aee5151%40googlegroups.com.

--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/DQrz2p3ddJE/unsubscribe.

To unsubscribe from this group and all its topics, send an email to jenkin...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/0215B490-60E6-4B95-AE68-B241A89949BF%40gmail.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkin...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLBLa06jCU1htSoozbsNSiWXrxdhM5qryFLE_Fy%2Bfjg%3Dgw%40mail.gmail.com.

[Mark Waite]

No objections from me.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/c3b2af21-2565-4592-83a2-f9cf26e144fb%40googlegroups.com.

--

Thanks!

Mark Waite

[Gavin]

None from me

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtHQZoL4vm37Qm0zE9fFYuNDoOcYQXOT-RH5yjaaWZM61Q%40mail.gmail.com.