--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CALzHZS0bvoSb0CDYCEhhKfiwUHwayZ-mRxaCUNPfZGSC9Gzp7Q%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtEYz1rDjaaJV4j9hSZ0cNVwmFNTxw2oRxOh%2BkOD5Dv3rA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CALzHZS0vwdeyt%2BaLqKSfMFicQCnbG2%3DGKHEmmCwyYL%2Bx50ztTA%40mail.gmail.com.
If it's configured to run when you do mvn install it should be picked up automagically as long as xmlOutput is configured in the pom.
/B
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtEk6aq-NLKe-L4C_E17A-btzb%2B0%3DKtae6Er2MNpQJ3i%3Dw%40mail.gmail.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CALzHZS2aMPkNFnJKRbxQc96nzRYM%2BQBPNWLZd0hcjrwq%2BC99kw%40mail.gmail.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtGgrKPAb%2B6nUQrcE-R16-rSxpq4fem4-RHq8cOVygAJmg%40mail.gmail.com.
I've changed the plugin template for maven to pick up findbugs and checkstyle reports (on ttps://jenkins.ci.cloudbees.com) if any is generated by the build. So if plugin builds starts to fail for that reason you know who to blame ;) But it shouldn't change anything for existing jobs unless you actively do something.I've also added config options to run findbugs and mark the build as unstable if any findbugs issues are found, so maintainers can opt in for that if they want to.
<
executions
>
<!--
Ensures that FindBugs inspects source code when project is compiled.
-->
<
execution
>
<
id
>analyze-compile</
id
>
<
phase
>compile</
phase
>
<
goals
>
<
goal
>check</
goal
>
</
goals
>
</
execution
>
</
executions
>
--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/d5d9503b-01c0-4665-97ba-0833b42f1d1c%40googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtGgrKPAb%2B6nUQrcE-R16-rSxpq4fem4-RHq8cOVygAJmg%40mail.gmail.com.
--Robert SandellSoftware EngineerCloudBees Inc.
Where did you get this option [findbugsXmlWithMessages] ?
--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/bdc1168a-e2ac-494a-a26b-93c86ed94235%40googlegroups.com.
Seems CloudBees decided to do it mass wide without discussing with Jenkins community. ... Also, why only FB? Why not enable PMD? Why not silently enable all static analysing collectors for jobs?
jenkinsci/pom defines findbugs version in property https://github.com/jenkinsci/pom/blob/master/pom.xml#L623 , no need create custom property
Naming of strict variable is inconsistent
... and seems future parent pom changes wasn't discussed in dev list https://github.com/jenkinsci/maven-plugin/pull/48/files#r34896275
On Jul 19, 2015, at 21:17, Oleg Nenashev <o.v.ne...@gmail.com> wrote:Seems CloudBees decided to do it mass wide without discussing with Jenkins community. ... Also, why only FB? Why not enable PMD? Why not silently enable all static analysing collectors for jobs?The changes are not "mass wide", but the improvement in pull request builders has been announced by Robert about two weeks ago.
There are pretty much plugins being modified, but the most of them are being maintained by by Jenkins contributors currently working at CloudBees. We want to improve the code quality of the plugins and reduce maintenance efforts by enforcing FindBugs in pull requests.
I suppose such activity does not need additional approvals, because there's no binary compatibility loss, Jenkins core dependency changes or any other breaking changes requiring the discussion.
Regarding other plugins... As any other Jenkins contributor, I'm eligible to create a pull request and then to get a feedback from plugin owners and other Jenkins contributors. Nobody merges my PRs without approvals of plugin owners. Even if there are possible improvements in the approach selected by me, I don't think that my pull requests violate any formal or informal contribution rules.
Usage of static analysis has been discussed many times on Jenkins Governance meetings.
The summary of these discussions was to encourage static analysis in plugins, so l'm strongly sure these PRs address the general need in a better quality of Jenkins plugins. FindBugs is one of the most popular tools for Java, so IMO it should be considered as an improvement even if it is a first baby step. If you want to integrate other tools, feel free to go forward, any contributions will be appreciated.
jenkinsci/pom defines findbugs version in property https://github.com/jenkinsci/pom/blob/master/pom.xml#L623 , no need create custom propertyYes, it would be correct to use this property. I was not aware about it, so I introduced my one. It is not very important,
because in plugin POMs we will definitely override this property to get newer FindBugs versions on old Jenkins cores. BTW I'll try to adjust my pull requests.
Naming of strict variable is inconsistentNo need to keep the naming consistent (it would be preferable BTW). The current plugin POM architecture is not designed for effectively sharing FindBugs configurations across plugins, because they depend on Jenkins cores.
We need a huge rework oof parent POMs architecture to make shared configs usable.
Currently plugins need to manage static analysis flows on their own.... and seems future parent pom changes wasn't discussed in dev list https://github.com/jenkinsci/maven-plugin/pull/48/files#r34896275Yes, this proposal has not been discussed yet. I'm planning to start the discussion only when I have some time to handle it's follow ups.