Removing name autocompletion in new job creation

25 views
Skip to first unread message

Samat Davletshin

unread,
Aug 8, 2016, 8:06:19 AM8/8/16
to Jenkins Developers, Tom Fennelly, rec...@gmail.com
Hello!

In my Pull Request I propose to make name validation of a new job more interactive.
https://github.com/jenkinsci/jenkins/pull/2416

However, it was noted that because of autocomplete the warning message will not always be visible.

Do you think that I should remove the autocomplete of new job name or keep it?

Tom Fennelly

unread,
Aug 8, 2016, 8:09:55 AM8/8/16
to Jenkins Developers, tfen...@cloudbees.com, rec...@gmail.com
Is autocomplete of the job name an actual feature, or just something that's there by default from the browser? If autocomplete must stay, maybe the placement of the validation warnings could be moved e.g. above the input?

Samat Davletshin

unread,
Aug 9, 2016, 1:45:31 AM8/9/16
to Jenkins Developers, tfen...@cloudbees.com, rec...@gmail.com
The autocomplete parameter  is not specified in jelly so I believe it is browser behavior remembering name="name" input.

In #2501 pull request I propose to move input box so that autocomplete will not hide warning message. What do you think?

However, I think that UI changes may complicate the initial pull request.
May be it is better to decide on leaving or removing autocomplete here and consider moving elements in a separate PR.

Tom Fennelly

unread,
Aug 9, 2016, 4:52:12 AM8/9/16
to Jenkins Developers, Tom Fennelly, rec...@gmail.com
Why move the input Vs the warning text?

--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/2qZDQe2_QxI/unsubscribe.
To unsubscribe from this group and all its topics, send an email to jenkinsci-dev+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/68ed7d22-7051-4a18-b79f-a33034fc1618%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

Samat Davletshin

unread,
Aug 11, 2016, 4:09:04 AM8/11/16
to Jenkins Developers, tfen...@cloudbees.com, rec...@gmail.com
I moved the warning message so the autocomplete would not hide it.
https://github.com/jenkinsci/jenkins/pull/2416/commits/d71406b709029b1e2e268374b345abf15e49a727

Is it ok now?
Reply all
Reply to author
Forward
0 new messages