plugin artifactId doesn't match github team name

[Victor Balakine]

Hi,

I suspect the plugin was renamed at some point, but the repo and the developers team names are still referencing the old name:

https://github.com/jenkinsci/tikal-multijob-plugin/blob/master/pom.xml#L10C3-L10C13

https://github.com/orgs/jenkinsci/teams/tikal-multijob-plugin-developers

One unintended result is that the plugin health page thinks the repo has no OWNERS configured, when in fact it does.

What's the best way forward here?

Victor

[Alexander Brandes]

Hi,

I've renamed the repository and team accordingly. But this should probably be tracked as an issue in https://github.com/jenkins-infra/plugin-health-scoring/issues, if you would be so kind and create one.

~ Alex

[Victor Balakine]

Thank you! I creaded the issue https://github.com/jenkins-infra/plugin-health-scoring/issues/531

[Victor Balakine]

Another plugin I maintain has the same issue - https://github.com/jenkinsci/global-build-stats-plugin

The artifactId is `global-build-stats`, but the repo name is `global-build-stats-plugin` and the team name is `global-build-stats-plugin-developers`.

I would really appreciate if someone with higher powers could help me rename the repo and the team name.

Thank you!

[Tim Jacomb]

Hi

That’s normal, artifact ids are normally the repo name with -plugin dropped and team names are normally repo name + -developers

Cheers

Tim

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/5b01787c-a0c5-4fa7-bd87-90d273dea0e6n%40googlegroups.com.

[Victor Balakine]

Thank you, Tim! Then I just have to wait for the next scan of the global-build-stats plugin.

Back to the jenkins-multijob-plugin plugin then. Is this artifactId not following the convention?
https://github.com/jenkinsci/jenkins-multijob-plugin/blob/master/pom.xml#L10C14-L10C37

Renaming the artifact is more troublesome, if I understand things correctly. So should the repo be called `jenkins-multijob-plugin-plugin` and the team - `jenkins-multijob-plugin-plugin-developers`?

At least the code ownership probe does seem to check for the existing `-plugin` suffix and just adds it regardless https://github.com/jenkins-infra/plugin-health-scoring/blob/main/core/src/main/java/io/jenkins/pluginhealth/scoring/probes/CodeOwnershipProbe.java

[Baptiste Mathus]

Please no, let's not rename this way with -plugin-plugin. It would be very weird, and does not sound like a correct fix :). 

Seems like this case works OK for https://github.com/jenkinsci/maven-plugin though?

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/fe1f8f9c-ea42-4354-872b-b5e874776669n%40googlegroups.com.

[Victor Balakine]

I see the same issue with maven-plugin - the OWNERS file is there, but the health probe fails
https://plugins.jenkins.io/maven-plugin/healthscore/#:~:text=Repository%20would%20benefit%20from%20defining%20the%20code%20ownership.