Request PR merge or commit rights granted to accept PR on chromedriver-plugin

37 views
Skip to first unread message

rouke.b...@infosupport.com

unread,
Mar 5, 2018, 2:34:02 AM3/5/18
to Jenkins Developers
Noticed a PR on https://github.com/jenkinsci/chromedriver-plugin/pull/4 that hasn't seen any attention which is understandable since the only person that did any significant work on it was kohsuke.
Can someone please merge this or grant me access so I can do it myself? If granted commit rights I will of course also file a PR on https://github.com/jenkins-infra/repository-permissions-updater.

Github user: Mobrockers
Jenkins user: Mobrockers

rouke.b...@infosupport.com

unread,
Mar 12, 2018, 5:03:19 AM3/12/18
to Jenkins Developers
Ping

Daniel Beck

unread,
Mar 12, 2018, 6:37:31 AM3/12/18
to jenkin...@googlegroups.com

> On 5. Mar 2018, at 08:34, rouke.b...@infosupport.com wrote:
>
> Noticed a PR on https://github.com/jenkinsci/chromedriver-plugin/pull/4 that hasn't seen any attention which is understandable since the only person that did any significant work on it was kohsuke.
> Can someone please merge this or grant me access so I can do it myself? If granted commit rights I will of course also file a PR on https://github.com/jenkins-infra/repository-permissions-updater.
>

Could you clarify whether you want to just merge and release this one change, or take over maintainership?

In general it's probably helpful to just file that PR -- you're going to need it anyway --, as we are less likely to lose that, compared to emails to the list ;-)

rouke.b...@infosupport.com

unread,
Mar 12, 2018, 8:49:56 AM3/12/18
to Jenkins Developers
I don't think that plugin is going to need many changes anyway, and I am not planning to really do any development on it. I am willing to review pull requests and respond to issues if they might come up but the plugin is pretty much finished as is IMO.
I have some ideas to merge this plugin into a plugin that downloads and installs all webdrivers on demand but I don't currently use selenium anyway so don't have time or a need for that. (some day)
Reply all
Reply to author
Forward
0 new messages