ruby-runtime and pull requests (x-post from jenkins.rb)

[njac...@rallydev.com]

Hello All,

I see two repos in github for the ruby-runtime plugin. One is independent ( https://github.com/jenkinsci/ruby-runtime-plugin ) and the other appears to be merged into the Jenkins.rb project ( https://github.com/jenkinsci/jenkins.rb/tree/master/ruby-runtime ). Can someone please let me know which of these repos pull requests for ruby-runtime should be issued against? Also, which commit was the current ruby-runtime 0.12 plugin that is on Jenkins released from? I can see there is a tag jenkins ruby-runtime-parent-0.12 in the jenkins.rb repository. Is this the commit from which the 0.12 plugin found at https://updates.jenkins-ci.org/download/plugins/ruby-runtime/ was released?

We are having issues with the 0.12 ruby-runtime installing on a Windows server due to a bug in JRuby that will not parse paths with spaces. Updating to JRuby 1.7.16 appears to fix this problem. We would like to issue a pull request, but cloning the master and/or the 0.12-parent tag both appear to introduce a problem with unpacking the lib/classes.jar that was resolved with the 0.12 release.

Thanks for all your help!

Nikki

[Eito Katagiri]

Hello,

On Thu, Nov 20, 2014 at 9:06 AM, <njac...@rallydev.com> wrote:
> Hello All,
>
> I see two repos in github for the ruby-runtime plugin. One is independent (
> https://github.com/jenkinsci/ruby-runtime-plugin ) and the other appears to
> be merged into the Jenkins.rb project (
> https://github.com/jenkinsci/jenkins.rb/tree/master/ruby-runtime ). Can
> someone please let me know which of these repos pull requests for
> ruby-runtime should be issued against? Also, which commit was the current
> ruby-runtime 0.12 plugin that is on Jenkins released from? I can see there

You should submit your PR to https://github.com/jenkinsci/jenkins.rb repo.

> is a tag jenkins ruby-runtime-parent-0.12 in the jenkins.rb repository. Is
> this the commit from which the 0.12 plugin found at
> https://updates.jenkins-ci.org/download/plugins/ruby-runtime/ was released?

I am not sure about it.

> We are having issues with the 0.12 ruby-runtime installing on a Windows
> server due to a bug in JRuby that will not parse paths with spaces. Updating
> to JRuby 1.7.16 appears to fix this problem. We would like to issue a pull
> request, but cloning the master and/or the 0.12-parent tag both appear to
> introduce a problem with unpacking the lib/classes.jar that was resolved
> with the 0.12 release.

Do you know if the master branch on jenkinsci/jenkins.rb contains fix
you mentioned?


HTH,

Eito

[Joshua Stupplebeen]

Hi Eito,

I submitted a pull request to fix this and a few other issues:  https://github.com/jenkinsci/jenkins.rb/pull/104.  If you or someone else could take a look I'd really appreciate it.

Thank you!

Josh