Pull Requests & Jenkins Core

[Suckow, Thomas J]

Dear all,

I am trying to figure out the best way to get a pull request accepted. This is a very community run organization and as such there are many updates and weekly releases. Though it appears (with the exception of translations) the last month has been "only people with commiter access get their changes in core." So what is the best way to move forward with getting a change in the Core when you are not a commiter?

Any feedback is welcome. Even "Your PR sucks because of X," because then I know what needs to be fixed.

The issue I am trying to get fixed: https://issues.jenkins-ci.org/browse/JENKINS-27034

--

Thomas

PS: I would ask this on IRC if it wasn't blocked/banned from our corporate network. If I really need to discuss this on IRC, I can join from home sometime.

[Jesse Glick]

On Mon, Mar 2, 2015 at 11:28 AM, Suckow, Thomas J
<Thomas...@pnnl.gov> wrote:
> Any feedback is welcome. Even "Your PR sucks because of X," because then I
> know what needs to be fixed.

For https://github.com/jenkinsci/jenkins/pull/1569 what is missing at
first glance is a test case to reproduce the problem. I understand
that you struggled to write such a test and could not, but that just
means that someone who does know how to write the test needs to spend
time working on it.

We do strive to review incoming PRs but they come in at quite a pace,
and many are not in mergeable condition when filed.