Are Labels truly singletons?

[Suckow, Thomas J]

I have come across an issue where Queue uses == to compare Labels. This is fine if they are truly singletons. However, somehow [and I don't know why] I am getting an item in the queue with a Label that is not a singleton.

The question becomes, are Labels singletons? Do I make a PR changing == to equals? Or somehow attempt to find where this rogue Label is coming from (It is intermittent, and nothing was obvious in my suspect plugins)?

-

Thomas

[Jesse Glick]

On Mon, Feb 9, 2015 at 7:29 PM, Suckow, Thomas J <Thomas...@pnnl.gov> wrote:
> The question becomes, are Labels singletons? Do I make a PR changing == to equals?

Should use equals(), as implied by the comment on Jenkins.labels and
the existing of the equals override.

[Suckow, Thomas J]

Alright, I have made a pull request resolving a number of label equality
issues.
https://github.com/jenkinsci/jenkins/pull/1569


Should I make a formal JIRA issue and cross reference them?

-
Thomas

>--
>You received this message because you are subscribed to the Google Groups
>"Jenkins Developers" group.
>To unsubscribe from this group and stop receiving emails from it, send an
>email to jenkinsci-de...@googlegroups.com.
>To view this discussion on the web visit
>https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr1UCyfCmvUCBY%2ByfCN
>UmXr-jKDRG1L%3DNc_PttiWnjNtMg%40mail.gmail.com.
>For more options, visit https://groups.google.com/d/optout.

[Stephen Connolly]

On Wednesday, February 18, 2015, Suckow, Thomas J <Thomas...@pnnl.gov> wrote:

Alright, I have made a pull request resolving a number of label equality
issues.
https://github.com/jenkinsci/jenkins/pull/1569


Should I make a formal JIRA issue and cross reference them?

Yes  

-
Thomas

On 2/18/15, 12:40 PM, "Jesse Glick" <jgl...@cloudbees.com> wrote:

>On Mon, Feb 9, 2015 at 7:29 PM, Suckow, Thomas J <Thomas...@pnnl.gov>
>wrote:
>> The question becomes, are Labels singletons? Do I make a PR changing ==
>>to equals?
>
>Should use equals(), as implied by the comment on Jenkins.labels and
>the existing of the equals override.
>
>--
>You received this message because you are subscribed to the Google Groups
>"Jenkins Developers" group.
>To unsubscribe from this group and stop receiving emails from it, send an
>email to jenkinsci-de...@googlegroups.com.
>To view this discussion on the web visit
>https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr1UCyfCmvUCBY%2ByfCN
>UmXr-jKDRG1L%3DNc_PttiWnjNtMg%40mail.gmail.com.
>For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/D10A5580.F542%25thomas.suckow%40pnnl.gov.

For more options, visit https://groups.google.com/d/optout.

--
Sent from my phone

[Suckow, Thomas J]

Done.

https://issues.jenkins-ci.org/browse/JENKINS-27034

Thank you for your responses.

-

Thomas

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BnPnMxmYfH3XA1hO%2B%2BbMQm%3DHbFGGF%3DH0XuptCXaFS9bYW6XEw%40mail.gmail.com.