Hi folks,
So, as you might've guessed, I don't normally monitor these conversations here and would've been oblivious to this one if Oleg hadn't CC:ed me.
Re: "
PJ Darton 7 other current maintainers"
Right now, it's just me; some years ago I contributed some stuff to the plugin, I was added as a co-maintainer by the previous maintainer, and then they left leaving me all alone.
I don't know enough about Netty vs HttpClient to pass judgement on the pros & cons of either; I have no idea why one was selected over the other back in the past, or the risks inherent in changing this now ... but this also means that I have no strong feelings for/against either as long as it all works and I don't receive a deluge of "everything broke when I upgraded to the latest version" bug reports.
Overall, I'm happy to accept PRs as long as:
- the changes seem to "fit" well with the plugin's objectivs,
- the code is good before its merged (feel free to create a work-in-progress PR that isn't ready for merging),
- it's clear (to users, to me & any future maintainers) what it does, and
- (most importantly) the changes don't break anything.
What I can't do is dedicate much time to developing this sort of thing myself; it's not a core part of "my day job" and I've got a gazillion things I should be working on instead of this
... but if you want changes made and are prepared to make it easy for me then I'm happy to cooperate.
I guess the first thing I'd need to understand is "why?" - it works "as-is" so why change it now? What are you really trying to achieve ... and how can this be (unit) tested?
Regards,
Peter