Requesting PR reviews from anyone in the jenkinsci organization

[Daniel Beck]

Hi everyone,

One of the benefits of the Everyone team was that most members of the GitHub org could be requested as reviewers. Now, with the migration from Everyone to collaborators[1], that functionality was completely gone, hindering collaboration.

I now learned that changing the default member privileges for the jenkinsci org from 'None' to 'Read' would allow any org member to be requested as reviewer. I've changed this a few minutes ago accordingly. Since the jenkinsci org exclusively has public repos, there should be no other impact.

If you experience any problems because of the above change, please file an INFRA issue for the github component.

Daniel

[1]: https://groups.google.com/d/msg/jenkinsci-dev/ksKAsmsmVng/GyZ6EQjmAAAJ

[Oleg Nenashev]

I wonder whether it also resolves the issue with mentioning code-reviewers

_______________________________________________
Jenkins-infra mailing list
Jenkin...@lists.jenkins-ci.org
http://lists.jenkins-ci.org/mailman/listinfo/jenkins-infra

[Baptiste Mathus]

For some reason, it does not work, and wasn't before either for me. Not everywhere at least, and not being admin, I couldn't check/understand why.

For instance, I still cannot request myself a review on https://github.com/jenkinsci/configuration-as-code-plugin/pull/43

Maybe it's just because some/many plugins set the permissions differently from the average, so it will work randomly depending on the conf of a given plugin?

Should we make this a part/clarification in a JEP (?) about plugin hosting /rules/? 

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLCNgreywE_X%2BGtVL1Ytb_2RUB1oSFLFq2vokg-CQRedsA%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.

[Jesse Glick]

On Tue, Feb 20, 2018 at 8:41 AM, Baptiste Mathus <m...@batmat.net> wrote:
> For instance, I still cannot request myself a review on
> https://github.com/jenkinsci/configuration-as-code-plugin/pull/43

I think only someone with write permission to the repository can
request you. Without Daniel’s trick, even they could not do so.

My standing RFE to GitHub is to allow at least the PR author to
request you, and maybe to allow you to request yourself.